[GitHub] [calcite] danny0405 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913733981 ## core/src/main/java/org/apache/calcite/sql/TableCharacteristic.java: ## @@ -0,0 +1,333 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [calcite] danny0405 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913732009 ## core/src/main/java/org/apache/calcite/sql/SqlTableFunction.java: ## @@ -30,4 +32,17 @@ public interface SqlTableFunction { * @return strategy to infer the row t

[GitHub] [calcite] danny0405 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913727713 ## core/src/main/java/org/apache/calcite/sql/SqlSetSemanticsTableOperator.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] danny0405 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913726617 ## core/src/main/java/org/apache/calcite/sql/SqlSetSemanticsTableOperator.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [calcite] rubenada commented on a diff in pull request #2848: [CALCITE-5201] Improve SemiJoinRule to match Join's right input which is unique for Join keys

rubenada commented on code in PR #2848: URL: https://github.com/apache/calcite/pull/2848#discussion_r913569721 ## core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java: ## @@ -232,6 +237,79 @@ default JoinToSemiJoinRuleConfig withOperandFor(Class joinClass, }

[GitHub] [calcite] rubenada commented on a diff in pull request #2848: [CALCITE-5201] Improve SemiJoinRule to match Join's right input which is unique for Join keys

rubenada commented on code in PR #2848: URL: https://github.com/apache/calcite/pull/2848#discussion_r913566595 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimit.java: ## @@ -96,11 +96,7 @@ public static EnumerableLimit create(final RelNode input, @Null

[GitHub] [calcite] chunweilei closed pull request #2154: [CALCITE-4223] Introducing column statistics

chunweilei closed pull request #2154: [CALCITE-4223] Introducing column statistics URL: https://github.com/apache/calcite/pull/2154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [calcite] chunweilei commented on pull request #2154: [CALCITE-4223] Introducing column statistics

chunweilei commented on PR #2154: URL: https://github.com/apache/calcite/pull/2154#issuecomment-1174799465 It's outdated. See https://github.com/apache/calcite/pull/2845. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] chunweilei commented on a diff in pull request #2848: [CALCITE-5201] Improve SemiJoinRule to match Join's right input which is unique for Join keys

chunweilei commented on code in PR #2848: URL: https://github.com/apache/calcite/pull/2848#discussion_r913543258 ## core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java: ## @@ -232,6 +237,79 @@ default JoinToSemiJoinRuleConfig withOperandFor(Class joinClass, }

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

beyond1920 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913086886 ## core/src/main/codegen/templates/Parser.jj: ## @@ -1653,6 +1657,108 @@ SqlNode NamedRoutineCall( } } +/** + * Table parameter of a table function. + * The i

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

beyond1920 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r913082995 ## core/src/main/codegen/templates/Parser.jj: ## @@ -1653,6 +1657,108 @@ SqlNode NamedRoutineCall( } } +/** + * Table parameter of a table function. + * The i

[GitHub] [calcite] danny0405 commented on a diff in pull request #2844: [CALCITE-4865] Allow table functions to be polymorphic

danny0405 commented on code in PR #2844: URL: https://github.com/apache/calcite/pull/2844#discussion_r912957334 ## core/src/main/codegen/templates/Parser.jj: ## @@ -1653,6 +1657,108 @@ SqlNode NamedRoutineCall( } } +/** + * Table parameter of a table function. + * The in

[GitHub] [calcite] libenchao commented on a diff in pull request #2843: [CALCITE-5178] Single column with ROW type generates wrong plan

libenchao commented on code in PR #2843: URL: https://github.com/apache/calcite/pull/2843#discussion_r912439911 ## core/src/main/java/org/apache/calcite/adapter/enumerable/JavaRowFormat.java: ## @@ -82,6 +83,11 @@ public enum JavaRowFormat { JavaTypeFactory typeFactory,

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2843: [CALCITE-5178] Single column with ROW type generates wrong plan

JiajunBernoulli commented on code in PR #2843: URL: https://github.com/apache/calcite/pull/2843#discussion_r912339043 ## core/src/main/java/org/apache/calcite/adapter/enumerable/JavaRowFormat.java: ## @@ -82,6 +83,11 @@ public enum JavaRowFormat { JavaTypeFactory typeFa

[GitHub] [calcite] JiajunBernoulli opened a new pull request, #2847: [CALCITE-5141] Incomplete implicit type conversion for insert values

JiajunBernoulli opened a new pull request, #2847: URL: https://github.com/apache/calcite/pull/2847 # insert values case Here is the sql ``` insert into t3 values ('a', 1.0, 1), ('b', 2, 2), ('c', 3.0, CAST(3 AS SMALLINT)), ('d', 4.0, 4), ('e', 5.0, 5) ``` the validated sql is

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r912052646 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -1362,13 +1364,98 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery)

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r912048133 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -1362,13 +1364,98 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery)

[GitHub] [calcite] asfgit closed pull request #2842: [CALCITE-4746] Pivots with pivotAgg without alias fail with Babel Par…

asfgit closed pull request #2842: [CALCITE-4746] Pivots with pivotAgg without alias fail with Babel Par… URL: https://github.com/apache/calcite/pull/2842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r908127064 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] rubenada merged pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada merged PR #2838: URL: https://github.com/apache/calcite/pull/2838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.a

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r908009008 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906838992 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3988,6 +3988,77 @@ void checkPeriodPredicate(Checker checker) { sql(sql).ok(exp

[GitHub] [calcite] beyond1920 commented on pull request #2844: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on PR #2844: URL: https://github.com/apache/calcite/pull/2844#issuecomment-1167612779 This pr is a follow up the [pr#2606](https://github.com/apache/calcite/pull/2606). -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] beyond1920 commented on pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on PR #2606: URL: https://github.com/apache/calcite/pull/2606#issuecomment-1167611442 Since the pr has not been updated for a very long time, there are so many conflicts. I create a new [PR](https://github.com/apache/calcite/pull/2844) to fix the comments you left. @

[GitHub] [calcite] beyond1920 opened a new pull request, #2844: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 opened a new pull request, #2844: URL: https://github.com/apache/calcite/pull/2844 ## What is the purpose of the change This pr aims to extend table function to support Polymorphic Table Function. ## Brief change log - Update `Parser.jj` to support partition

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r907111550 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] chunweilei merged pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

chunweilei merged PR #2837: URL: https://github.com/apache/calcite/pull/2837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[GitHub] [calcite] chunweilei commented on pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

chunweilei commented on PR #2837: URL: https://github.com/apache/calcite/pull/2837#issuecomment-1166760086 Thank you for your review, @libenchao! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [calcite] beyond1920 closed pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 closed pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF) URL: https://github.com/apache/calcite/pull/2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] beyond1920 commented on pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on PR #2606: URL: https://github.com/apache/calcite/pull/2606#issuecomment-1166591863 @julianhyde Sorry, the pull request is not ready to review again. I would rebase the pr tomorrow. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [calcite] beyond1920 commented on pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on PR #2606: URL: https://github.com/apache/calcite/pull/2606#issuecomment-1166577489 @julianhyde Thanks for your suggestions. I've fixed almost all the points you raised. I would fixed the order by conversion logical, including support null_first/ null_last, and

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906840573 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -1362,13 +1364,98 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery)

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906840696 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -1362,13 +1364,98 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery)

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906840573 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -1362,13 +1364,98 @@ private void substituteSubQuery(Blackboard bb, SubQuery subQuery)

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906839556 ## core/src/main/java/org/apache/calcite/sql/TableCharacteristic.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906838992 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3988,6 +3988,77 @@ void checkPeriodPredicate(Checker checker) { sql(sql).ok(exp

[GitHub] [calcite] beyond1920 commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

beyond1920 commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r906838046 ## core/src/main/java/org/apache/calcite/sql/SqlTableFunction.java: ## @@ -30,4 +32,15 @@ public interface SqlTableFunction { * @return strategy to infer the row

[GitHub] [calcite] JiajunBernoulli opened a new pull request, #2842: [CALCITE-4746] Pivots with pivotAgg without alias fail with Babel Par…

JiajunBernoulli opened a new pull request, #2842: URL: https://github.com/apache/calcite/pull/2842 …ser Implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [calcite] yingyuwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

yingyuwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r906274526 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] yingyuwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

yingyuwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r906274526 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] xuzifu666 commented on pull request #2839: [hotfix] in RelSubset and the method unused remove

xuzifu666 commented on PR #2839: URL: https://github.com/apache/calcite/pull/2839#issuecomment-1165344693 @vladimirdolzhenko -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r905677079 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] julianhyde merged pull request #2840: [CALCITE-5196] Bump apiguardian to 1.1.2

julianhyde merged PR #2840: URL: https://github.com/apache/calcite/pull/2840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[GitHub] [calcite] snuyanzin opened a new pull request, #2841: [CALCITE-5197] Bump gradle to 7.4.2

snuyanzin opened a new pull request, #2841: URL: https://github.com/apache/calcite/pull/2841 The PR updates gradle to 7.4.2 and adds auto update for wrapper's checksum while doing ``` ./gradlew wrapper --gradle-version && ./gradlew autostyleApply ``` based on checksums from htt

[GitHub] [calcite] snuyanzin opened a new pull request, #2840: [CALCITE-5196] Bump apiguardian to 1.1.2

snuyanzin opened a new pull request, #2840: URL: https://github.com/apache/calcite/pull/2840 This is a trivial PR updating apiguardian version to 1.1.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [calcite] jbalint merged pull request #2724: [CACLITE-5013] Retain parentheses if a setop has an LIMIT clause

jbalint merged PR #2724: URL: https://github.com/apache/calcite/pull/2724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.ap

[GitHub] [calcite] JiajunBernoulli commented on pull request #2724: [CACLITE-5013] Retain parentheses if a setop has an LIMIT clause

JiajunBernoulli commented on PR #2724: URL: https://github.com/apache/calcite/pull/2724#issuecomment-1164391891 > @JiajunBernoulli looks good. can you please fix the merge conflict? Ok. Thanks for your review, would you please merge it? -- This is an automated message from the Apach

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r904937604 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r904764600 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r904764600 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r904471969 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] libenchao commented on pull request #2834: [CALCITE-5192] CodeGenerationBenchmark throws IllegalStateException

libenchao commented on PR #2834: URL: https://github.com/apache/calcite/pull/2834#issuecomment-1163859960 > How do you find the bug if there is no test? I spotted it because I was running the benchmark manually to verify some performance issues, the bug do not leads to failoure/exception

[GitHub] [calcite] chunweilei commented on pull request #2834: [CALCITE-5192] CodeGenerationBenchmark throws IllegalStateException

chunweilei commented on PR #2834: URL: https://github.com/apache/calcite/pull/2834#issuecomment-1163845906 > @chunweilei Thanks for your review. > > > Should we add a test? > > I'm not sure about this, as existing benchmarks all do not have tests, I think maybe we do not need i

[GitHub] [calcite] jbalint commented on pull request #2724: [CACLITE-5013] Retain parentheses if a setop has an LIMIT clause

jbalint commented on PR #2724: URL: https://github.com/apache/calcite/pull/2724#issuecomment-1163826223 @JiajunBernoulli looks good. can you please fix the merge conflict? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [calcite] julianhyde commented on a diff in pull request #2606: [CALCITE-4865] Extends Table function to support Polymorphic Table Function (PTF)

julianhyde commented on code in PR #2606: URL: https://github.com/apache/calcite/pull/2606#discussion_r904270107 ## core/src/main/codegen/templates/Parser.jj: ## @@ -1558,6 +1562,101 @@ SqlNode NamedRoutineCall( } } +/** + * Table argument of a table function. + * The in

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903784005 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903701330 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903611021 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] libenchao commented on pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

libenchao commented on PR #2837: URL: https://github.com/apache/calcite/pull/2837#issuecomment-1162946717 LGTM, thanks for the fix and explanation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] hannerwang commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

hannerwang commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903584538 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { Sql

[GitHub] [calcite] libenchao commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

libenchao commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903562483 ## core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java: ## @@ -138,7 +138,9 @@ protected void perform(RelOptRuleCall call, @Nullable Filter filter,

[GitHub] [calcite] libenchao commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

libenchao commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903552711 ## core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java: ## @@ -138,7 +138,9 @@ protected void perform(RelOptRuleCall call, @Nullable Filter filter,

[GitHub] [calcite] danny0405 commented on a diff in pull request #2839: [hotfix] in RelSubset and the method unused remove

danny0405 commented on code in PR #2839: URL: https://github.com/apache/calcite/pull/2839#discussion_r903551757 ## core/src/main/java/org/apache/calcite/plan/volcano/RelSubset.java: ## @@ -302,22 +302,6 @@ Set getParents() { return list; } - /** - * Returns the coll

[GitHub] [calcite] chunweilei commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

chunweilei commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903541484 ## core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java: ## @@ -138,7 +138,9 @@ protected void perform(RelOptRuleCall call, @Nullable Filter filter,

[GitHub] [calcite] chunweilei commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

chunweilei commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903536875 ## core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java: ## @@ -138,7 +138,9 @@ protected void perform(RelOptRuleCall call, @Nullable Filter filter,

[GitHub] [calcite] chunweilei commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

chunweilei commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903535406 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -4537,6 +4537,51 @@ LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE

[GitHub] [calcite] libenchao commented on a diff in pull request #2837: [CALCITE-5195] ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

libenchao commented on code in PR #2837: URL: https://github.com/apache/calcite/pull/2837#discussion_r903516909 ## core/src/main/java/org/apache/calcite/rel/rules/FilterJoinRule.java: ## @@ -138,7 +138,9 @@ protected void perform(RelOptRuleCall call, @Nullable Filter filter,

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903495119 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] rubenada commented on a diff in pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on code in PR #2838: URL: https://github.com/apache/calcite/pull/2838#discussion_r903491912 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -6661,6 +6661,11 @@ static class ExtendedExpander extends Expander { SqlId

[GitHub] [calcite] xuzifu666 commented on pull request #2839: [hotfix] in RelSubset and the method unused remove

xuzifu666 commented on PR #2839: URL: https://github.com/apache/calcite/pull/2839#issuecomment-1162769945 @danny0405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [calcite] rubenada commented on pull request #2838: [CALCITE-5045] Alias within GroupingSets throws type mis-match exception

rubenada commented on PR #2838: URL: https://github.com/apache/calcite/pull/2838#issuecomment-1162762632 @hannerwang Thanks for the PR. It seems there are some `autostyleJavaCheck FAILED` issues -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] neilnaveen opened a new pull request, #2836: chore: Set permissions for GitHub actions

neilnaveen opened a new pull request, #2836: URL: https://github.com/apache/calcite/pull/2836 Restrict the GitHub token permissions only to the required ones; this way, even if the attackers will succeed in compromising your workflow, they won’t be able to do much. - Included permis

[GitHub] [calcite] JiajunBernoulli commented on pull request #2615: [CALCITE-4897] Implicit type conversion is not complete for set operation in DML

JiajunBernoulli commented on PR #2615: URL: https://github.com/apache/calcite/pull/2615#issuecomment-1161720140 @danny0405, @rubenada . Thanks for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [calcite-avatica] gabor-hargitai-privitar commented on pull request #148: [CALCITE-2322] Add fetch row count support

gabor-hargitai-privitar commented on PR #148: URL: https://github.com/apache/calcite-avatica/pull/148#issuecomment-1161681249 Hello, what is holding up this feature being merged? It would be very useful. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [calcite] rubenada merged pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

rubenada merged PR #2831: URL: https://github.com/apache/calcite/pull/2831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.a

[GitHub] [calcite] danny0405 commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

danny0405 commented on code in PR #2831: URL: https://github.com/apache/calcite/pull/2831#discussion_r902418910 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) { *

[GitHub] [calcite] rubenada merged pull request #2615: [CALCITE-4897] Implicit type conversion is not complete for set operation in DML

rubenada merged PR #2615: URL: https://github.com/apache/calcite/pull/2615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.a

[GitHub] [calcite] rubenada commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

rubenada commented on code in PR #2831: URL: https://github.com/apache/calcite/pull/2831#discussion_r902239437 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) { *

[GitHub] [calcite] julianhyde closed pull request #2808: [CALCITE-5157] Fix ClassCastException in checkRollUp with DOT operator

julianhyde closed pull request #2808: [CALCITE-5157] Fix ClassCastException in checkRollUp with DOT operator URL: https://github.com/apache/calcite/pull/2808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [calcite] chunweilei merged pull request #2832: Remove unreachable condition in CsvTableScan

chunweilei merged PR #2832: URL: https://github.com/apache/calcite/pull/2832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[GitHub] [calcite] chunweilei commented on pull request #2832: Remove unreachable condition in CsvTableScan

chunweilei commented on PR #2832: URL: https://github.com/apache/calcite/pull/2832#issuecomment-1161086115 Thank you for your PR, @henneberger! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] rubenada commented on pull request #2615: [CALCITE-4897] Implicit type conversion is not complete for set operation in DML

rubenada commented on PR #2615: URL: https://github.com/apache/calcite/pull/2615#issuecomment-1160120805 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [calcite] wenruimeng commented on pull request #2833: [CALCITE-5191] Allow sort by alias in BigQuery

wenruimeng commented on PR #2833: URL: https://github.com/apache/calcite/pull/2833#issuecomment-1159989275 @chunweilei Thanks for merging this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on pull request #2833: [CALCITE-5191] Allow sort by alias in BigQuery

chunweilei commented on PR #2833: URL: https://github.com/apache/calcite/pull/2833#issuecomment-1159944166 I have force-pushed the main branch to fix the commit message. Closed by https://github.com/apache/calcite/commit/fa65a2ec460abcd574e7f28672478a0510da65a1. -- This is an automated me

[GitHub] [calcite] libenchao commented on pull request #2834: [CALCITE-5192] CodeGenerationBenchmark throws IllegalStateException

libenchao commented on PR #2834: URL: https://github.com/apache/calcite/pull/2834#issuecomment-1159920191 @chunweilei Thanks for your review. > Should we add a test? I'm not sure about this, as existing benchmarks all do not have tests, I think maybe we do not need it? -- Th

[GitHub] [calcite] chunweilei commented on pull request #2833: [CALCITE-5191] Allow sort by alias in BigQuery

chunweilei commented on PR #2833: URL: https://github.com/apache/calcite/pull/2833#issuecomment-1159894472 Oops. I didn't notice that the commit message is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [calcite] chunweilei merged pull request #2833: [CALCITE-5191] Allow sort by alias in BigQuery

chunweilei merged PR #2833: URL: https://github.com/apache/calcite/pull/2833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[GitHub] [calcite] JiajunBernoulli commented on pull request #2615: [CALCITE-4897] Fix incomplete implicit type cast

JiajunBernoulli commented on PR #2615: URL: https://github.com/apache/calcite/pull/2615#issuecomment-1159632206 @rubenada, You left a [comment](https://github.com/apache/calcite/pull/2320#issuecomment-757456022) on CALCITE-4458(The solution is not correct and lacks unit tests). I belie

[GitHub] [calcite] JiajunBernoulli opened a new pull request, #2835: [CALCITE-4802] Babel parser doesn't parse IF(condition, then, else) s…

JiajunBernoulli opened a new pull request, #2835: URL: https://github.com/apache/calcite/pull/2835 …tatements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [calcite] rubenada merged pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

rubenada merged PR #2791: URL: https://github.com/apache/calcite/pull/2791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.a

[GitHub] [calcite] rubenada commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

rubenada commented on code in PR #2831: URL: https://github.com/apache/calcite/pull/2831#discussion_r899046635 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) { *

[GitHub] [calcite] libenchao commented on a diff in pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

libenchao commented on code in PR #2791: URL: https://github.com/apache/calcite/pull/2791#discussion_r898824890 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4883,7 +4883,14 @@ void setRoot(List inputs) { int i = 0; int off

[GitHub] [calcite] rubenada commented on a diff in pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

rubenada commented on code in PR #2791: URL: https://github.com/apache/calcite/pull/2791#discussion_r898822779 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4883,7 +4883,14 @@ void setRoot(List inputs) { int i = 0; int offs

[GitHub] [calcite] libenchao commented on a diff in pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

libenchao commented on code in PR #2791: URL: https://github.com/apache/calcite/pull/2791#discussion_r898604949 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4883,7 +4883,14 @@ void setRoot(List inputs) { int i = 0; int off

[GitHub] [calcite] rubenada commented on a diff in pull request #2791: [CALCITE-5134] Queries with subquery inside select list does not work if subquery uses table from left join

rubenada commented on code in PR #2791: URL: https://github.com/apache/calcite/pull/2791#discussion_r898113844 ## core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -4883,7 +4883,14 @@ void setRoot(List inputs) { int i = 0; int offs

[GitHub] [calcite] chunweilei closed pull request #2821: [CALCITE-5169] 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

chunweilei closed pull request #2821: [CALCITE-5169] 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1' URL: https://github.com/apache/calcite/pull/2821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [calcite] henneberger opened a new pull request, #2832: Remove unreachable condition in CsvTableScan

henneberger opened a new pull request, #2832: URL: https://github.com/apache/calcite/pull/2832 This removes an unreachable condition in CsvTableScan when checking if a table is a JsonTable. The table object can only take the form of a RelOptTable and not a Table. -- This is an automated

[GitHub] [calcite] rubenada commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

rubenada commented on code in PR #2831: URL: https://github.com/apache/calcite/pull/2831#discussion_r896461609 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) { *

[GitHub] [calcite] vvysotskyi merged pull request #2305: [CALCITE-4448] Use TableMacro user-defined table functions with QueryableTable

vvysotskyi merged PR #2305: URL: https://github.com/apache/calcite/pull/2305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite

[GitHub] [calcite] rubenada commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

rubenada commented on code in PR #2831: URL: https://github.com/apache/calcite/pull/2831#discussion_r895588397 ## core/src/main/java/org/apache/calcite/plan/RelOptUtil.java: ## @@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) { *

<    7   8   9   10   11   12   13   14   15   16   >