sauajmera commented on PR #2984:
URL: https://github.com/apache/calcite/pull/2984#issuecomment-1328948602
Wrong branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sauajmera closed pull request #2984: Rtp
203_to_char_with_trunc_results_in_datatype_mismatch
URL: https://github.com/apache/calcite/pull/2984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
libenchao commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1033044521
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1033016387
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1033016387
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
dssysolyatin commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1033016387
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
libenchao merged PR #2975:
URL: https://github.com/apache/calcite/pull/2975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
libenchao commented on code in PR #2977:
URL: https://github.com/apache/calcite/pull/2977#discussion_r1032795142
##
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableWindow.java:
##
@@ -693,7 +696,7 @@ private static Pair
getPartitionIterator(
}
JiajunBernoulli opened a new pull request, #2983:
URL: https://github.com/apache/calcite/pull/2983
…-join node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
JiajunBernoulli opened a new pull request, #2982:
URL: https://github.com/apache/calcite/pull/2982
…n node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
rubenada merged PR #2967:
URL: https://github.com/apache/calcite/pull/2967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zoudan opened a new pull request, #2981:
URL: https://github.com/apache/calcite/pull/2981
Add ARG_MIN, ARG_MAX (aka MIN_BY, MAX_BY) aggregate functions.
- **ARG_MAX(value, comp)** Returns *value* for the maximum value of *comp*
in the group
- **ARG_MIN(value, comp)**Returns
wnob commented on code in PR #2980:
URL: https://github.com/apache/calcite/pull/2980#discussion_r1029900371
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -206,6 +206,14 @@ private SqlLibraryOperators() {
olivrlee opened a new pull request, #2980:
URL: https://github.com/apache/calcite/pull/2980
Adding `STARTS_WITH()` for `BIG_QUERY`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asolimando merged PR #2976:
URL: https://github.com/apache/calcite/pull/2976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JiajunBernoulli commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1323695852
@asolimando Thank you again, I squashed to a single commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asolimando commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1323315072
@JiajunBernoulli it's good to me, if you can squash to a single commit I
will merge, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message,
julianhyde closed pull request #2961: [CALCITE-5336] Infer constants from
predicates with IS NOT DISTINCT FROM operator
URL: https://github.com/apache/calcite/pull/2961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
julianhyde commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322750893
The precision issue really is orthogonal, so at best it muddies the waters.
See https://issues.apache.org/jira/browse/CALCITE-5266.
--
This is an automated message from the Apache
julianhyde commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322748744
Let's move design discussions to the Jira case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
wnob commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322745325
I would also note that both BQ types have microsecond precision, so either
way the existing Calcite `TIMESTAMP` is not a perfect match.
--
This is an automated message from the Apache Git
wnob commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322739188
Of course, we could simply re-interpret those bits as `DATETIME`, as I
mentioned. We don't need a new internal representation; we could just make a
new type that happens to have the same
julianhyde commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322709533
No, BigQuery, a timestamp is represented internally as an offset in
microseconds since epoch *UTC*.
The "UTC" is a crucial difference.
Sure, they're both a bunch of bits.
wnob commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1322705468
> BQ `DATETIME` = Calcite `TIMESTAMP`
I don't see the connection. In Calcite, a timestamp is represented
internally as an offset in milliseconds since epoch. In BigQuery, a timestamp
tanclary commented on code in PR #2978:
URL: https://github.com/apache/calcite/pull/2978#discussion_r1028364707
##
gradle.properties:
##
@@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should not
tjbanghart commented on code in PR #2978:
URL: https://github.com/apache/calcite/pull/2978#discussion_r1028359636
##
gradle.properties:
##
@@ -27,7 +27,7 @@ systemProp.org.gradle.internal.publish.checksums.insecure=true
# This is version for Calcite itself
# Note: it should
tanclary opened a new pull request, #2978:
URL: https://github.com/apache/calcite/pull/2978
Add BigQuery as a supported library for functions that have already been
implemented for other libraries. This ticket overrides Calcite-5384 to include
other functions that need BQ added as a
asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1028128040
##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
return
asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1028126808
##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,18 @@ protected RelMdExpressionLineage() {}
return
JiajunBernoulli commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1322142351
Sorry, I'll pay attention later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
asolimando commented on PR #2976:
URL: https://github.com/apache/calcite/pull/2976#issuecomment-1322134305
@JiajunBernoulli, until the review process is over please don't force-push,
it destroys the "link" to the old comments and it makes incremental reviewing
impossible (checking just the
asolimando commented on code in PR #2976:
URL: https://github.com/apache/calcite/pull/2976#discussion_r1027756107
##
core/src/main/java/org/apache/calcite/rel/metadata/RelMdExpressionLineage.java:
##
@@ -391,6 +392,14 @@ protected RelMdExpressionLineage() {}
return
julianhyde commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1320951570
BQ `DATETIME` = Calcite `TIMESTAMP`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
libenchao commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r1027061254
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -232,6 +234,84 @@ default JoinToSemiJoinRuleConfig
withOperandFor(Class joinClass,
wnob commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1320707981
@tjbanghart
> Wouldn't `DATETIME` map to Calcite's interpretation of a `TIMESTAMP` due
to the lack of TZ info?
Neither has tz info. I included a little table in the design doc
wnob commented on code in PR #2973:
URL: https://github.com/apache/calcite/pull/2973#discussion_r1026992374
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -149,6 +159,40 @@ public class SqlFunctions {
private static final Pattern PATTERN_0_STAR_E
sdreynolds opened a new pull request, #2975:
URL: https://github.com/apache/calcite/pull/2975
## Why:
When rewriting the query for a semi join, the
`JoinOnUniqueToSemiJoinRule` pushes a new project via `RelBuilder`. This
project is *almost* a good copy of the original `Project` -- it
sdreynolds commented on code in PR #2848:
URL: https://github.com/apache/calcite/pull/2848#discussion_r1026959819
##
core/src/main/java/org/apache/calcite/rel/rules/SemiJoinRule.java:
##
@@ -232,6 +234,84 @@ default JoinToSemiJoinRuleConfig
withOperandFor(Class joinClass,
julianhyde commented on code in PR #2973:
URL: https://github.com/apache/calcite/pull/2973#discussion_r1026775499
##
site/_docs/reference.md:
##
@@ -2596,7 +2596,16 @@ semantics.
| p | CONVERT_TIMEZONE(tz1, tz2, datetime) | Converts the timezone
of *datetime* from
tjbanghart commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1319499323
Wouldn't `DATETIME` map to Calcite's interpretation of a `TIMESTAMP` due to
the lack of TZ info?
Also, should we move this into the core parser? I don't feel strongly either
jbalint merged PR #2874:
URL: https://github.com/apache/calcite/pull/2874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
wnob commented on PR #2973:
URL: https://github.com/apache/calcite/pull/2973#issuecomment-1319428833
I've now implemented all the overloads that do not involve `DATETIME`
objects. I'm not sure what is the best way to proceed with these because there
doesn't seem to be a good fit in
wnob commented on code in PR #2973:
URL: https://github.com/apache/calcite/pull/2973#discussion_r1025778875
##
babel/src/main/codegen/includes/parserImpls.ftl:
##
@@ -42,6 +42,26 @@ SqlNode DateFunctionCall() :
}
}
+SqlNode TimestampFunctionCall() :
Review Comment:
snuyanzin merged PR #196:
URL: https://github.com/apache/calcite-avatica/pull/196
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
olivrlee commented on code in PR #2973:
URL: https://github.com/apache/calcite/pull/2973#discussion_r1024660113
##
babel/src/main/codegen/includes/parserImpls.ftl:
##
@@ -42,6 +42,26 @@ SqlNode DateFunctionCall() :
}
}
+SqlNode TimestampFunctionCall() :
Review Comment:
olivrlee commented on code in PR #2973:
URL: https://github.com/apache/calcite/pull/2973#discussion_r1024660113
##
babel/src/main/codegen/includes/parserImpls.ftl:
##
@@ -42,6 +42,26 @@ SqlNode DateFunctionCall() :
}
}
+SqlNode TimestampFunctionCall() :
Review Comment:
wnob opened a new pull request, #2973:
URL: https://github.com/apache/calcite/pull/2973
There is an existing implementation for a BQ `DATE` function but it wrongly
thinks this is simply a typecast. See documentation [here][1].
This PR implements 2 of the 4 possible overloads for
k-jamroz commented on PR #2878:
URL: https://github.com/apache/calcite/pull/2878#issuecomment-1317373320
Interesting changes in 1.32.0:
* https://issues.apache.org/jira/browse/CALCITE-5241 - `CHAR` is now a
reserved function name. I am not sure if this may impact parsing. Maybe we want
julianhyde closed pull request #2965: [CALCITE-5105] Add MEASURE type and
AGGREGATE aggregate function
URL: https://github.com/apache/calcite/pull/2965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
freastro opened a new pull request, #2972:
URL: https://github.com/apache/calcite/pull/2972
This changes the unix timestamp to Date/Time/Timestamp conversion in
`SqlFunctions` to convert between the ISO calendar system and the standard
Gregorian calendar. This ensures that unix timestamps
freastro opened a new pull request, #197:
URL: https://github.com/apache/calcite-avatica/pull/197
This changes the unix timestamp to Date/Time/Timestamp conversion in
`AbstractCursor` to convert between the ISO calendar system and the standard
Gregorian calendar. This ensures that unix
libenchao closed pull request #2929: [CALCITE-5310] JSON_OBJECT in scalar
sub-query throws AssertionError
URL: https://github.com/apache/calcite/pull/2929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
libenchao commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1022368836
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
Pritam-Gote opened a new pull request, #2971:
URL: https://github.com/apache/calcite/pull/2971
RTP 180 support for mod function on date field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dssysolyatin commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1022331269
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
libenchao closed pull request #2970: [CALCITE-5383] Update CONCAT_FUNCTION
SqlLibary to include BIG_QUERY
URL: https://github.com/apache/calcite/pull/2970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
libenchao commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1022252807
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
dssysolyatin commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1021396407
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
vijayjogi-dm opened a new pull request, #2969:
URL: https://github.com/apache/calcite/pull/2969
Carry over changes from
https://github.com/apache/calcite/commit/ba80b9156afc0db26b194d97a031fcc0dc7f4c03#
commit to fix CVE-2022-39135 Vulnerability issue
--
This is an automated message
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020909779
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg,
is(false));
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020908879
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg,
is(false));
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020908635
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg,
is(false));
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020908635
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -3027,6 +3028,43 @@ private void checkSarg(String message, Sarg sarg,
is(false));
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020908293
##
core/src/main/java/org/apache/calcite/rex/RexInterpreter.java:
##
@@ -342,22 +346,15 @@ private static Comparable ceil(RexCall call,
List values) {
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020901059
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020905457
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020904821
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020902630
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020902356
##
core/src/test/java/org/apache/calcite/test/MaterializedViewRelOptRulesTest.java:
##
@@ -338,6 +341,104 @@ protected final MaterializedViewFixture sql(String
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020901685
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020901359
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020901059
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020901059
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020900761
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020900532
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020892400
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020892294
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020891962
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java:
##
@@ -1252,6 +1285,193 @@ protected RexNode
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020889953
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020889694
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020888640
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020888568
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020888380
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020888215
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -910,6 +942,53 @@ protected SqlFunction
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020887754
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -292,10 +298,36 @@
asolimando commented on code in PR #2876:
URL: https://github.com/apache/calcite/pull/2876#discussion_r1020887570
##
core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewAggregateRule.java:
##
@@ -292,10 +298,36 @@
libenchao commented on PR #2868:
URL: https://github.com/apache/calcite/pull/2868#issuecomment-1312638552
> As for PERCENTILE_CONT, based on conversation with Julian in the Jira
ticket, there is nothing to be done.
I'm not sure about this conclusion, I've checked the SQL standard
libenchao commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1020832236
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
julianhyde commented on code in PR #2965:
URL: https://github.com/apache/calcite/pull/2965#discussion_r1020820936
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##
@@ -1287,6 +1287,20 @@ private static FlatAggregate flattenRecurse(@Nullable
julianhyde commented on code in PR #2965:
URL: https://github.com/apache/calcite/pull/2965#discussion_r1020820690
##
core/src/main/java/org/apache/calcite/sql/type/ApplySqlType.java:
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
julianhyde commented on code in PR #2965:
URL: https://github.com/apache/calcite/pull/2965#discussion_r1020820454
##
site/_docs/reference.md:
##
@@ -49,6 +49,13 @@ here to appease testAllFunctionsAreDocumented:
| SUCCEEDS | Documented as a period operator
| TABLE
snuyanzin opened a new pull request, #196:
URL: https://github.com/apache/calcite-avatica/pull/196
The PR upgrades protobuf version to avoid CVE-2022-3171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
snuyanzin merged PR #194:
URL: https://github.com/apache/calcite-avatica/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin opened a new pull request, #2966:
URL: https://github.com/apache/calcite/pull/2966
The PR upgrading jackson to 2.14.0
in 2.14.0 `com.fasterxml.jackson.databind.node.ObjectNode#with` became
deprecated after https://github.com/FasterXML/jackson-databind/issues/3568
Since
snuyanzin commented on PR #195:
URL: https://github.com/apache/calcite-avatica/pull/195#issuecomment-1312563753
It seems the reason is that in 2.14.0
`com.fasterxml.jackson.databind.node.ObjectNode#with` became deprecated
https://github.com/FasterXML/jackson-databind/issues/3568
So
F21 merged PR #62:
URL: https://github.com/apache/calcite-avatica-go/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
F21 merged PR #188:
URL: https://github.com/apache/calcite-avatica/pull/188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
F21 merged PR #2959:
URL: https://github.com/apache/calcite/pull/2959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dssysolyatin commented on code in PR #2929:
URL: https://github.com/apache/calcite/pull/2929#discussion_r1020099005
##
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##
@@ -1790,10 +1790,11 @@ private RexNode createCaseExpression(
@Override public
rubenada commented on PR #2965:
URL: https://github.com/apache/calcite/pull/2965#issuecomment-1311503006
@julianhyde Thanks for this contribution. Looks good. I have taken a look,
and left some minor comments (I'm not very familiar with SQL parser and
validator parts though, so I'm
401 - 500 of 18124 matches
Mail list logo
