sonarcloud[bot] commented on PR #3962:
URL: https://github.com/apache/calcite/pull/3962#issuecomment-2344740762
## [](https://sonarclo
normanj-bitquill opened a new pull request, #3962:
URL: https://github.com/apache/calcite/pull/3962
…unction
* Added a test for first argument NULL without a cast
* Added a test for both arguments NULL without a cast
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2344679315
## [](https://sonarclo
sonarcloud[bot] commented on PR #3961:
URL: https://github.com/apache/calcite/pull/3961#issuecomment-2344309372
## [](https://sonarclo
sonarcloud[bot] commented on PR #3961:
URL: https://github.com/apache/calcite/pull/3961#issuecomment-2344152700
## [](https://sonarclo
sonarcloud[bot] commented on PR #3961:
URL: https://github.com/apache/calcite/pull/3961#issuecomment-2344124261
## [](https://sonarclo
jamesstarr opened a new pull request, #3961:
URL: https://github.com/apache/calcite/pull/3961
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jamesstarr commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2344018677
@mihaibudiu This is ready for review.
@julianhyde Please let me know if you have an objections or would like any
changes.
--
This is an automated message from the Apache Git S
sonarcloud[bot] commented on PR #3960:
URL: https://github.com/apache/calcite/pull/3960#issuecomment-2343057314
## [](https://sonarclo
caicancai commented on PR #3960:
URL: https://github.com/apache/calcite/pull/3960#issuecomment-2342953494
I have tested it locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
caicancai opened a new pull request, #3960:
URL: https://github.com/apache/calcite/pull/3960
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
sonarcloud[bot] commented on PR #3959:
URL: https://github.com/apache/calcite/pull/3959#issuecomment-2342921796
## [](https://sonarclo
caicancai closed pull request #3879: [CALCITE-6493] Improve Calcite development
documentation
URL: https://github.com/apache/calcite/pull/3879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
nielspardon commented on code in PR #3959:
URL: https://github.com/apache/calcite/pull/3959#discussion_r1753384681
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -5102,6 +5102,12 @@ void checkPeriodPredicate(Checker checker) {
+ "WH
caicancai commented on code in PR #3959:
URL: https://github.com/apache/calcite/pull/3959#discussion_r1753369805
##
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##
@@ -5102,6 +5102,12 @@ void checkPeriodPredicate(Checker checker) {
+ "WHER
sonarcloud[bot] commented on PR #3959:
URL: https://github.com/apache/calcite/pull/3959#issuecomment-2342792716
## [](https://sonarclo
nielspardon opened a new pull request, #3959:
URL: https://github.com/apache/calcite/pull/3959
Changing the column identifier from `SimpleIdentifier` to
`CompoundIdentifier` allows using the table alias with the column identifiers
in the SET section of an UPDATE statement.
--
This is an
sonarcloud[bot] commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2342595329
## [](https://sonarclo
sonarcloud[bot] commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2342557855
## [](https://sonarclo
sonarcloud[bot] commented on PR #3955:
URL: https://github.com/apache/calcite/pull/3955#issuecomment-2342514527
## [](https://sonarclo
caicancai commented on code in PR #3956:
URL: https://github.com/apache/calcite/pull/3956#discussion_r1753019951
##
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##
@@ -1815,7 +1815,7 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTab
caicancai commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1753017096
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functio
NobiGo commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1753006111
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAl
sonarcloud[bot] commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2342367863
## [](https://sonarclo
sonarcloud[bot] commented on PR #3958:
URL: https://github.com/apache/calcite/pull/3958#issuecomment-2342365760
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sonarcloud[bot] commented on PR #3954:
URL: https://github.com/apache/calcite/pull/3954#issuecomment-2342319643
## [](https://sonarclo
sonarcloud[bot] commented on PR #3954:
URL: https://github.com/apache/calcite/pull/3954#issuecomment-2342308231
## [](https://sonarclo
sonarcloud[bot] commented on PR #3954:
URL: https://github.com/apache/calcite/pull/3954#issuecomment-2342304441
## [](https://sonarclo
normanj-bitquill commented on code in PR #3954:
URL: https://github.com/apache/calcite/pull/3954#discussion_r1752894440
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -528,24 +531,94 @@ public class RexImpTable {
public static final Member
mihaibudiu merged PR #3942:
URL: https://github.com/apache/calcite/pull/3942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
sonarcloud[bot] commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2342014308
## [](https://sonarclo
mihaibudiu closed pull request #1795: [CALCITE-3779] Implement bitand scalar
function
URL: https://github.com/apache/calcite/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
mihaibudiu commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1752684371
##
core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties:
##
@@ -207,6 +207,7 @@ ArgumentMustBeNumericLiteralInRange=Argument to function
''
sonarcloud[bot] commented on PR #3938:
URL: https://github.com/apache/calcite/pull/3938#issuecomment-2341798408
## [](https://sonarclo
suibianwanwank commented on code in PR #3949:
URL: https://github.com/apache/calcite/pull/3949#discussion_r1752259433
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -2006,6 +2010,31 @@ private boolean hasSortByOrdinal(@UnknownInitialization
Resu
caicancai commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1752189717
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functio
caicancai commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1752189717
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functio
davidradl commented on code in PR #3901:
URL: https://github.com/apache/calcite/pull/3901#discussion_r1751978441
##
linq4j/src/main/java/org/apache/calcite/linq4j/tree/MethodDeclaration.java:
##
@@ -59,20 +61,38 @@ public MethodDeclaration(int modifier, String name, Type
result
sonarcloud[bot] commented on PR #3957:
URL: https://github.com/apache/calcite/pull/3957#issuecomment-2340688707
## [](https://sonarclo
sonarcloud[bot] commented on PR #3955:
URL: https://github.com/apache/calcite/pull/3955#issuecomment-2340312434
## [](https://sonarclo
caicancai commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1751650196
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functio
NobiGo commented on code in PR #3955:
URL: https://github.com/apache/calcite/pull/3955#discussion_r1751306340
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -7372,6 +7372,26 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAl
sonarcloud[bot] commented on PR #3955:
URL: https://github.com/apache/calcite/pull/3955#issuecomment-2339541509
## [](https://sonarclo
caicancai opened a new pull request, #3955:
URL: https://github.com/apache/calcite/pull/3955
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
julianhyde commented on code in PR #3954:
URL: https://github.com/apache/calcite/pull/3954#discussion_r1751120720
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##
@@ -528,24 +531,94 @@ public class RexImpTable {
public static final MemberExpres
mihaibudiu commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2338801896
Can you please fix the conflicts and squash the commits in preparation for
merging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mihaibudiu commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2338797847
Sorry, but it looks like other merges have introduced conflicts, please fix
them so we can merge this one too
--
This is an automated message from the Apache Git Service.
To respond
mihaibudiu commented on PR #3938:
URL: https://github.com/apache/calcite/pull/3938#issuecomment-2338796634
@ian-bertolacci, can you please address the comments from @NobiGo?
Then we can probably merge this
--
This is an automated message from the Apache Git Service.
To respond to the me
mihaibudiu commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2338781327
From my pov we can squash the commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mihaibudiu commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1750717382
##
core/src/main/resources/org/apache/calcite/runtime/CalciteResource.properties:
##
@@ -207,6 +207,7 @@ ArgumentMustBeNumericLiteralInRange=Argument to function
''
mihaibudiu merged PR #3292:
URL: https://github.com/apache/calcite/pull/3292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1750610190
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public stat
sonarcloud[bot] commented on PR #3945:
URL: https://github.com/apache/calcite/pull/3945#issuecomment-2336515447
## [](https://sonarclo
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1747781019
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public stat
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2334750958
## [](https://sonarclo
julianhyde commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2334664152
@mihaibudiu Thanks for all your edits. Much improved.
+1 after you fix the cosmetic issues in reference.md.
--
This is an automated message from the Apache Git Service.
To resp
NobiGo merged PR #3944:
URL: https://github.com/apache/calcite/pull/3944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
ChengJie1053 commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2333006982
> Please remove the log function before merging.
Ok, thanks for reviewing the code for me, I will change the code
--
This is an automated message from the Apache Git Service.
caicancai commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2333002156
Please remove the log function before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarcloud[bot] commented on PR #3953:
URL: https://github.com/apache/calcite/pull/3953#issuecomment-2332847166
## [](https://sonarclo
julianhyde merged PR #3951:
URL: https://github.com/apache/calcite/pull/3951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite
sonarcloud[bot] commented on PR #3951:
URL: https://github.com/apache/calcite/pull/3951#issuecomment-2332503674
## [](https://sonarclo
julianhyde opened a new pull request, #3951:
URL: https://github.com/apache/calcite/pull/3951
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
mihaibudiu commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1745918891
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public static fin
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1745882348
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public stat
amarkowitz commented on code in PR #3950:
URL: https://github.com/apache/calcite/pull/3950#discussion_r1745864724
##
core/src/test/resources/sql/measure.iq:
##
@@ -179,6 +179,53 @@ from empm;
!ok
+# [CALCITE-6559] LogicalCorrelate Type mismatch
+# Occurs when AVG measure is
julianhyde commented on PR #3950:
URL: https://github.com/apache/calcite/pull/3950#issuecomment-2332176815
@amarkowitz, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
sonarcloud[bot] commented on PR #3945:
URL: https://github.com/apache/calcite/pull/3945#issuecomment-2331946644
## [](https://sonarclo
NobiGo commented on code in PR #3945:
URL: https://github.com/apache/calcite/pull/3945#discussion_r1745651932
##
core/src/main/java/org/apache/calcite/rel/type/DelegatingTypeSystem.java:
##
@@ -52,6 +52,14 @@ protected DelegatingTypeSystem(RelDataTypeSystem typeSystem)
{
r
mihaibudiu commented on code in PR #3950:
URL: https://github.com/apache/calcite/pull/3950#discussion_r1744827988
##
core/src/test/resources/sql/measure.iq:
##
@@ -179,6 +179,53 @@ from empm;
!ok
+# [CALCITE-6559] LogicalCorrelate Type mismatch
+# Occurs when AVG measure is
julianhyde opened a new pull request, #3950:
URL: https://github.com/apache/calcite/pull/3950
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
suibianwanwank commented on code in PR #3949:
URL: https://github.com/apache/calcite/pull/3949#discussion_r1744762621
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1910,11 +1910,15 @@ private boolean needNewSubQuery(
return true;
NobiGo closed pull request #2616: [CALCITE-4871] CAST a literal to DECIMAL type
return wrong result
URL: https://github.com/apache/calcite/pull/2616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
NobiGo merged PR #3943:
URL: https://github.com/apache/calcite/pull/3943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apa
ChengJie1053 commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2330421969
> Ok, thanks for reviewing the code for me
Ok, thanks for reviewing the code for me, I will change the code
--
This is an automated message from the Apache Git Service.
T
ChengJie1053 commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2330409466
> @ChengJie1053 Thanks for your contribution, can you confirm that these
functions give the same results in some boundary tests?
>
> In my experience, this is difficult to guar
julianhyde commented on code in PR #3947:
URL: https://github.com/apache/calcite/pull/3947#discussion_r1744660968
##
core/src/main/java/org/apache/calcite/util/Variant.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
julianhyde commented on code in PR #3947:
URL: https://github.com/apache/calcite/pull/3947#discussion_r1744667636
##
core/src/main/java/org/apache/calcite/util/rtti/RuntimeTypeInformation.java:
##
@@ -0,0 +1,228 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1744280709
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -613,6 +613,59 @@ public static SqlCall stripSeparator(SqlCall call) {
public stat
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329764096
## [](https://sonarclo
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329656162
## [](https://sonarclo
julianhyde commented on PR #3946:
URL: https://github.com/apache/calcite/pull/3946#issuecomment-2329643745
This PR feels too small. In calcite, a commit that is merged to main is
generally at the grain of a jira case, and a jira case is a bug or a feature.
Commits merged to main are rarely
mihaibudiu commented on code in PR #3949:
URL: https://github.com/apache/calcite/pull/3949#discussion_r1744185603
##
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java:
##
@@ -1910,11 +1910,15 @@ private boolean needNewSubQuery(
return true;
}
julianhyde commented on code in PR #3946:
URL: https://github.com/apache/calcite/pull/3946#discussion_r1744180721
##
core/src/test/resources/sql/measure.iq:
##
@@ -26,6 +26,136 @@ from emp;
!update
+create view empm_comm as
+select *, avg(sal) as measure avg_sal, avg(comm)
julianhyde commented on code in PR #3946:
URL: https://github.com/apache/calcite/pull/3946#discussion_r1744179376
##
core/src/test/resources/sql/measure.iq:
##
@@ -26,6 +26,136 @@ from emp;
!update
+create view empm_comm as
Review Comment:
I wouldn't create a view for j
sonarcloud[bot] commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329610011
## [](https://sonarclo
julianhyde commented on PR #3947:
URL: https://github.com/apache/calcite/pull/3947#issuecomment-2329500646
Can you move (or at least copy) that description to the Jira case? Jira
cases are our feature specifications. Minimal features thatI would like to see
specified:
* How VARIANT inte
sonarcloud[bot] commented on PR #3945:
URL: https://github.com/apache/calcite/pull/3945#issuecomment-2329229610
## [](https://sonarclo
sonarcloud[bot] commented on PR #3948:
URL: https://github.com/apache/calcite/pull/3948#issuecomment-2328822096
## [](https://sonarclo
ChengJie1053 opened a new pull request, #3948:
URL: https://github.com/apache/calcite/pull/3948
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
caicancai commented on PR #3944:
URL: https://github.com/apache/calcite/pull/3944#issuecomment-2328457910
> This should be an issue in JIRA. Do you have a JIRA account? You can ask
for one, it's free. https://issues.apache.org
>
> I was thinking to file your text as an issue, but I co
sonarcloud[bot] commented on PR #3945:
URL: https://github.com/apache/calcite/pull/3945#issuecomment-2327847719
## [](https://sonarclo
sonarcloud[bot] commented on PR #3946:
URL: https://github.com/apache/calcite/pull/3946#issuecomment-2327658172
## [](https://sonarclo
sonarcloud[bot] commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2327624158
## [](https://sonarclo
sonarcloud[bot] commented on PR #3943:
URL: https://github.com/apache/calcite/pull/3943#issuecomment-2327610051
## [](https://sonarclo
mihaibudiu commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2327596880
I think this pattern is common in all arithmetic operations for integer
types. Hopefully you could have reused some code.
Your runtime only supported int and long, so I suspected the
normanj-bitquill commented on PR #3942:
URL: https://github.com/apache/calcite/pull/3942#issuecomment-2327594970
> I don't really understand why the result for TINYINT will be correct,
since today Calcite incorrectly does not truncate the results for short
arithmetic.
@mihaibudiu I h
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1742792245
##
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##
@@ -2829,6 +2829,20 @@ public static long bitAnd(long b0, long b1) {
return b0 & b1
normanj-bitquill commented on code in PR #3942:
URL: https://github.com/apache/calcite/pull/3942#discussion_r1742791360
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -15470,6 +15470,111 @@ private static void
checkLogicalOrFunc(SqlOperatorFixture
bchapuis closed pull request #3157: Enable support for cursors
URL: https://github.com/apache/calcite/pull/3157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
1 - 100 of 1001 matches
Mail list logo
