[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-24 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1004026696 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3749,26 +3774,26 @@ void checkPeriodPredicate(Checker checker) { + "select * fr

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-24 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003027206 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-23 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1002851565 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-17 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996677165 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-17 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996676210 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996675145 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) { sql(sql).fails("(?s)

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996599562 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996593733 ## core/src/main/java/org/apache/calcite/sql/SqlWith.java: ## @@ -103,8 +103,9 @@ private SqlWithOperator() { } writer.endList(frame1); final SqlWrite

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996593539 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) { sql(sql).fails("(?s)

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996592477 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

2022-10-16 Thread GitBox
l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {