[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073952163 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return

[GitHub] [calcite] tanclary commented on a diff in pull request #3034: [CALCITE-5357] Implement BigQuery FORMAT_TIMESTAMP, FORMAT_DATE, FORMAT_TIME, and FORMAT_DATETIME

2023-01-18 Thread GitBox
tanclary commented on code in PR #3034: URL: https://github.com/apache/calcite/pull/3034#discussion_r1073936097 ## core/src/main/java/org/apache/calcite/sql/dialect/MysqlSqlDialect.java: ## @@ -184,6 +185,46 @@ public MysqlSqlDialect(Context context) { return