[GitHub] [calcite] thomasrebele commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

thomasrebele commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240661122 Seems that we have different definitions of simple code ;) I have the impression that an `IdentityHashMap` and an `ArrayList` is a bit easier to understand than a `LinkedHashMap` wit

[GitHub] [calcite] thomasrebele commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

thomasrebele commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240487900 Thanks for the PR! What's the advantage of using a `LinkedHashMap` and `Equivalence.Identity` compared to a simple `ArrayList` containing the `ParameterExpression`s in the order they