[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-24 Thread GitBox
zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1003201432 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) + +

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-19 Thread GitBox
zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r999314056 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) + +

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-19 Thread GitBox
zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r999312483 ## testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java: ## @@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory type

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

2022-10-11 Thread GitBox
zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r992121760 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -540,4 +540,32 @@ public interface JoinRightEmptyRuleConfig extends PruneEmptyRule.Config