mihaibudiu merged PR #3597:
URL: https://github.com/apache/calcite/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HanumathRao commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1894877595
> I have no further comments. Please squash the commits so we can merge this
PR. Thank you for the improvements!
Done. Thanks for review.
--
This is an automated message
mihaibudiu commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1894661539
I have no further comments. Please squash the commits so we can merge this
PR. Thank you for the improvements!
--
This is an automated message from the Apache Git Service.
To
HanumathRao commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1893066965
> I have approved, but I still made a few small suggestions. It looks like
the CI is unhappy.
Thanks. I am not sure why only PR runs are showing this issue. The tests
executed
sonarcloud[bot] commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1893065574
## [
HanumathRao commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1891083336
> The code looks pretty good, my comments are about readability mostly. I am
not familiar with this part of the codebase; perhaps a more experienced
reviewer would understand faster.
HanumathRao commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1891082558
Not sure why the tests are showing failed in the PR but all of them are
successful on the branch commit.
https://github.com/HanumathRao/calcite/commits/CALCITE-6162/, build run
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1451805261
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValuesOptimizationRules.java:
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation
sonarcloud[bot] commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1891068012
## [ {
switch (format) {
case
mihaibudiu commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1447886735
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValuesOptimizationRules.java:
##
@@ -0,0 +1,374 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1885306396
@mihaibudiu Thanks for the suggestion. I have added the javadoc comments
wherever I think are needed for clarity. Regarding the comments for the rules,
I have already added comments
mihaibudiu commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1446463682
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1446459398
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mihaibudiu commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445394313
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,329 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445132866
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445133506
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445131777
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445130564
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -4177,6 +4178,109 @@ RelOptFixture checkDynamicFunctions(boolean
macroguo-ghy commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1441266692
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation
JiajunBernoulli commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1438824373
##
core/src/main/java/org/apache/calcite/rel/rules/SingleValueOptimizationRules.java:
##
@@ -0,0 +1,361 @@
+/*
+ * Licensed to the Apache Software Foundation
mihaibudiu commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1438438843
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -4177,6 +4178,109 @@ RelOptFixture checkDynamicFunctions(boolean
HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1438278222
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -4177,6 +4178,109 @@ RelOptFixture checkDynamicFunctions(boolean
sonarcloud[bot] commented on PR #3597:
URL: https://github.com/apache/calcite/pull/3597#issuecomment-1872114647
## [