Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-22 Thread via GitHub
chucheng92 merged PR #3586: URL: https://github.com/apache/calcite/pull/3586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-22 Thread via GitHub
chucheng92 commented on PR #3586: URL: https://github.com/apache/calcite/pull/3586#issuecomment-1867518570 @caicancai thanks for your PR, merging ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-22 Thread via GitHub
caicancai commented on PR #3586: URL: https://github.com/apache/calcite/pull/3586#issuecomment-1867426388 Thank you for your patient review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-22 Thread via GitHub
sonarcloud[bot] commented on PR #3586: URL: https://github.com/apache/calcite/pull/3586#issuecomment-1867374512 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-21 Thread via GitHub
caicancai commented on code in PR #3586: URL: https://github.com/apache/calcite/pull/3586#discussion_r1434803576 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -11948,6 +11984,25 @@ void testTimestampDiff(boolean coercionEnabled) {

Re: [PR] [CALCITE-6165] Add DATE_ADD test and DATE_DIFF test on SqlOperatorTest [calcite]

2023-12-21 Thread via GitHub
caicancai commented on code in PR #3586: URL: https://github.com/apache/calcite/pull/3586#discussion_r1434801168 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -11859,6 +11859,42 @@ void testTimestampDiff(boolean coercionEnabled) {