snuyanzin closed pull request #3590: [CALCITE-6172] PoC for parameterized tests
URL: https://github.com/apache/calcite/pull/3590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
snuyanzin commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1905433095
closing since the PR was merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tanclary commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1888065444
> This has developed a conflict, can you please fix it and I will merge.
This is just a PoC it can be closed, I merged the actual impl
--
This is an automated message from the
mihaibudiu commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1888021698
This has developed a conflict, can you please fix it and I will merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
julianhyde commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1871348454
Is this PR just a proof of concept? If so, let’s not merge the PoC, let’s
merge a commit that does the actual task - reduces duplication of testing for
aliased functions. By all means
tanclary commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1870656854
> It's still marked as draft for some reason.
I converted to ready for review, hope that's alright.
--
This is an automated message from the Apache Git Service.
To respond to
mihaibudiu commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1870655040
It's still marked as draft for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
sonarcloud[bot] commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1868028271
## [ {
snuyanzin commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1435295636
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
snuyanzin commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1435295317
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
tanclary commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1435264996
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
mihaibudiu commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434660313
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
snuyanzin commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434637134
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,44 @@ private void testCurrentDateFunc(Pair pair) {
sonarcloud[bot] commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867101890
## [ {
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434597746
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -13686,6 +13673,31 @@ void testCastTruncates(CastType castType,
SqlOperatorFixture f)
julianhyde commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867061770
@mihaibudiu The danger with your approach is that, by working on the AST,
you automatically fix errors. E.g. you might accidentally change STARTSWITH to
STARTS_WITH and not notice
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434594909
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8897,56 +8898,42 @@ private void testCurrentDateFunc(Pair pair) {
julianhyde commented on code in PR #3590:
URL: https://github.com/apache/calcite/pull/3590#discussion_r1434594471
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -13686,6 +13673,31 @@ void testCastTruncates(CastType castType,
SqlOperatorFixture f)
mihaibudiu commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867056620
You leave the queries unchanged, and then you use a shuttle to replace the
use of `starts_with` with `startswith`.
--
This is an automated message from the Apache Git Service.
To
snuyanzin commented on PR #3590:
URL: https://github.com/apache/calcite/pull/3590#issuecomment-1867055416
I didn't get how shuttle could help with different `SQLLibraries` per
alias...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
22 matches
Mail list logo
