sonarcloud[bot] commented on PR #3292:
URL: https://github.com/apache/calcite/pull/3292#issuecomment-1624827518
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3296:
URL: https://github.com/apache/calcite/pull/3296#issuecomment-1625372397
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
chucheng92 commented on PR #3297:
URL: https://github.com/apache/calcite/pull/3297#issuecomment-1625380390
@zabetak hi, Stamatis. ci passed. can u help to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
JiajunBernoulli commented on code in PR #3296:
URL: https://github.com/apache/calcite/pull/3296#discussion_r1255708038
##
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##
@@ -2458,6 +2458,63 @@ private SqlOperator getNoDeterministicOperator() {
chucheng92 opened a new pull request, #3298:
URL: https://github.com/apache/calcite/pull/3298
# What is the purpose of the change
Returns the string or binary data bit numbers.
> SELECT bit_length('Apache Calcite');
72
> SELECT bit_length(x'537061726b2053514c');
72
sonarcloud[bot] commented on PR #3298:
URL: https://github.com/apache/calcite/pull/3298#issuecomment-1625511363
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
This is an automated email from the ASF dual-hosted git repository.
zabetak pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new e3105a8fe0 [CALCITE-5819] Upgrade
zabetak closed pull request #3297: [CALCITE-5819] Bump commons-collections 3.x
to commons-collections4
URL: https://github.com/apache/calcite/pull/3297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
sonarcloud[bot] commented on PR #3234:
URL: https://github.com/apache/calcite/pull/3234#issuecomment-1625689332
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
julianhyde commented on code in PR #3298:
URL: https://github.com/apache/calcite/pull/3298#discussion_r1256227009
##
site/_docs/reference.md:
##
@@ -2827,6 +2827,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b |
tanclary commented on code in PR #3290:
URL: https://github.com/apache/calcite/pull/3290#discussion_r1256055904
##
site/_docs/reference.md:
##
@@ -2752,6 +2752,8 @@ BigQuery's type system uses confusingly different names
for types and functions:
| b | FROM_BASE32(string)
tanclary commented on PR #3234:
URL: https://github.com/apache/calcite/pull/3234#issuecomment-1625641445
> If I were to make `safeDouble` always return true, would any tests fail?
>
> If I wrote
>
> ```
> boolean safeBoolean(boolean b) {
> return b == true || b ==
tanclary commented on PR #3147:
URL: https://github.com/apache/calcite/pull/3147#issuecomment-1625884550
> Is the new function class `SqlContainsSubstrFunction` necessary?
>
> Thanks for adding javadoc in SqlFunctions. For future reference, `{@code
... }` is slightly preferred over `
sonarcloud[bot] commented on PR #3147:
URL: https://github.com/apache/calcite/pull/3147#issuecomment-1625927852
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
JiajunBernoulli commented on code in PR #3289:
URL: https://github.com/apache/calcite/pull/3289#discussion_r1256811929
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -5122,7 +5122,115 @@ private static void checkIf(SqlOperatorFixture f) {
sonarcloud[bot] commented on PR #2949:
URL: https://github.com/apache/calcite/pull/2949#issuecomment-1626596383
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #3299:
URL: https://github.com/apache/calcite/pull/3299#issuecomment-1626598694
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #2949:
URL: https://github.com/apache/calcite/pull/2949#issuecomment-1626669450
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
ILuffZhe commented on PR #3290:
URL: https://github.com/apache/calcite/pull/3290#issuecomment-1626382549
Hi @zoudan, could you please rebase and squash the commits? I think the PR
is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ILuffZhe opened a new pull request, #3299:
URL: https://github.com/apache/calcite/pull/3299
Adjust some java docs and object references in RexProgramBuilderBase, which
helps others to understand better.
--
This is an automated message from the Apache Git Service.
To respond to the
JiajunBernoulli commented on code in PR #3299:
URL: https://github.com/apache/calcite/pull/3299#discussion_r1256763942
##
core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java:
##
@@ -756,8 +759,8 @@ protected RexNode vParam(String name, RelDataType type) {
JiajunBernoulli commented on code in PR #3299:
URL: https://github.com/apache/calcite/pull/3299#discussion_r1256768318
##
core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java:
##
@@ -756,8 +759,8 @@ protected RexNode vParam(String name, RelDataType type) {
JiajunBernoulli commented on PR #3284:
URL: https://github.com/apache/calcite/pull/3284#issuecomment-1626537259
Sorry to conflicting files.
Please resolve them.
> You can ask me if you encounter any problems.
--
This is an automated message from the Apache Git Service.
To
sonarcloud[bot] commented on PR #3299:
URL: https://github.com/apache/calcite/pull/3299#issuecomment-1626410244
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
sonarcloud[bot] commented on PR #2949:
URL: https://github.com/apache/calcite/pull/2949#issuecomment-1626506436
Kudos, SonarCloud Quality Gate passed! [![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png
ILuffZhe commented on code in PR #3299:
URL: https://github.com/apache/calcite/pull/3299#discussion_r1256770844
##
core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java:
##
@@ -756,8 +759,8 @@ protected RexNode vParam(String name, RelDataType type) {
*/
JiajunBernoulli commented on code in PR #3289:
URL: https://github.com/apache/calcite/pull/3289#discussion_r1256794693
##
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##
@@ -223,6 +224,42 @@ private static boolean skipItem(RexNode expr) {
&&
27 matches
Mail list logo