caicancai commented on code in PR #3790:
URL: https://github.com/apache/calcite/pull/3790#discussion_r1607483761
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -770,41 +773,39 @@ void testCastIntervalToNumeric(CastType castType,
SqlOperatorFixture
asolimando merged PR #3757:
URL: https://github.com/apache/calcite/pull/3757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
macroguo-ghy merged PR #3787:
URL: https://github.com/apache/calcite/pull/3787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on code in PR #3793:
URL: https://github.com/apache/calcite/pull/3793#discussion_r1606094164
##
build.gradle.kts:
##
@@ -792,6 +808,9 @@ allprojects {
inputs.property("java.vm.version",
System.getProperty("java.vm.version"))
sonarcloud[bot] commented on PR #3793:
URL: https://github.com/apache/calcite/pull/3793#issuecomment-2119343581
## [
}
-tasks.wrapper {
Review Comment:
now this task is embedded into gradle, so no
sonarcloud[bot] commented on PR #3591:
URL: https://github.com/apache/calcite/pull/3591#issuecomment-2119237724
## [ {
withEnv(["Path+JDK=$JAVA_JDK_17/bin","JAVA_HOME=$JAVA_JDK_17"]) {
sonarcloud[bot] commented on PR #3591:
URL: https://github.com/apache/calcite/pull/3591#issuecomment-2119174966
## [ from 3.2.5 to 3.2.8.
Release notes
Sourced from https://github.com/ruby/rexml/releases;>rexml's
releases.
REXML 3.2.8 -
asolimando commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2115825722
> > Few more minor changes and for me we are good to go.
> > Please don't force-push until the review process is on-going as it makes
incremental reviewing more difficult.
>
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603471671
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
caicancai commented on PR #3787:
URL: https://github.com/apache/calcite/pull/3787#issuecomment-2115472024
@mihaibudiu Can it be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
caicancai commented on PR #3786:
URL: https://github.com/apache/calcite/pull/3786#issuecomment-2115470679
@mihaibudiu Can it be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603529235
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1603471671
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
zabetak commented on code in PR #3733:
URL: https://github.com/apache/calcite/pull/3733#discussion_r1602910060
##
druid/src/test/java/org/apache/calcite/test/DruidAdapter2IT.java:
##
@@ -1912,7 +1912,11 @@ private void checkGroupBySingleSortLimit(boolean approx)
{
+
sonarcloud[bot] commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113237120
## [ {
jduo commented on PR #3757:
URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113060675
> Few more minor changes and for me we are good to go.
>
> Please don't force-push until the review process is on-going as it makes
incremental reviewing more difficult.
In
normanj-bitquill commented on PR #3792:
URL: https://github.com/apache/calcite/pull/3792#issuecomment-2113054134
This PR is the same as
https://github.com/apache/calcite/pull/3773
Needed to recreate to fix CI issues.
--
This is an automated message from the Apache Git Service.
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113053216
@mihaibudiu I tried creating a new PR here, that did build correctly.
https://github.com/apache/calcite/pull/3792
If you are OK with it, we should just use that PR and
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1601900134
##
core/src/test/java/org/apache/calcite/test/RelBuilderTest.java:
##
@@ -1450,6 +1452,225 @@ private RexNode caseCall(RelBuilder b, RexNode ref,
RexNode... nodes)
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111333588
## [ {
opBinding ->
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2110803385
## [ | Calculates an MD5
128-bit checksum of
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579306
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx,
SqlCall
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579143
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597579090
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -421,9 +421,12 @@ public enum SqlKind {
/** {@code DECODE} function (Oracle). */
DECODE,
-
caicancai commented on PR #3787:
URL: https://github.com/apache/calcite/pull/3787#issuecomment-2105578522
@mihaibudiu @chucheng92 Good to merge？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sonarcloud[bot] commented on PR #3787:
URL: https://github.com/apache/calcite/pull/3787#issuecomment-2105505318
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597164314
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10397,6 +10397,50 @@ void assertSubFunReturns(boolean binary, String s, int
start,
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597163878
##
site/_docs/reference.md:
##
@@ -2812,6 +2812,7 @@ In the following:
| b m p s | MD5(string) | Calculates an MD5
128-bit checksum
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597162522
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597162056
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx,
SqlCall
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597161501
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx,
SqlCall
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597157484
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597156525
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -421,9 +421,12 @@ public enum SqlKind {
/** {@code DECODE} function (Oracle). */
DECODE,
-
sonarcloud[bot] commented on PR #3733:
URL: https://github.com/apache/calcite/pull/3733#issuecomment-2105155879
## [ in calcite is allowed. The string type and the boolean type are
comparable. I am not sure about
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596944009
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596942382
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
1 - 100 of 9420 matches
Mail list logo
