[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1670175917 > I believe that we need to put it back I'd kindly vote for not re-introducing checkstyle. It is just outputting cryptic error messages without being able to fix (or propose a fix

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1602735739 @orpiske the revert breaks the invoker test in camel-package-maven-plugin. I wonder whether the failing snapshots deployment could be solved by using the older maven version only in the

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1594438079 > We should update the minimum maven version to 3.9.2 and in the docs where we say what maven version is needed to build Camel v4. Rather than hard coding the recommended Maven

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1594396127 Now I see that `camel-catalog-maven-grape` was added only yesterday, so it did not make it to the snapshots repo yet. I'd vote for merging this PR without waiting for it to

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1594364331 We have formatter and impsort [enabled by default](https://github.com/apache/camel-quarkus/blob/main/poms/build-parent/pom.xml#L169-L194) in `process-sources` phase in Camel Quarkus

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1594287508 The failure in the checkstyle job is interesting for two reasons: 1. `checkstyle:checkstyle` requires resolved dependencies and because it runs before any `install` and because

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1593198038 > > Actually mvnd 1.0-m6-m39-linux-amd64 uses maven-resolver 1.9.7 which I am sure suffers from the socket timeouts in the very same way as the older mvnd 0.8.2. Here is an example seen

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1592782087 > It is only used by the experimental incremental build to enable the parallel download of the pom files IIRC Ah, thanks for the hint! So those incremental builds are a kind of

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1592772355 Actually mvnd 1.0-m6-m39-linux-amd64 uses maven-resolver 1.9.7 which I am sure suffers from the socket timeouts in the very same way as the older mvnd 0.8.2. Here is an example seen in

[GitHub] [camel] ppalaga commented on pull request #10403: Upgrade Maven used by mvnw, upgrade mvnd, use consistent build options

ppalaga commented on PR #10403: URL: https://github.com/apache/camel/pull/10403#issuecomment-1592756889 I wonder which problem is that, @gnodet? Is it related to mvnd or mvnw (this PR touches both)? Anyway, mvnd 1.0-m6-m39-linux-amd64 was already used on some places before this PR.