Re: [PR] [chore] improve metrics for integration [camel-k]

squakez merged PR #5154: URL: https://github.com/apache/camel-k/pull/5154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-2007320824 To be squashed and merged once checks pass after the rebase. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-2007036375 @lgarciaaco I was about to merge but it seems there are merge conflicts could you please rebase against `main`? also, please, squash your commits to be a single one to have a cleaner

Re: [PR] [chore] improve metrics for integration [camel-k]

github-actions[bot] commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-1991325854 :warning: Unit test coverage report - coverage decreased from 37.1% to 36.9% (**-0.2%**) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on code in PR #5154: URL: https://github.com/apache/camel-k/pull/5154#discussion_r1502234619 ## go.mod: ## @@ -59,6 +59,8 @@ require ( sigs.k8s.io/structured-merge-diff/v4 v4.4.1 ) +require gotest.tools v2.2.0+incompatible Review Comment: I

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-1961048212 @gansheer please, rebase against `main` as we have fixed the errored check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on code in PR #5154: URL: https://github.com/apache/camel-k/pull/5154#discussion_r1499221233 ## go.mod: ## @@ -59,6 +59,8 @@ require ( sigs.k8s.io/structured-merge-diff/v4 v4.4.1 ) +require gotest.tools v2.2.0+incompatible Review Comment: Any

Re: [PR] [chore] improve metrics for integration [camel-k]

lgarciaaco commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-1959398081 @squakez I included all your recommendations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [chore] improve metrics for integration [camel-k]

squakez commented on code in PR #5154: URL: https://github.com/apache/camel-k/pull/5154#discussion_r1487579446 ## pkg/metrics/metrics.go: ## @@ -0,0 +1,36 @@ +package metrics Review Comment: I think we should reuse instead the existing

[PR] [chore] improve metrics for integration [camel-k]

lgarciaaco opened a new pull request, #5154: URL: https://github.com/apache/camel-k/pull/5154 Improve metrics for integrations, record a counter with integration_name and state This PR expands the metrics endpoint, now exposing a counter for the combination

Re: [PR] [chore] improve metrics for integration [camel-k]

lgarciaaco commented on PR #5154: URL: https://github.com/apache/camel-k/pull/5154#issuecomment-1941103074 Fixes https://github.com/apache/camel-k/issues/5120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL