oscerd merged PR #13507:
URL: https://github.com/apache/camel/pull/13507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2009067811
Let's merge this and regen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2007564453
got trouble building it (i'm on a windows os right now), you said we can
merge then rebuild ?
--
This is an automated message from the Apache Git Service.
To respond to the
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2006466950
Yes, if you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2006262224
shoudn't I do the mvn clean install -DskipTests and commit first ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2006257141
Sure, please make the PR ready to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2006251323
Didn't had time yesterday, Maybe we can look to merge it and I'll do the
intégration test later in another PR.
I'm a bit full this week, may have more time next week
--
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2001954625
No rush. Thanks for your time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-2001944870
I want just do the integration test. I should have time to do it tomorrow or
monday
--
This is an automated message from the Apache Git Service.
To respond to the message, please
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-237557
It is not looping, it is just that you need to run a full build to
regenerate the metadata of Azure Service bus component. So you should run mvn
clean install -DskipTests from the root
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-234760
just a question, it seams that the PR build is looping, is it normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526486276
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-1999795369
Ok, I see.
I'll create a receiver route based on my previous message. and another which
is consuming the subqueue to test the feature
--
This is an automated message from the
oscerd commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526379481
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +233,23 @@ public void
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526375296
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +233,23 @@ public
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526375296
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +233,23 @@ public
oscerd commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-1999783091
> Is there a way to write a test to cover this "onFailure" part ?
>
> for now I'm manully testing with route like:
>
> ```
> public static final String
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526368465
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +233,23 @@ public
oscerd commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526365686
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +233,23 @@ public void
romain-pfund commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-1999772163
Is there a way to write a test to cover this "onFailure" part ?
for now I'm manully testing with route like:
```
public static final String AZURE_SERVICE_BUS_COMPONENT
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526356686
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526321406
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
oscerd commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526323687
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public void
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526321406
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526307224
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
romain-pfund commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526307224
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public
oscerd commented on code in PR #13507:
URL: https://github.com/apache/camel/pull/13507#discussion_r1526298481
##
components/camel-azure/camel-azure-servicebus/src/main/java/org/apache/camel/component/azure/servicebus/ServiceBusConsumer.java:
##
@@ -228,8 +232,21 @@ public void
github-actions[bot] commented on PR #13507:
URL: https://github.com/apache/camel/pull/13507#issuecomment-1999608966
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel
romain-pfund opened a new pull request, #13507:
URL: https://github.com/apache/camel/pull/13507
# Description
Add a enableDeadLettering consumer configuration to allow deadlettering
failed message to the deadletter sub-queue
According to
29 matches
Mail list logo
