Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-21 Thread via GitHub
bartoszpop commented on PR #13823: URL: https://github.com/apache/camel/pull/13823#issuecomment-2068264977 > Can you add copy to Enrich / PollEnrich as well in another PR (PR for main is fine) @davsclaus I did prepare for both - [main](https://github.com/apache/camel/pull/13869) and

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-18 Thread via GitHub
davsclaus commented on PR #13825: URL: https://github.com/apache/camel/pull/13825#issuecomment-2063666815 We are not changing 3.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-18 Thread via GitHub
davsclaus closed pull request #13825: CAMEL-20614: deep-copy output processors during instantiation of a route template URL: https://github.com/apache/camel/pull/13825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-18 Thread via GitHub
davsclaus merged PR #13824: URL: https://github.com/apache/camel/pull/13824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.ap

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-18 Thread via GitHub
davsclaus commented on PR #13823: URL: https://github.com/apache/camel/pull/13823#issuecomment-2063654951 Can you add copy to Enrich / PollEnrich as well in another PR (PR for main is fine) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-18 Thread via GitHub
davsclaus merged PR #13823: URL: https://github.com/apache/camel/pull/13823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.ap

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-17 Thread via GitHub
bartoszpop commented on PR #13823: URL: https://github.com/apache/camel/pull/13823#issuecomment-2062791877 @gnodet comments addressed, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
gnodet commented on PR #13823: URL: https://github.com/apache/camel/pull/13823#issuecomment-2060419731 In addition to the two minor comments above, I think it would be really nice if the test case you wrote could be slightly reworked as a unit test and added to this PR. -- This is an aut

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
gnodet commented on code in PR #13823: URL: https://github.com/apache/camel/pull/13823#discussion_r1568243577 ## core/camel-core-model/src/main/java/org/apache/camel/model/NoOutputDefinition.java: ## @@ -29,4 +29,10 @@ public List> getOutputs() { return Collections.empt

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
gnodet commented on code in PR #13823: URL: https://github.com/apache/camel/pull/13823#discussion_r1568234017 ## core/camel-core-model/src/main/java/org/apache/camel/model/RouteTemplateDefinition.java: ## @@ -416,10 +421,10 @@ public RouteDefinition asRouteDefinition() {

[PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
bartoszpop opened a new pull request, #13825: URL: https://github.com/apache/camel/pull/13825 CAMEL-20614: deep-copy output processors during instantiation of a route template # Description When multiple threads try to instantiate and send an exchange to the same kamelet in pa

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #13825: URL: https://github.com/apache/camel/pull/13825#issuecomment-2060215703 :star2: Thank you for your contribution to the Apache Camel project! :star2: :warning: Please note that the changes on this PR may be **tested automatically**.

[PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
bartoszpop opened a new pull request, #13824: URL: https://github.com/apache/camel/pull/13824 CAMEL-20614: deep-copy output processors during instantiation of a route template # Description When multiple threads try to instantiate and send an exchange to the same kamelet in pa

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #13824: URL: https://github.com/apache/camel/pull/13824#issuecomment-2060202703 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

Re: [PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #13823: URL: https://github.com/apache/camel/pull/13823#issuecomment-2060202116 :star2: Thank you for your contribution to the Apache Camel project! :star2: :robot: CI automation will test this PR automatically. :camel: Apache Camel Committer

[PR] CAMEL-20614: deep-copy output processors during instantiation of a route template [camel]

2024-04-16 Thread via GitHub
bartoszpop opened a new pull request, #13823: URL: https://github.com/apache/camel/pull/13823 CAMEL-20614: deep-copy output processors during instantiation of a route template # Description When multiple threads try to instantiate and send an exchange to the same kamelet in pa