Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-29 Thread via GitHub
squakez merged PR #5488: URL: https://github.com/apache/camel-k/pull/5488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@camel.apac

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2135267619 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-28 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2134933058 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2133592647 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2133291529 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-27 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2133274705 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-23 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2126760074 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-23 Thread via GitHub
squakez commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2126733690 Given the problems found so far, I'm moving the code developed into https://github.com/squakez/camel-k/tree/feat/5476_executable_jar for future references. I've created a follow up issue

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-23 Thread via GitHub
squakez commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2126489443 Configmap tests are failing because when we use the fast-jar, the resources provided in the classpath are not "visible" to the route directly. The following one is failing (`java -cp ...

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-22 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2124589015 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-21 Thread via GitHub
squakez commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2122845191 I think the failures checks we're hitting is because of this joor issue: https://github.com/jOOQ/jOOR/issues/69 -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-21 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2122460727 :heavy_check_mark: Unit test coverage report - coverage increased from 38.4% to 38.6% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2103022091 :heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
lburgazzoli commented on code in PR #5488: URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595465265 ## pkg/trait/jvm.go: ## @@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool, *TraitCondition, error) { if e.CamelCatalog == nil {

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
squakez commented on code in PR #5488: URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595292465 ## pkg/trait/jvm.go: ## @@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool, *TraitCondition, error) { if e.CamelCatalog == nil {

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
lburgazzoli commented on code in PR #5488: URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595281935 ## pkg/trait/jvm.go: ## @@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool, *TraitCondition, error) { if e.CamelCatalog == nil {

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
squakez commented on code in PR #5488: URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595277277 ## pkg/trait/jvm.go: ## @@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool, *TraitCondition, error) { if e.CamelCatalog == nil {

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
lburgazzoli commented on code in PR #5488: URL: https://github.com/apache/camel-k/pull/5488#discussion_r1595269905 ## pkg/trait/jvm.go: ## @@ -81,10 +80,18 @@ func (t *jvmTrait) Configure(e *Environment) (bool, *TraitCondition, error) { if e.CamelCatalog == nil {

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2102371799 :heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #5488: URL: https://github.com/apache/camel-k/pull/5488#issuecomment-2102336806 :heavy_check_mark: Unit test coverage report - coverage increased from 38.1% to 38.3% (**+0.2%**) -- This is an automated message from the Apache Git Service. To respond to

[PR] feat(trait): jvm refactoring [camel-k]

2024-05-09 Thread via GitHub
squakez opened a new pull request, #5488: URL: https://github.com/apache/camel-k/pull/5488 * Added `jar` parameter which is automatically populated with the Kit executable Jar * Deprecated `print-command` in order to let distroless to work OOTB Ref #5476