nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2101687257
Thanks @absurdfarce! I have addressed the 2 minor documentation comments as
part of: https://github.com/apache/cassandra-java-driver/pull/1933/files
--
This is an autom
absurdfarce merged PR #1896:
URL: https://github.com/apache/cassandra-java-driver/pull/1896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2101007620
Thanks @nitinitt, this looks great! I concur that this commit looks like it
contains all the fixes we've been discussing so we are ready to get this guy
in! Big thank
absurdfarce commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1585228162
##
core/src/main/resources/reference.conf:
##
@@ -574,6 +574,11 @@ datastax-java-driver {
# Modifiable at runtime: no
# Overridable in
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2099492321
Thanks @absurdfarce for the guidance and the patience. I have squashed and
force pushed and here is how git log looks to e:
```
Author: Nitin Chhabra
Date: Thu
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2099192505
Excellent, that looks great @nitinitt! Thanks for jumping on that so
quickly!
As for your question: we do indeed plan on merging this ticket before the
next rel
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2098926296
> @nitinitt Probably the most straightforward way to incorporate the changes
would be to get a patch file from the other PR and then apply that patch to
this PR. You can g
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2098596820
@nitinitt Probably the most straightforward way to incorporate the changes
would be to get a patch file from the other PR and then apply that patch to
this PR. You can
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2097545011
Thanks @tolbertam and @absurdfarce for taking the time and helping to
simplify the code with [refactored
PR](https://github.com/absurdfarce/cassandra-java-driver/pull/1 ).
absurdfarce commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-2097402276
Apologies @nitinitt , I know this has taken a long time to get to... I
really appreciate your patience.
Overall I'm pretty positive on the change but I'm a bit co
tolbertam commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1591774161
##
core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java:
##
@@ -892,6 +892,16 @@ public String toString() {
tolbertam commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1591773768
##
core/src/main/java/com/datastax/oss/driver/api/core/config/DefaultDriverOption.java:
##
@@ -982,7 +982,13 @@ public enum DefaultDriverOption impleme
adutra commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1991260084
Hi @nitinitt sorry for the late reply. I'm syncing with @absurdfarce and
others in order to merge all the ready PRs, but that is taking some time
because of huge backlog and
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1971866885
Hey @adutra @absurdfarce Checking in, would the PR be accepted?
As I see other PR: https://github.com/apache/cassandra-java-driver/pull/1907
getting merged 2 weeks back
adutra commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1468438125
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -322,20 +336,41 @@ protected Queue maybeAdd
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1888191613
Thanks @adutra for the code review, have addressed all the review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449526333
##
core/src/test/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicyRemoteDcTest.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licens
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449376273
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -131,6 +135,15 @@ public BasicLoadBalanci
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449372615
##
core/src/test/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicyRemoteDcTest.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licens
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449372202
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -325,24 +338,63 @@ protected Queue maybeA
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1449368834
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -325,24 +338,63 @@ protected Queue maybeA
adutra commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1446225748
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -325,24 +338,63 @@ protected Queue maybeAdd
adutra commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1446150652
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -325,24 +338,63 @@ protected Queue maybeAdd
nitinitt commented on PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#issuecomment-1874927651
Thanks @adutra for the insightful code review comments, really appreciate
it. I'll address all of them and have an open question/clarification posted
above. Happy New Year
nitinitt commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1440126405
##
core/src/main/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicy.java:
##
@@ -325,24 +338,63 @@ protected Queue maybeA
adutra commented on code in PR #1896:
URL:
https://github.com/apache/cassandra-java-driver/pull/1896#discussion_r1435650327
##
core/src/main/java/com/datastax/oss/driver/api/core/config/TypedDriverOption.java:
##
@@ -886,6 +886,16 @@ public String toString() {
D
nitinitt opened a new pull request, #1896:
URL: https://github.com/apache/cassandra-java-driver/pull/1896
Ability to specify ordering of remote dc's via new configuration for
deterministic failovers.
https://datastax-oss.atlassian.net/browse/JAVA-3142
**Motivation**
The dr
27 matches
Mail list logo
