[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496932#comment-16496932
]
Shichao An commented on CASSANDRA-14422:
[~mshuler] Thanks for your explanation on the code
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496927#comment-16496927
]
Jay Zhuang commented on CASSANDRA-14422:
Thanks [~mshuler] for the information. Will follow
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496794#comment-16496794
]
Michael Shuler commented on CASSANDRA-14422:
For future reference, here is the code
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496110#comment-16496110
]
Jay Zhuang commented on CASSANDRA-14422:
Thanks [~shichao.an] for the fix. The change is
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495796#comment-16495796
]
Shichao An commented on CASSANDRA-14422:
You can ignore whitespace GitHub by adding a ?w=1
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495745#comment-16495745
]
Michael Shuler commented on CASSANDRA-14422:
Thanks for the info and no-whitespace diff.
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495651#comment-16495651
]
Jay Zhuang commented on CASSANDRA-14422:
Thanks [~spo...@gmail.com]. That's exactly the
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494904#comment-16494904
]
Stefan Podkowinski commented on CASSANDRA-14422:
The dependencies are listed in the
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494696#comment-16494696
]
Jay Zhuang commented on CASSANDRA-14422:
Sure, I split the change for easy review:
||Diff||
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494660#comment-16494660
]
Jeff Jirsa commented on CASSANDRA-14422:
Should definitely minimize the whitespace changes.
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494541#comment-16494541
]
Michael Shuler commented on CASSANDRA-14422:
1) I stopped looking for what changed in
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494393#comment-16494393
]
Jay Zhuang commented on CASSANDRA-14422:
The change looks good to me. @[~mshuler],
[
https://issues.apache.org/jira/browse/CASSANDRA-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16454712#comment-16454712
]
Shichao An commented on CASSANDRA-14422:
Here's the patch:
||Branch||uTest||
13 matches
Mail list logo