[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905230#comment-16905230 ] Benedict commented on CASSANDRA-15194: -- bq. While we're here, should we consider renaming

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904250#comment-16904250 ] Chris Lohfink commented on CASSANDRA-15194: --- changed per feedback and squashed > Improve

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902110#comment-16902110 ] Benedict commented on CASSANDRA-15194: -- Thanks, the patch looks good. I've pushed some minor

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900329#comment-16900329 ] Jon Haddad commented on CASSANDRA-15194: Patch looks great, thanks for those fixes.  +1 from

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899682#comment-16899682 ] Chris Lohfink commented on CASSANDRA-15194: --- Changed to multiplication to the reciprocal

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899416#comment-16899416 ] Benedict commented on CASSANDRA-15194: -- I'll try to take a quick look at this early next week

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899164#comment-16899164 ] Jon Haddad commented on CASSANDRA-15194: Just took a look at the patch and noticed a few

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878177#comment-16878177 ] Jon Haddad commented on CASSANDRA-15194: rows_scanned_per_query is more obvious to

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878101#comment-16878101 ] Chris Lohfink commented on CASSANDRA-15194: --- table naming changes sound good, I'll include

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878096#comment-16878096 ] Benedict commented on CASSANDRA-15194: -- That works for tables that have a clear name, which

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878087#comment-16878087 ] Chris Lohfink commented on CASSANDRA-15194: --- I actually like idea of just calling the

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878040#comment-16878040 ] Benedict commented on CASSANDRA-15194: -- > yet auto-uncapitalizes unquoted things Wow, I did

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878037#comment-16878037 ] Jon Haddad commented on CASSANDRA-15194: Or write "megabytes" to disambiguate. > Improve

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878013#comment-16878013 ] Chris Lohfink commented on CASSANDRA-15194: --- My intent was to set rounding mode to UP so

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877966#comment-16877966 ] Benedict commented on CASSANDRA-15194: -- Sounds reasonable. Could you clarify what you mean by

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877932#comment-16877932 ] Chris Lohfink commented on CASSANDRA-15194: --- My thought here was to do: * add units top

[jira] [Commented] (CASSANDRA-15194) Improve readability of Table metrics Virtual tables units

[ https://issues.apache.org/jira/browse/CASSANDRA-15194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877654#comment-16877654 ] Benedict commented on CASSANDRA-15194: -- We should probably standardise on number of digits