[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-24 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091412#comment-17091412 ] ZhaoYang commented on CASSANDRA-15666: -- thanks for the review and feedback~ > Race condition

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-23 Thread Benjamin Lerer (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090579#comment-17090579 ] Benjamin Lerer commented on CASSANDRA-15666: It looks good to me. Thanks for the patch

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-20 Thread Sergio Bossa (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087966#comment-17087966 ] Sergio Bossa commented on CASSANDRA-15666: -- Good to merge for me. > Race condition when

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-12 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081858#comment-17081858 ] ZhaoYang commented on CASSANDRA-15666: -- | [patch|https://github.com/apache/cassandra/pull/497]

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-09 Thread Sergio Bossa (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079527#comment-17079527 ] Sergio Bossa commented on CASSANDRA-15666: -- [~jasonstack] thanks for the followups, sent

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-08 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078472#comment-17078472 ] ZhaoYang commented on CASSANDRA-15666: -- bq. 1) Only the "follower" is allowed to send the

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-08 Thread Benjamin Lerer (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078313#comment-17078313 ] Benjamin Lerer commented on CASSANDRA-15666: I put some comments on the PR. It is always

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-07 Thread Sergio Bossa (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077478#comment-17077478 ] Sergio Bossa commented on CASSANDRA-15666: -- {quote}Let's see what [~blerer] has to say

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-03 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074405#comment-17074405 ] ZhaoYang commented on CASSANDRA-15666: -- bq. Regarding the changes to the CompleteMessage

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-02 Thread Sergio Bossa (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073831#comment-17073831 ] Sergio Bossa commented on CASSANDRA-15666: -- [~jasonstack] your fix looks good, just left a

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-04-01 Thread Michael Semb Wever (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073052#comment-17073052 ] Michael Semb Wever commented on CASSANDRA-15666: ||branch||circleci||jenkins||

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-03-27 Thread Sergio Bossa (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068663#comment-17068663 ] Sergio Bossa commented on CASSANDRA-15666: -- bq. it's still possible to send 2

[jira] [Commented] (CASSANDRA-15666) Race condition when completing stream sessions

2020-03-27 Thread ZhaoYang (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068591#comment-17068591 ] ZhaoYang commented on CASSANDRA-15666: -- {quote}4) At this point, if this was the only file to