[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17091412#comment-17091412
]
ZhaoYang commented on CASSANDRA-15666:
--
thanks for the review and feedback~
> Race condition
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090579#comment-17090579
]
Benjamin Lerer commented on CASSANDRA-15666:
It looks good to me.
Thanks for the patch
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087966#comment-17087966
]
Sergio Bossa commented on CASSANDRA-15666:
--
Good to merge for me.
> Race condition when
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081858#comment-17081858
]
ZhaoYang commented on CASSANDRA-15666:
--
| [patch|https://github.com/apache/cassandra/pull/497]
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079527#comment-17079527
]
Sergio Bossa commented on CASSANDRA-15666:
--
[~jasonstack] thanks for the followups, sent
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078472#comment-17078472
]
ZhaoYang commented on CASSANDRA-15666:
--
bq. 1) Only the "follower" is allowed to send the
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078313#comment-17078313
]
Benjamin Lerer commented on CASSANDRA-15666:
I put some comments on the PR.
It is always
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077478#comment-17077478
]
Sergio Bossa commented on CASSANDRA-15666:
--
{quote}Let's see what [~blerer] has to say
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074405#comment-17074405
]
ZhaoYang commented on CASSANDRA-15666:
--
bq. Regarding the changes to the CompleteMessage
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073831#comment-17073831
]
Sergio Bossa commented on CASSANDRA-15666:
--
[~jasonstack] your fix looks good, just left a
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073052#comment-17073052
]
Michael Semb Wever commented on CASSANDRA-15666:
||branch||circleci||jenkins||
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068663#comment-17068663
]
Sergio Bossa commented on CASSANDRA-15666:
--
bq. it's still possible to send 2
[
https://issues.apache.org/jira/browse/CASSANDRA-15666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068591#comment-17068591
]
ZhaoYang commented on CASSANDRA-15666:
--
{quote}4) At this point, if this was the only file to
13 matches
Mail list logo