[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-23 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14638960#comment-14638960 ] Ariel Weisberg commented on CASSANDRA-9863: --- I updated the branch. There is

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-23 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639160#comment-14639160 ] Ariel Weisberg commented on CASSANDRA-9863: --- I don't think I introduced new

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-23 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639379#comment-14639379 ] Benedict commented on CASSANDRA-9863: - Thanks. I've pushed a single line change to

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-23 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14639090#comment-14639090 ] Benedict commented on CASSANDRA-9863: - Mostly LGTM, however we can now call

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636887#comment-14636887 ] Benedict commented on CASSANDRA-9863: - Well, it actually would be necessary to

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637637#comment-14637637 ] Ariel Weisberg commented on CASSANDRA-9863: --- Waiting on tests for patch

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Ariel Weisberg (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637783#comment-14637783 ] Ariel Weisberg commented on CASSANDRA-9863: --- Hmmm yeah... the shuffling is

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637755#comment-14637755 ] Benedict commented on CASSANDRA-9863: - Thanks. Mostly looks good. However I must

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14637892#comment-14637892 ] Benedict commented on CASSANDRA-9863: - Some ugliness there, though. Mostly: how do

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636788#comment-14636788 ] Benedict commented on CASSANDRA-9863: - It's a costly no-op that under correct

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Benedict (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636833#comment-14636833 ] Benedict commented on CASSANDRA-9863: - It's worth pointing out that the cost is

[jira] [Commented] (CASSANDRA-9863) NIODataInputStream has problems on trunk

2015-07-22 Thread Sylvain Lebresne (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-9863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14636855#comment-14636855 ] Sylvain Lebresne commented on CASSANDRA-9863: - bq. I'm actually perfectly