[GitHub] rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

2018-01-03 Thread GitBox
rhtyd commented on issue #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option? URL: https://github.com/apache/cloudstack/pull/2377#issuecomment-354955440 Test LGTM. The one failure is an env caused issue. -

[GitHub] rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support

2018-01-03 Thread GitBox
rhtyd commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-354955642 @fmaximus please fix license issues, see Travis job1 failure: ``` [INFO] 7487 resources included (use -debug for more detai

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
blueorangutan commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354956141 Packaging result: ?centos6 ?centos7 ?debian. JID-1550 This is an automated message from the Ap

[GitHub] houthuis commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
houthuis commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354956223 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

2018-01-03 Thread GitBox
rhtyd commented on issue #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374#issuecomment-354956980 Test LGTM, the new migration test passes as well. I'll merge this based on code reviews and test results.

[GitHub] rhtyd closed pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments

2018-01-03 Thread GitBox
rhtyd closed pull request #2374: CLOUDSTACK-10024: Network Migration: Tackle review comments URL: https://github.com/apache/cloudstack/pull/2374 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage

2018-01-03 Thread GitBox
rhtyd commented on issue #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#issuecomment-354958002 @mike-tutkowski can you fix the conflicts and address outstanding issues? Additional code review is also requested. --

[GitHub] rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

2018-01-03 Thread GitBox
rhtyd commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159375956 ## File path: plugins/api/solidfire-sioc/pom.xml ## @@ -0,0 +1,47 @@ + +http://maven.apache.org/PO

[GitHub] rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

2018-01-03 Thread GitBox
rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-354958199 @syed can you fix the conflicts? This is an automated message from the Apach

[GitHub] rhtyd commented on issue #2152: improved logging, removed usued code

2018-01-03 Thread GitBox
rhtyd commented on issue #2152: improved logging, removed usued code URL: https://github.com/apache/cloudstack/pull/2152#issuecomment-354958113 ping @pdion891. Additional review is requested as well. This is an automated messa

[GitHub] rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

2018-01-03 Thread GitBox
rhtyd commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use. URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-354958330 @blueorangutan test This is an automated messag

[GitHub] rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354958297 @blueorangutan package This is an automated mes

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354958321 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering

2018-01-03 Thread GitBox
rhtyd commented on issue #2231: [CLOUDSTACK-10039] Adding IOPS/GB offering URL: https://github.com/apache/cloudstack/pull/2231#issuecomment-354958199 @syed can you fix the conflicts? Additional code review is also requested. ---

[GitHub] rhtyd commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapsho

2018-01-03 Thread GitBox
rhtyd commented on issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM are not allowed and are not limited per host as per the global configuration parameter "concurrent.snapshots.threshold.perhost". URL: https://github.com/apache/cloudstack/pull/1897#issuecomment-354958395 @

[GitHub] blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

2018-01-03 Thread GitBox
blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use. URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-354958497 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-354958475 @blueorangutan package Additional review requested /cc @marcaurele --

[GitHub] blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-354958490 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progre

[GitHub] rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958623 Kicking again @blueorangutan test centos7 vmware-55u3 -

[GitHub] abhinandanprateek opened a new pull request #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
abhinandanprateek opened a new pull request #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146 JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-4757 Updated FS here: https://cwiki.apache.or

[GitHub] rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958623 Kicking again @blueorangutan test centos7 vmware-55u3 -

[GitHub] rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
rhtyd commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-354958995 Test LGTM. Are you lgtm on this @nvazquez @DaanHoogland ? I've kicked a final test round against vmware-65 as we

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2018-01-03 Thread GitBox
blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354961241 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2018-01-03 Thread GitBox
rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354961190 @blueorangutan package This is an automa

[GitHub] blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-354964582 Packaging result: ?centos6 ?centos7 ?debian. JID-1552 ---

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354964581 Packaging result: ?centos6 ?centos7 ?debian. JID-1551 --

[GitHub] marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-01-03 Thread GitBox
marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#discussion_r159381585 ## File path: api/src/org/apache/cloudstack/api/command/admin/host/Reco

[GitHub] marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-01-03 Thread GitBox
marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#discussion_r159381276 ## File path: engine/orchestration/src/com/cloud/agent/manager/AgentMan

[GitHub] marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-01-03 Thread GitBox
marcaurele commented on a change in pull request #837: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/837#discussion_r159381344 ## File path: engine/orchestration/src/com/cloud/agent/manager/Clustere

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2018-01-03 Thread GitBox
blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354965837 Packaging result: ?centos6 ?centos7 ?debian. JID-1553 ---

[GitHub] rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
rhtyd commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-354967518 @blueorangutan test This is an autom

[GitHub] blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-354967635 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke

[GitHub] rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2018-01-03 Thread GitBox
rhtyd commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354967727 @blueorangutan test centos7 xenserver-65sp1 -

[GitHub] rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
rhtyd commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354967783 @blueorangutan test centos7 xenserver-65sp1 Thi

[GitHub] blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state

2018-01-03 Thread GitBox
blueorangutan commented on issue #2149: CLOUDSTACK-9932 snapshot is getting deleted while volume is in creating state URL: https://github.com/apache/cloudstack/pull/2149#issuecomment-354967841 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-354967828 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

[GitHub] ernjvr opened a new pull request #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
ernjvr opened a new pull request #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383 CLOUDSTACK-9599: problem: Using cloudmonkey, when invoking the update template api call, it does not display the isdynamicallyscalable

[GitHub] jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2018-01-03 Thread GitBox
jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-354973597 @rhtyd Same test cases are failed for pull request https://github.com/apache/cloudstac

[GitHub] jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2018-01-03 Thread GitBox
jayakarteek commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-354973597 @rhtyd Same test cases are failed for pull request https://github.com/apache/cloudstac

[GitHub] rhtyd commented on a change in pull request #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
rhtyd commented on a change in pull request #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#discussion_r159389912 ## File path: packaging/systemd/cloudstack-agent.service ## @@ -18,8 +18,8

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354974768 @blueorangutan package This is an automated

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354974917 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] rhtyd commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2018-01-03 Thread GitBox
rhtyd commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-354976570 @jayakarteek see #2376 you can see 0 smoketest failures. `bo` does not talk to strangers :) I'l

[GitHub] blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2018-01-03 Thread GitBox
blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-354976776 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make pr

[GitHub] DaanHoogland commented on issue #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2380#issuecomment-354977686 @rafaelweingartner @marcaurele @rhtyd I am not picking this up. I just 're-opened' this becau

[GitHub] rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354978390 Good work and congrats @ernjvr for your first PR! in future you may create a git commit the follows the following convention:

[GitHub] rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354979128 @blueorangutan package This is an automated message from the

[GitHub] blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354979232 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
rhtyd commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354979613 @houthuis looks like we're at capacity, we currently don't have you in the `bo` ACLs to allow kicking tests. Use @blueorangutan help to see options and ACl list. -

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
blueorangutan commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354979672 @rhtyd I understand these words: "help", "hello", "thanks", "package", "test" Test command usage: test [mgmt os] [hypervisor] [additional tests] Mgmt OS o

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354981902 Packaging result: ?centos6 ?centos7 ?debian. JID-1554 ---

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354982093 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
rhtyd commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-354982079 @blueorangutan test This is an automated mes

[GitHub] blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot

2018-01-03 Thread GitBox
blueorangutan commented on issue #2104: CLOUDSTACK-9908 : Primary Storage allocated capacity goes very high after VM snapshot URL: https://github.com/apache/cloudstack/pull/2104#issuecomment-354982737 Packaging result: ?centos6 ?centos7 ?debian. JID-1555 ---

[GitHub] blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354984420 Packaging result: ?centos6 ?centos7 ?debian. JID-1556

[GitHub] rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
rhtyd commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354984873 @blueorangutan test This is an automated message from the Apa

[GitHub] blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-354984909 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

2018-01-03 Thread GitBox
rhtyd commented on issue #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency URL: https://github.com/apache/cloudstack/pull/2156#issuecomment-354990873 Tests lgtm. Merging this based on two lgtms and test results. --

[GitHub] rhtyd closed pull request #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency

2018-01-03 Thread GitBox
rhtyd closed pull request #2156: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency URL: https://github.com/apache/cloudstack/pull/2156 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[cloudstack] branch master updated: CLOUDSTACK-9971: Bugfix/listaccounts parameter consistency (#2156)

2018-01-03 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 000ee36 CLOUDSTACK-9971: Bugfix/listaccounts

[GitHub] rhtyd commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
rhtyd commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354995296 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
blueorangutan commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354995421 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-03 Thread GitBox
mrunalinikankariya commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-354999754 Added refactoring changes This is

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
blueorangutan commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-354999844 Packaging result: ?centos6 ?centos7 ?debian. JID-1557 This is an automated message from the Ap

[GitHub] rafaelweingartner commented on issue #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API.

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #2380: CLOUDSTACK-8855 Improve Error Message for Host Alert State and reconnect host API. URL: https://github.com/apache/cloudstack/pull/2380#issuecomment-355001857 @DaanHoogland ok... I will try to squeeze this in next week.

[GitHub] blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355009737 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
borisstoyanov commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355009689 @blueorangutan package This is an automated messa

[GitHub] blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355015320 Packaging result: ?centos6 ?centos7 ?debian. JID-1558

[GitHub] nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
nvazquez commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355027421 LGTM This is an automated message from the Apa

[GitHub] DaanHoogland opened a new pull request #2384: CLOUDSTACK-10210 cleanup testfile

2018-01-03 Thread GitBox
DaanHoogland opened a new pull request #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384 cleaning up in the @After-method so it gets clean in case of exception as well This is an aut

[GitHub] rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

2018-01-03 Thread GitBox
rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355037209 The changes are restricted to only the unit test, Travis test results/confirmation should be enough for QA-ing the PR. --

[GitHub] nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355037300 @rhtyd @borisstoyanov @DaanHoogland marvin tests added, results on my local environment: cat /tmp//Marvi

[GitHub] DaanHoogland commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

2018-01-03 Thread GitBox
DaanHoogland commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#discussion_r159452635 ## File path: test/integration/component/test_host.py ## @@ -155,7 +15

[GitHub] DaanHoogland commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-355042084 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] blueorangutan commented on issue #2382: CLOUDSTACK-4045

2018-01-03 Thread GitBox
blueorangutan commented on issue #2382: CLOUDSTACK-4045 URL: https://github.com/apache/cloudstack/pull/2382#issuecomment-355042151 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355043207 @rafaelweingartner did your concerns get addressed, yet? --

[GitHub] blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355057208 Trillian test result (tid-1980) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total t

[GitHub] rafaelweingartner commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355065649 @nvazquez before I start reviewing I have some doubts. Can you answer them? I read your PR description, whic

[GitHub] rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355066066 @DaanHoogland I am not sure. I thought @nvazquez was still working on them. --

[GitHub] khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

2018-01-03 Thread GitBox
khos2ow commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355073616 @rhtyd @rafaelweingartner the new change: - registers both iso names at `ComponentLifecycle`#`configure` time - and lat

[GitHub] nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
nvazquez commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355082617 Thanks for your time @rafaelweingartner, let me answer your questions: - Yes, this feature is specific for KVM - T

[GitHub] blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355087119 Trillian test result (tid-1981) Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7 Total t

[GitHub] rafaelweingartner commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#issuecomment-355088124 What are the assumptions here? I mean, is it possible to have clusters/hosts with different versions of XenServ

[GitHub] blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
blueorangutan commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355092121 Trillian test result (tid-1987) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt serve

[GitHub] rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor?

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Stor? URL: https://github.com/apache/cloudstack/pull/1740#issuecomment-355092544 @rhtyd I tested this fix in my dev environment and it solved the described problem. I think this

[GitHub] blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use.

2018-01-03 Thread GitBox
blueorangutan commented on issue #1773: CLOUDSTACK-9607: Preventing template deletion when template is in use. URL: https://github.com/apache/cloudstack/pull/1773#issuecomment-355094518 Trillian test result (tid-1983) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response

2018-01-03 Thread GitBox
blueorangutan commented on issue #2383: "isdynamicallyscalable" Field to UpdateTemplate Response URL: https://github.com/apache/cloudstack/pull/2383#issuecomment-355095143 Trillian test result (tid-1991) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-354745696 @blueorangutan test This is an automated message from the Apache Git Servi

[GitHub] blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-354739735 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-354745722 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355095836 @blueorangutan package This is an automated message from the Apache Git Se

[GitHub] DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-354739575 @blueorangutan package This is an automated message from the Apache Git S

[GitHub] blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-354744993 Packaging result: ?centos6 ?centos7 ?debian. JID-1536 This is an automate

[GitHub] blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355096033 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance

2018-01-03 Thread GitBox
blueorangutan commented on issue #2260: CLOUDSTACK-10065: Optimize SQL queries in listTemplate API to improve performance URL: https://github.com/apache/cloudstack/pull/2260#issuecomment-355097240 Trillian test result (tid-1986) Environment: kvm-centos7 (x2), Advanced Networking with Mgm

[GitHub] blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls

2018-01-03 Thread GitBox
blueorangutan commented on issue #2046: CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls URL: https://github.com/apache/cloudstack/pull/2046#issuecomment-355099537 Trillian test result (tid-1990) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server

[GitHub] DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
DaanHoogland commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355099685 @rafaelweingartner I only see prior existing catchAlls. I don't think these warant a -1 so I wonder if the

[GitHub] rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates

2018-01-03 Thread GitBox
rafaelweingartner commented on issue #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates URL: https://github.com/apache/cloudstack/pull/2146#issuecomment-355102557 It is not only comments related to generic catches... There are a few others, for instance, there is o

[GitHub] blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

2018-01-03 Thread GitBox
blueorangutan commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355102587 Packaging result: ?centos6 ?centos7 ?debian. JID-1559 This is an automate

[GitHub] blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

2018-01-03 Thread GitBox
blueorangutan commented on issue #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#issuecomment-355109759 Trillian test result (tid-1979) Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 6 Tot

  1   2   3   >