[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159595904 ## File path: engine/storage/volume/src/org/apache/cloudstack/storage/datastore/manager/Pri

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159596083 ## File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProces

[GitHub] SudharmaJain commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

SudharmaJain commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355220731 @rhtyd I have updated the changes for master. ---

[GitHub] blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s)

blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s) URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355221237 Packaging result: ?centos6 ?centos7 ?debian. JID-1564

[GitHub] blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support

blueorangutan commented on issue #2097: [4.11] CLOUDSTACK-9813: Extending Config Drive support URL: https://github.com/apache/cloudstack/pull/2097#issuecomment-355221267 Packaging result: ?centos6 ?centos7 ?debian. JID-1566 T

[GitHub] blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355221268 Packaging result: ?centos6 ?centos7 ?debian. JID-1565 This

[GitHub] blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355222541 Packaging result: ?centos6 ?centos7 ?debian. JID-1567 --

[GitHub] blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch? URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355222771 Packaging result: ?centos6 ?centos7 ?debian. JID-1568 --

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355222772 Packaging result: ?centos6 ?centos7 ?debian. JID-1569

[GitHub] blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355223042 Packaging result: ?centos6 ?centos7 ?debian. JID-1570

[GitHub] blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ? URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355223514 Packaging result: ?centos6 ?centos7 ?debian. JID-1571 --

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159597548 ## File path: server/src/com/cloud/template/TemplateAdapterBase.java ## @@ -339,9

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159598178 ## File path: utils/src/main/java/com/cloud/utils/UriUtils.java ## @@ -289,6 +297,

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159596146 ## File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProces

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159596678 ## File path: server/src/com/cloud/api/query/vo/TemplateJoinVO.java ## @@ -477,4 +

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159596656 ## File path: server/src/com/cloud/api/query/vo/TemplateJoinVO.java ## @@ -222,6 +

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159597834 ## File path: server/src/org/apache/cloudstack/direct/download/DirectDownloadManagerImpl.ja

[GitHub] marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159596587 ## File path: engine/schema/src/com/cloud/storage/VMTemplateVO.java ## @@ -146,6 +

[GitHub] blueorangutan commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy

blueorangutan commented on issue #2275: CLOUDSTACK-9975: Allow customizing system VM templates for SSVM and Console Proxy URL: https://github.com/apache/cloudstack/pull/2275#issuecomment-355223966 Packaging result: ?centos6 ?centos7 ?debian. JID-1572 ---

[GitHub] blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted.

blueorangutan commented on issue #1775: CLOUDSTACK-9606: While IP address is released, tag are not deleted. URL: https://github.com/apache/cloudstack/pull/1775#issuecomment-355224720 Packaging result: ?centos6 ?centos7 ?debian. JID-1573 -

[GitHub] blueorangutan commented on issue #1730: VMTemplateZone needs some love

blueorangutan commented on issue #1730: VMTemplateZone needs some love URL: https://github.com/apache/cloudstack/pull/1730#issuecomment-355225211 Packaging result: ?centos6 ?centos7 ?debian. JID-1574 This is an automated messa

[GitHub] rhtyd commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

rhtyd commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355227128 @blueorangutan package This is an automated mes

[GitHub] rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

rhtyd commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355227038 @yvsubhash can you also fix build failures? This is an auto

[GitHub] rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

rhtyd commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch? URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355227224 @blueorangutan test This is an automated messag

[GitHub] blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355227301 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch?

blueorangutan commented on issue #2274: CLOUDSTACK-10096 Can't reset integration.api.port and usage.sanity.ch? URL: https://github.com/apache/cloudstack/pull/2274#issuecomment-355227295 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

blueorangutan commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ? URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355227482 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

[GitHub] rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ?

rhtyd commented on issue #2088: CLOUDSTACK-9892: Primary storage resource check is broken when using ? URL: https://github.com/apache/cloudstack/pull/2088#issuecomment-355227423 @blueorangutan test centos7 vmware-55u3

[GitHub] rhtyd commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s)

rhtyd commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s) URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355227660 @blueorangutan test centos7 xenserver-65sp1 --

[GitHub] rhtyd commented on issue #1730: VMTemplateZone needs some love

rhtyd commented on issue #1730: VMTemplateZone needs some love URL: https://github.com/apache/cloudstack/pull/1730#issuecomment-355227741 @blueorangutan test This is an automated message from the Apache Git Service. To respond

[GitHub] rhtyd commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

rhtyd commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355227756 @blueorangutan test --

[GitHub] blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s)

blueorangutan commented on issue #2079: CLOUDSTACK-9906 Create snapshot after volume resize for the volume with existing snapshot(s) URL: https://github.com/apache/cloudstack/pull/2079#issuecomment-355227859 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicke

[GitHub] blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored

blueorangutan commented on issue #1906: CLOUDSTACK-9743 - ODL plugin responds to deleteHost causing other plugin in the chain to be ignored URL: https://github.com/apache/cloudstack/pull/1906#issuecomment-355227850 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been k

[GitHub] blueorangutan commented on issue #1730: VMTemplateZone needs some love

blueorangutan commented on issue #1730: VMTemplateZone needs some love URL: https://github.com/apache/cloudstack/pull/1730#issuecomment-355227854 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

rhtyd commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355228076 @blueorangutan test This is an automated message from

[GitHub] rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

rhtyd commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355228042 @DaanHoogland looks like we've new conflicts, please fix them This is an automate

[GitHub] rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

rhtyd commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355228275 @blueorangutan test This is an automated messag

[GitHub] blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination

blueorangutan commented on issue #2073: CLOUDSTACK-9896: API: listDedicatedXXX should respect pagination URL: https://github.com/apache/cloudstack/pull/2073#issuecomment-355228243 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

rhtyd commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355228365 @blueorangutan test centos7 xenserver-65sp1 This is an automated m

[GitHub] blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua?

blueorangutan commented on issue #2292: CLOUDSTACK-10108:ConfigKey based approach for reading 'ping' configua? URL: https://github.com/apache/cloudstack/pull/2292#issuecomment-355228437 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM

blueorangutan commented on issue #2368: CLOUDSTACK-10126: Separate Subnet for SSVM and CPVM URL: https://github.com/apache/cloudstack/pull/2368#issuecomment-355228425 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests ---

[GitHub] yvsubhash commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

yvsubhash commented on issue #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain URL: https://github.com/apache/cloudstack/pull/2102#issuecomment-355230923 @rhtyd build failure is fixed This is an automated mes

[GitHub] DaanHoogland commented on a change in pull request #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on a change in pull request #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#discussion_r159604356 ## File path: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResou

[GitHub] blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i?

blueorangutan commented on issue #2271: CLOUDSTACK-10087 Template registration errors out when template URL i? URL: https://github.com/apache/cloudstack/pull/2271#issuecomment-355232268 Packaging result: ?centos6 ?centos7 ?debian. JID-1575 --

[GitHub] marcaurele commented on a change in pull request #2384: CLOUDSTACK-10210 cleanup testfile

marcaurele commented on a change in pull request #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#discussion_r159606283 ## File path: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResourc

[GitHub] DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355233097 @marcaurele I want to be absolutely sure that the registration for deletion is not skipped by an exception and I have never tried to to it bef

[GitHub] marcaurele commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

marcaurele commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355233875 From the API docs: > Deletion will be attempted only for normal termination of the virtual machine, as defined by the Java Language Specificat

[GitHub] DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159608121 ## File path: server/src/com/cloud/configuration/Config.java ## @@ -191,6 +191,22 @@

[GitHub] DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage

DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements for managed storage URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159608638 ## File path: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMo

[GitHub] DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355236560 @marcaurele I don't agree it would have to have a try-finaly construct to be sure the deletion happens, which is semantically the same as using

[GitHub] marcaurele commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

marcaurele commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355240138 @DaanHoogland semantically it's not the same for me as there is more than 1 test in the class. The `@after` will be run too if you only run the s

[GitHub] DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355241310 @marcaurele valid point except that the other test is disabled and will never be run. Also my thinking was that the file might be used in more

[GitHub] rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355243616 @DaanHoogland first, if the other test is disabled, what about deleting it? Second, I also prefer as mark said, delete (delete, not

[GitHub] DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355247602 @marcaurele @rafaelweingartner how about this one? This is an automated messag

[GitHub] rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355243616 @DaanHoogland first, if the other test is disabled, what about deleting it? Second, I also prefer as mark said, delete (delete, not

[GitHub] rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355248713 You are using a try/finally because you believe an exception might happen? If an exception happen in `swiftWriteMetadataFile` I believe

[GitHub] borisstoyanov commented on issue #2381: CLOUDSTACK-10117 Account ldap binding

borisstoyanov commented on issue #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#issuecomment-355249254 @blueorangutan package This is an automated message from the Apache

[GitHub] jayakarteek commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

jayakarteek commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-355249169 @blueorangutan can you run package build again,

[GitHub] rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-355250309 @jayakarteek you can try with `@blueorangutan package` yourself next time @blueorangutan package ---

[GitHub] rhtyd closed pull request #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

rhtyd closed pull request #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-355250408 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] jayakarteek opened a new pull request #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

jayakarteek opened a new pull request #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139 Steps to reproduce issue 1. Deploy a VM 2. Take snapshot of the root volume 3. Delete the snapshot 4. Before the garba

[GitHub] rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159622964 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/

[GitHub] rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159623591 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/

[GitHub] DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159623770 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java

[GitHub] rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+ URL: https://github.com/apache/cloudstack/pull/2365#discussion_r159623352 ## File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discovere

[GitHub] DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159623979 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.

[GitHub] DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

DaanHoogland commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159623950 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java

[GitHub] rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159624528 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java ###

[GitHub] rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159624683 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.java #

[GitHub] rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

rhtyd commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159624600 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LinkAccountToLdapCmd.java ###

[GitHub] blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

blueorangutan commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-355252894 Packaging result: ?centos6 ?centos7 ?debian. JID-1576 -

[GitHub] marcaurele commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding

marcaurele commented on a change in pull request #2381: CLOUDSTACK-10117 Account ldap binding URL: https://github.com/apache/cloudstack/pull/2381#discussion_r159626258 ## File path: plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/response/LdapConfigurationResponse.ja

[GitHub] rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running.

rhtyd commented on issue #2139: CLOUDSTACK-9921: NPE when storage garbage collector is running. URL: https://github.com/apache/cloudstack/pull/2139#issuecomment-355255255 Please fix the build failures @jayakarteek This is an

[GitHub] DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

DaanHoogland commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355256479 @rafaelweingartner I have no idea and I want to be sure. Any I/O operation is suspect and probe to exceptions (not just the creation but also s

[GitHub] rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check

rhtyd commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-355256466 @blueorangutan package This is an automated message from the Apache Git Service. T

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-355256656 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355256896 @DaanHoogland Thanks for the explanations! This is an automated message f

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159629937 ## File path: engine/storage/src/org/apache/cloudstack/storage/image/db/TemplateData

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159627119 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630596 ## File path: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorag

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630513 ## File path: plugins/hypervisors/ovm3/src/main/java/com/cloud/hypervisor/ovm3/resou

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159628779 ## File path: engine/orchestration/pom.xml ## @@ -58,13 +58,13 @@ cl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630141 ## File path: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeS

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159627375 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630192 ## File path: framework/direct-download/src/org/apache/cloudstack/framework/agent/di

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630215 ## File path: framework/direct-download/src/org/apache/cloudstack/framework/agent/di

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159627184 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159628344 ## File path: agent/src/com/cloud/agent/direct/download/NfsDirectTemplateDownloader.

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159628986 ## File path: engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateD

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630971 ## File path: server/src/com/cloud/template/HypervisorTemplateAdapter.java #

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159627317 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159628963 ## File path: engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateD

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159627202 ## File path: agent/src/com/cloud/agent/direct/download/DirectTemplateDownloaderImpl

[GitHub] rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates

rafaelweingartner commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary Storage for KVM templates URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159630681 ## File path: server/src/com/cloud/resource/ResourceManagerImpl.java ## @@

[GitHub] DaanHoogland commented on a change in pull request #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

DaanHoogland commented on a change in pull request #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option? URL: https://github.com/apache/cloudstack/pull/2377#discussion_r159629699 ## File path: server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java ###

[GitHub] DaanHoogland commented on a change in pull request #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option?

DaanHoogland commented on a change in pull request #2377: CLOUDSTACK-10207: updateVpnCustomerGateway: fix defaulting for option? URL: https://github.com/apache/cloudstack/pull/2377#discussion_r159630403 ## File path: server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java ###

[GitHub] blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check

blueorangutan commented on issue #2376: [4.11/master] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-355261169 Packaging result: ?centos6 ?centos7 ?debian. JID-1577 This is an automated

[GitHub] rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile

rhtyd commented on issue #2384: CLOUDSTACK-10210 cleanup testfile URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355262768 Merging this based on code lgtms and Travis job1 (which run unit tests) test result.

[cloudstack] branch master updated: CLOUDSTACK-10210: cleanup testfile (#2384)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new dd21f68 CLOUDSTACK-10210: cleanup testfile (

  1   2   3   >