[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

blueorangutan commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-404912938 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2172 This is an automated message from the

[GitHub] blueorangutan commented on issue #2613: Cleanup POMs

blueorangutan commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-404904385 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2613: Cleanup POMs

rhtyd commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-404904342 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] smeetsr opened a new pull request #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset

smeetsr opened a new pull request #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset URL: https://github.com/apache/cloudstack/pull/2743 ## Description * When password reset is called, and VR accepts it, set vm updateParameters to false. * When password reset

[GitHub] khos2ow commented on issue #2613: Cleanup POMs

khos2ow commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-404858588 @rhtyd rebased. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202358111 ## File path: test/integration/smoke/test_async_job.py ## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation

[GitHub] rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime

rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202353309 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2734: Fix invalid consoleproxy url after upgrade

rafaelweingartner commented on a change in pull request #2734: Fix invalid consoleproxy url after upgrade URL: https://github.com/apache/cloudstack/pull/2734#discussion_r202344815 ## File path: core/src/com/cloud/info/ConsoleProxyInfo.java ## @@ -35,38 +35,40 @@ public

[GitHub] DaanHoogland commented on a change in pull request #2739: Async jobs add endtime

DaanHoogland commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202342570 ## File path: test/integration/smoke/test_async_job.py ## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software

[GitHub] DaanHoogland commented on a change in pull request #2739: Async jobs add endtime

DaanHoogland commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202339018 ## File path: server/src/test/java/com/cloud/storage/dao/AsyncJobJoinDaoTest.java ## @@ -0,0 +1,89 @@ +/* + * Licensed

[GitHub] DaanHoogland commented on a change in pull request #2739: Async jobs add endtime

DaanHoogland commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202337269 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ## @@

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202335074 ## File path: test/integration/smoke/test_async_job.py ## @@ -0,0 +1,139 @@ +""" +Integration Test +""" +# Licensed to the

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202329269 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ## @@ -1049,8

[GitHub] ernjvr commented on issue #2739: Async jobs add endtime

ernjvr commented on issue #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#issuecomment-404818065 @dhlaluku please review. This is an automated message from the Apache Git Service. To respond

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202329269 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ## @@ -1049,8

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202326838 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ## @@

[GitHub] ernjvr commented on a change in pull request #2739: Async jobs add endtime

ernjvr commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202325643 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41110to41200.sql ## @@ -32,4 +32,6 @@ ALTER TABLE `vlan`

[GitHub] rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime

rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202324106 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ##

[GitHub] rhtyd commented on issue #2721: api: Introducing a new diagnostics API command for system VMs for CloudStack admins

rhtyd commented on issue #2721: api: Introducing a new diagnostics API command for system VMs for CloudStack admins URL: https://github.com/apache/cloudstack/pull/2721#issuecomment-404806007 Merging this based on code reviews and testing. The failures are not related to this PR.

[GitHub] rhtyd commented on a change in pull request #2739: Async jobs add endtime

rhtyd commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202321858 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ## @@ -1049,8

[cloudstack] branch master updated: diagnostics: new diagnostics admin API for system VMs (#2721)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 40af32b diagnostics: new diagnostics admin

[GitHub] rhtyd closed pull request #2721: api: Introducing a new diagnostics API command for system VMs for CloudStack admins

rhtyd closed pull request #2721: api: Introducing a new diagnostics API command for system VMs for CloudStack admins URL: https://github.com/apache/cloudstack/pull/2721 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS)

rafaelweingartner commented on issue #2524: [CLOUDSTACK-9261] Upgrate jQuery-UI to 1.11 (JQuery UI 1.8.4 prone to XSS) URL: https://github.com/apache/cloudstack/pull/2524#issuecomment-404806324 @GabrielBrascher did you approve the PR? I think everything is fine to merge then

[GitHub] rafaelweingartner commented on issue #2703: Fix concurrency problem when moving ACL rules with drag

rafaelweingartner commented on issue #2703: Fix concurrency problem when moving ACL rules with drag URL: https://github.com/apache/cloudstack/pull/2703#issuecomment-404805765 @borisstoyanov do you know why the packaging failed?

[GitHub] rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime

rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202319599 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ##

[GitHub] rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime

rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202319051 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41110to41200.sql ## @@ -32,4 +32,6 @@ ALTER

[GitHub] rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime

rafaelweingartner commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202319718 ## File path: framework/jobs/src/main/java/org/apache/cloudstack/framework/jobs/impl/AsyncJobManagerImpl.java ##

[GitHub] rhtyd commented on issue #2709: check volumes for state when retrieving pool for configDrive creation

rhtyd commented on issue #2709: check volumes for state when retrieving pool for configDrive creation URL: https://github.com/apache/cloudstack/pull/2709#issuecomment-404805584 @borisstoyanov can you advise if it's passing manual config drive testing, wrt primary+secondary storage for

[cloudstack] branch master updated: travis: Enhance Travis to do packaging jobs on different stage (#2640)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 07042a6 travis: Enhance Travis to do

[GitHub] rhtyd closed pull request #2640: Enhance Travis to do packaging job

rhtyd closed pull request #2640: Enhance Travis to do packaging job URL: https://github.com/apache/cloudstack/pull/2640 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] rhtyd commented on issue #2613: Cleanup POMs

rhtyd commented on issue #2613: Cleanup POMs URL: https://github.com/apache/cloudstack/pull/2613#issuecomment-404804666 @khos2ow can you rebase against latest master and fix conflicts? This is an automated message from the

[GitHub] rhtyd closed pull request #2649: Catch error in Debian packaging script and fail the build

rhtyd closed pull request #2649: Catch error in Debian packaging script and fail the build URL: https://github.com/apache/cloudstack/pull/2649 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[cloudstack] branch master updated: packaging: Catch error in packaging script and fail the build (#2649)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 4a5fab0 packaging: Catch error in packaging

[GitHub] rhtyd commented on issue #2734: Fix invalid consoleproxy url after upgrade

rhtyd commented on issue #2734: Fix invalid consoleproxy url after upgrade URL: https://github.com/apache/cloudstack/pull/2734#issuecomment-404803960 Regression test LGTM, I did not test it manually though. @borisstoyanov if you've time next week, can you test and advise? Thanks.

[GitHub] rhtyd commented on a change in pull request #2739: Async jobs add endtime

rhtyd commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202318311 ## File path: test/integration/smoke/test_async_job.py ## @@ -0,0 +1,139 @@ +""" +Integration Test +""" +# Licensed to the

[GitHub] rhtyd commented on a change in pull request #2739: Async jobs add endtime

rhtyd commented on a change in pull request #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#discussion_r202318228 ## File path: test/integration/smoke/test_async_job.py ## @@ -0,0 +1,139 @@ +""" Review comment: Fix comment, remove

[GitHub] ernjvr commented on issue #2739: Async jobs add endtime

ernjvr commented on issue #2739: Async jobs add endtime URL: https://github.com/apache/cloudstack/pull/2739#issuecomment-404753768 @rhtyd @DaanHoogland please review. This is an automated message from the Apache Git Service.