[GitHub] rhtyd commented on issue #2892: vr: memory and swap optimizations

2018-10-11 Thread GitBox
rhtyd commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429213279 Update: made another change to limit systemd-journald usage. By default, the journald can consume upto 4GBs depending on size of partition etc. This

[GitHub] rhtyd commented on issue #2642: DB Exceptions seen on latest master

2018-10-11 Thread GitBox
rhtyd commented on issue #2642: DB Exceptions seen on latest master URL: https://github.com/apache/cloudstack/issues/2642#issuecomment-429208863 The fix is to identify which part of the code is trying to call a commit() when it's not in a transaction, likely an update could have been

[GitHub] rafaelweingartner edited a comment on issue #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rafaelweingartner edited a comment on issue #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#issuecomment-429130900 ow really? So, what if you change the "set" method of that property to remove the "apiRateService" from

[GitHub] rafaelweingartner commented on issue #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rafaelweingartner commented on issue #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#issuecomment-429130900 ow really? So, what if you change the "set" method of that property to remove the "apiRateService" from the list

[GitHub] csquire commented on issue #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on issue #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#issuecomment-429117688 I took a look at your suggestion @rafaelweingartner but those beans cannot be referenced directly in this context.

[GitHub] PaulAngus commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests…

2018-10-11 Thread GitBox
PaulAngus commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests… URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-429066327 in theory i agree @borisstoyanov - the problem there is how do you define fundamental. and given how

[GitHub] csquire commented on issue #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on issue #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#issuecomment-429041583 yeah, great idea, that looks like a good solution. I'll update the PR.

[GitHub] rafaelweingartner commented on issue #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rafaelweingartner commented on issue #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#issuecomment-429033087 @csquire, from your PR description I understood that we should not need/use the API rate limit service. Therefore,

[GitHub] rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224513928 ## File path:

[GitHub] csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224445187 ## File path:

[GitHub] rhtyd commented on issue #2862: VR stop/start/reboot commands failed

2018-10-11 Thread GitBox
rhtyd commented on issue #2862: VR stop/start/reboot commands failed URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-428940461 @resmo we'll need the /var/log/cloud.log from the VR when this happens as well as the management server logs when you reproduce the next time.

[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations

2018-10-11 Thread GitBox
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428925519 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2341 This is an automated

[GitHub] rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rafaelweingartner commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224415641 ## File path:

[GitHub] csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224413925 ## File path:

[GitHub] csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224413479 ## File path:

[GitHub] csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
csquire commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224413479 ## File path:

[GitHub] rafaelweingartner commented on a change in pull request #2892: vr: memory and swap optimizations

2018-10-11 Thread GitBox
rafaelweingartner commented on a change in pull request #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#discussion_r224413193 ## File path: systemvm/debian/etc/sysctl.conf ## @@ -60,3 +60,6 @@ net.ipv6.conf.all.forwarding = 0

[GitHub] blueorangutan commented on issue #2892: vr: memory and swap optimizations

2018-10-11 Thread GitBox
blueorangutan commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428918408 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2892: vr: memory and swap optimizations

2018-10-11 Thread GitBox
rhtyd commented on issue #2892: vr: memory and swap optimizations URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428918147 @wido @resmo please see the additional commit around baremetal-vr @blueorangutan package

[GitHub] rhtyd commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
rhtyd commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428915438 I checked https://cwiki.apache.org/confluence/display/CLOUDSTACK/Baremetal+Advanced+Networking+Support, we don't need to run baremetal-vr

[GitHub] rhtyd commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
rhtyd commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428901397 @wido the `kernel.panic = 10` is already set to reboot VR faster on panic (10s). @resmo we already have VR process monitoring service in

[GitHub] izenk opened a new issue #2895: ssh-keys instances ERROR

2018-10-11 Thread GitBox
izenk opened a new issue #2895: ssh-keys instances ERROR URL: https://github.com/apache/cloudstack/issues/2895 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.11.1 ~~~ #

[GitHub] borisstoyanov edited a comment on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests…

2018-10-11 Thread GitBox
borisstoyanov edited a comment on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests… URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-428893141 I've just rebased @rhtyd, a full smoketest would take day+ and this label gives you a real quick

[GitHub] wido commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
wido commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428895711 @resmo But then probably also set: kernel.panic = 60 In that case the kernel also reboots the system after 60 seconds in case of

[GitHub] rhtyd commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rhtyd commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224387457 ## File path: plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java

[GitHub] rhtyd commented on a change in pull request #2894: api: don't throttle api discovery for listApis command

2018-10-11 Thread GitBox
rhtyd commented on a change in pull request #2894: api: don't throttle api discovery for listApis command URL: https://github.com/apache/cloudstack/pull/2894#discussion_r224387400 ## File path: plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java

[GitHub] blueorangutan commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
blueorangutan commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428895180 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2340 This is an

[GitHub] dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM

2018-10-11 Thread GitBox
dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM URL: https://github.com/apache/cloudstack/pull/2839#discussion_r224384777 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -514,6 +515,8 @@ private static

[GitHub] borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests…

2018-10-11 Thread GitBox
borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests… URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-428893141 I've just rebased @rhtyd, a full smoketest would take day+ and this label gives you a real quick

[GitHub] dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM

2018-10-11 Thread GitBox
dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM URL: https://github.com/apache/cloudstack/pull/2839#discussion_r224384777 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -514,6 +515,8 @@ private static

[GitHub] dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM

2018-10-11 Thread GitBox
dhlaluku commented on a change in pull request #2839: Enable DPDK support on KVM URL: https://github.com/apache/cloudstack/pull/2839#discussion_r224384777 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -514,6 +515,8 @@ private static

[GitHub] rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests…

2018-10-11 Thread GitBox
rhtyd commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests… URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-42452 I must share that as a developer I don't see any value in this, as for any change I would do I would run a full

[GitHub] resmo commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
resmo commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-42299 LGTM I would also consider to change vm.panic_on_oom to reboot the VR on oom regardless. ~~~diff - vm.panic_on_oom = 1 +

[GitHub] rhtyd commented on a change in pull request #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
rhtyd commented on a change in pull request #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#discussion_r224376437 ## File path: systemvm/debian/etc/sysctl.conf ## @@ -60,3 +60,6 @@ net.ipv6.conf.all.forwarding = 0

[GitHub] blueorangutan commented on issue #2892: sysctl: don't use swap until last resort

2018-10-11 Thread GitBox
blueorangutan commented on issue #2892: sysctl: don't use swap until last resort URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428884713 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] rhtyd commented on issue #2892: sysctl: don't use swap until ram reaches 95% usage

2018-10-11 Thread GitBox
rhtyd commented on issue #2892: sysctl: don't use swap until ram reaches 95% usage URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-428884271 @blueorangutan package This is an automated message from the

[GitHub] borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests…

2018-10-11 Thread GitBox
borisstoyanov commented on issue #2209: CLOUDSTACK-10017: Adding 'quick-test' attribute to list of smoketests… URL: https://github.com/apache/cloudstack/pull/2209#issuecomment-428865526 ping @rhtyd @nvazquez @PaulAngus @ernjvr @DaanHoogland @dhlaluku and other for review