pyr commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430110907
@rhtyd nope, this is unrelated to #2893, signature version 3 parameters are
already logged
blueorangutan commented on issue #2902: Add checksum sanity validation on
template registration
URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430107618
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
blueorangutan commented on issue #2893: ApiServer: signature v3 to accept more
formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430107436
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2893: ApiServer: signature v3 to accept more formats
URL: https://github.com/apache/cloudstack/pull/2893#issuecomment-430107386
@blueorangutan package
This is an automated message from the
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for
CloudStack Agent
URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430106926
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2897: Allow enable the Java remote Debug for
CloudStack Agent
URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-430106798
@blueorangutan package
This is an automated message
blueorangutan commented on issue #2902: Add checksum sanity validation on
template registration
URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430105995
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2345
rhtyd commented on issue #2887: NumberFormatException when adding a VM to VPC
tier
URL: https://github.com/apache/cloudstack/issues/2887#issuecomment-430105676
I'm unable to reproduce this @borisstoyanov looks like due to other
env/network issue, the ssh to the VR failed that caused
rhtyd closed issue #2873: VR seen to have memory leaks
URL: https://github.com/apache/cloudstack/issues/2873
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
rhtyd commented on issue #2873: VR seen to have memory leaks
URL: https://github.com/apache/cloudstack/issues/2873#issuecomment-430105227
https://github.com/apache/cloudstack/pull/2892 attempts to remedy this, so
closing.
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 84994c841f12f13341d6537f2ae6b41c5d08d20b
Merge: 272167c 11d83fa
Author: Rohit Yadav
AuthorDate: Tue Oct 16 10:54:39
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from 272167c merge forward #2876 -- PULL_REQUEST_TEMPLATE simplification
add 933ee23 vr: memory and swap
blueorangutan commented on issue #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430104904
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been
kicked to run smoke tests
rhtyd commented on issue #2900: network: Allow ability to disable rolling
restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430104822
@blueorangutan test centos7 vmware-55u3
This is an
rhtyd commented on issue #2862: VR stop/start/reboot commands failed
URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-430104678
Unless, VR logs may be available we're unable to investigate and fix this
problem @izenk @resmo thanks.
rhtyd commented on issue #2880: [4.11.2]: rolling upgrade of VR results in
duplicate VRs
URL: https://github.com/apache/cloudstack/issues/2880#issuecomment-430104566
Moved this to 4.11.3.0/future milestone as this with
https://github.com/apache/cloudstack/pull/2900 admin can opt for
rhtyd commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-430101841
is this the PR https://github.com/apache/cloudstack/pull/2893 in question
@pyr ? If so, let's review and merge
blueorangutan commented on issue #2902: Add checksum sanity validation on
template registration
URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430101716
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 11d83fa agent: set log level to INFO as default
rhtyd commented on issue #2902: Add checksum sanity validation on template
registration
URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-430101663
@blueorangutan package
This is an automated message from the
rhtyd closed pull request #2903: Set http level to INFO as default
URL: https://github.com/apache/cloudstack/pull/2903
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
rhtyd commented on issue #2903: Set http level to INFO as default
URL: https://github.com/apache/cloudstack/pull/2903#issuecomment-430101437
No explicit tests needed as changes are purely in log4j file, merging based
on code reviews and travis results.
This is an automated email from the ASF dual-hosted git repository.
rohit pushed a commit to branch 4.11
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/4.11 by this push:
new 933ee23 vr: memory and swap optimizations
rhtyd closed pull request #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
rhtyd commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-430101076
Based on several days of testing, and reviews and tests I'll merge this. I
found that the VR no longer swaps until the last resort and the overall
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225397031
##
File path:
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225397031
##
File path:
blueorangutan commented on issue #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-430010789
Trillian test result (tid-3074)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total
nvazquez commented on issue #2902: Add checksum sanity validation on template
registration
URL: https://github.com/apache/cloudstack/pull/2902#issuecomment-429994726
Done, thanks @rafaelweingartner for reviewing
This is an
blueorangutan commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429985110
Trillian test result (tid-3073)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25636 seconds
rafaelweingartner commented on issue #2593: api: move default response from XML
to JSON
URL: https://github.com/apache/cloudstack/pull/2593#issuecomment-429967648
As we discussed in CCC Montreal, this would fit our requirements for
breaking changes.
This is an automated email from the ASF dual-hosted git repository.
rafael pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
from ebc6b2f Remove push force test file
add 63f4d85 PULL_REQUEST_TEMPLATE: simplify and remove unpopular
This is an automated email from the ASF dual-hosted git repository.
rafael pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit 272167c3b3d486a97bda43c5af204f5432d645bf
Merge: ebc6b2f 63f4d85
Author: Rafael Weingärtner
AuthorDate: Mon Oct 15
rafaelweingartner closed pull request #2876: PULL_REQUEST_TEMPLATE: simplify
and remove unpopular sections
URL: https://github.com/apache/cloudstack/pull/2876
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
rafaelweingartner commented on a change in pull request #2894: api: don't
throttle api discovery for listApis command
URL: https://github.com/apache/cloudstack/pull/2894#discussion_r225265945
##
File path: api/src/org/apache/cloudstack/acl/APIAclChecker.java
##
@@ -0,0
rafaelweingartner edited a comment on issue #2901: params: allow
signatureversion and expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853434
Two positive feedbacks and successful functional tests executed
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225188724
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225191153
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225188724
##
File path:
utils/src/main/java/org/apache/cloudstack/utils/security/DigestHelper.java
rafaelweingartner commented on a change in pull request #2902: Add checksum
sanity validation on template registration
URL: https://github.com/apache/cloudstack/pull/2902#discussion_r225191329
##
File path:
nvazquez opened a new pull request #2903: Set http level to INFO as default
URL: https://github.com/apache/cloudstack/pull/2903
## Description
Avoid logging bytes on direct download on KVM
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
nvazquez opened a new pull request #2902: Add checksum sanity validation on
template registration
URL: https://github.com/apache/cloudstack/pull/2902
## Description
Add a checksum sanity check on template/ISO registration for direct
downloads on KVM.
Assert that:
- Algorithm is
pyr commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853159
@rafaelweingartner provided I find where to push again, how many approvals
should I wait for before merging? (it's been a
rafaelweingartner commented on issue #2901: params: allow signatureversion and
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429853434
2
This is an automated message from the Apache
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156698
##
File path:
framework/cluster/src/main/java/com/cloud/cluster/ClusterFenceManagerImpl.java
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156622
##
File path: framework/cluster/pom.xml
##
@@ -47,8 +47,7 @@
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156841
##
File path:
framework/cluster/src/main/java/com/cloud/cluster/ClusterManagerListener.java
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156473
##
File path:
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41120to41200.java
##
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225156748
##
File path:
framework/cluster/src/main/java/com/cloud/cluster/ClusterManager.java
##
@@
rafaelweingartner commented on a change in pull request #2578: api: add command
to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#discussion_r225157204
##
File path: engine/schema/src/main/resources/META-INF/db/schema-41120to41200.sql
##
@@
pyr commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429844477
@rafaelweingartner I did not introduce the new parameters, they were
introduced as part of the Signature version 3 scheme in
rafaelweingartner commented on issue #2901: params: allow signatureversion and
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429843518
You are saying that these parameters are always logged as not valid ones.
Therefore, I was assuming that they
rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225154560
##
File path:
rafaelweingartner commented on a change in pull request #2900: network: Allow
ability to disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225154560
##
File path:
pyr commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429842236
I'm not sure I understand the Jenkins failure but it seems unrelated to this
PR
pyr commented on issue #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429841713
@rafaelweingartner which other PR are you referring to?
This
rafaelweingartner commented on issue #2901: params: allow signatureversion and
expires without logging
URL: https://github.com/apache/cloudstack/pull/2901#issuecomment-429841375
Has your other PR been merged already?
This is
pyr opened a new pull request #2901: params: allow signatureversion and expires
without logging
URL: https://github.com/apache/cloudstack/pull/2901
## Description
This patch considers the new expires and signatureversion parameters
valid. Without this, all calls log when
blueorangutan commented on issue #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429822471
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
blueorangutan commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429822462
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been
kicked to run smoke tests
rhtyd commented on issue #2900: network: Allow ability to disable rolling
restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429822249
@blueorangutan test
This is an automated message from the
rhtyd commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429822296
@blueorangutan test
This is an automated message from the Apache Git Service.
To
blueorangutan commented on issue #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429810940
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2344
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for
CloudStack Agent
URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429802877
Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2342
blueorangutan commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429802878
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2343
This is an automated
blueorangutan commented on issue #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429802125
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2900: network: Allow ability to disable rolling
restart feature
URL: https://github.com/apache/cloudstack/pull/2900#issuecomment-429801851
@borisstoyanov can you help test this one (manually maybe, both cases for
restart with/without cleanup with/without
rhtyd commented on a change in pull request #2900: network: Allow ability to
disable rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900#discussion_r225119494
##
File path:
rhtyd opened a new pull request #2900: network: Allow ability to disable
rolling restart feature
URL: https://github.com/apache/cloudstack/pull/2900
This adds a global setting for admins who may want the lebacy behaviour of
network restart with cleanup=true. In future, this setting may be
rhtyd commented on issue #2862: VR stop/start/reboot commands failed
URL: https://github.com/apache/cloudstack/issues/2862#issuecomment-429800381
@resmo we'll need additional logs from an env/VRs where you're seeing the
error to debug/investigate and fix this issue.
blueorangutan commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429789707
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2892: vr: memory and swap optimizations
URL: https://github.com/apache/cloudstack/pull/2892#issuecomment-429789496
Rebased against latest 4.11 and fixed review issues.
@blueorangutan package
This
blueorangutan commented on issue #2897: Allow enable the Java remote Debug for
CloudStack Agent
URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429780675
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted
as I make progress.
rhtyd commented on issue #2897: Allow enable the Java remote Debug for
CloudStack Agent
URL: https://github.com/apache/cloudstack/pull/2897#issuecomment-429780361
@blueorangutan package
This is an automated message from the
rhtyd commented on issue #2578: api: add command to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429757210
Looks great @marcaurele I'm busy this week with some outstanding issues wrt
4.11.2 release. I'll review this after that. Thanks.
marcaurele commented on issue #2898: docker: add compose file for database
URL: https://github.com/apache/cloudstack/pull/2898#issuecomment-429756453
I perform my local development with that docker setup and thought I could
share it to see if it can help others. Don't hesitate to close it
rhtyd opened a new issue #2899: Initial agent connect dropped by management
server
URL: https://github.com/apache/cloudstack/issues/2899
It is observed in 4.11.1/2-rc2 that in some environments when KVM agent
connects to the management server, the channel is closed just after initial
marcaurele opened a new pull request #2898: docker: add compose file for
database
URL: https://github.com/apache/cloudstack/pull/2898
## Description
A docker-compose file to setup quickly the database for CS. This helps
during local development and remove the need to install a local
marcaurele commented on issue #2578: api: add command to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429753971
The PR is ready now. Conflicts are fixed, WUI is updated with a new block
for management servers with a simple detail view. cc @rhtyd
marcaurele commented on issue #2578: api: add command to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429748052
```
› cs listManagementServers --region=dev:admin
{
"count": 3,
"managementserver": [
{
"id":
marcaurele commented on issue #2578: api: add command to list management servers
URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-429747225
Getting better, detail view is ready too
