[GitHub] blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447181905 Trillian test result (tid-3255) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time ta

[GitHub] rafaelweingartner commented on a change in pull request #3069: Update jquery and related libraries

2018-12-13 Thread GitBox
rafaelweingartner commented on a change in pull request #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#discussion_r241521212 ## File path: ui/index.html ## @@ -102,7 +102,7 @@

[GitHub] GabrielBrascher commented on a change in pull request #3091: Address reviewers from abandoned PR #1597.

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #3091: Address reviewers from abandoned PR #1597. URL: https://github.com/apache/cloudstack/pull/3091#discussion_r241504656 ## File path: services/console-proxy/server/src/main/java/com/cloud/consoleproxy/ConsoleProxyHttpHandler

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241504968 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/reso

[GitHub] blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447053103 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] nvazquez commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
nvazquez commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447052766 @blueorangutan test This is an automated message from the Ap

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241477036 ## File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/stora

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241473323 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/reso

[GitHub] GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on issue #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#issuecomment-447034982 Thanks for the feedback, @rhtyd, @DaanHoogland, @nvazquez, @wido, @rafaelweingartner, @mike-tutkowski! Tril

[GitHub] svenvogel commented on issue #3069: Update jquery and related libraries

2018-12-13 Thread GitBox
svenvogel commented on issue #3069: Update jquery and related libraries URL: https://github.com/apache/cloudstack/pull/3069#issuecomment-447032097 @rhtyd @borisstoyanov other test or can we merge it? This is an automated messa

[GitHub] blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447030177 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2490 T

[GitHub] blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
blueorangutan commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447022625 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] nvazquez commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
nvazquez commented on issue #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095#issuecomment-447022373 @blueorangutan package This is an automated message from the

[GitHub] nvazquez opened a new pull request #3095: Prevent corner case for infinite PrepareForMaintenance

2018-12-13 Thread GitBox
nvazquez opened a new pull request #3095: Prevent corner case for infinite PrepareForMaintenance URL: https://github.com/apache/cloudstack/pull/3095 ## Description A corner case was found on 4.11.2 for #2493 leading to an infinite loop in state `PrepareForMaintenance` To prevent

[GitHub] rhtyd commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
rhtyd commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241457470 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/Migra

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241456219 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/reso

[GitHub] GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type

2018-12-13 Thread GitBox
GabrielBrascher commented on a change in pull request #2997: Allow KVM VM live migration with ROOT volume on file storage type URL: https://github.com/apache/cloudstack/pull/2997#discussion_r241391348 ## File path: engine/storage/datamotion/src/main/java/org/apache/cloudstack/stora

[GitHub] andrijapanic commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support

2018-12-13 Thread GitBox
andrijapanic commented on issue #3070: kvm: Refactory VXLAN script and add IPv6 support URL: https://github.com/apache/cloudstack/pull/3070#issuecomment-446900017 Need some time here, but will check. This is an automated mess