[GitHub] [cloudstack] GabrielBrascher opened a new pull request #3280: Remove code that generated /var/lib/libvirt/images/null on target host

2019-04-17 Thread GitBox
GabrielBrascher opened a new pull request #3280: Remove code that generated /var/lib/libvirt/images/null on target host URL: https://github.com/apache/cloudstack/pull/3280 ## Description This commit simplifies the `generateDestPath` method and fixes an issue where an extra file,

[GitHub] [cloudstack] blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-04-17 Thread GitBox
blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-484188304 Trillian test result (tid-3498) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt s

[GitHub] [cloudstack] skattoju4 commented on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state

2019-04-17 Thread GitBox
skattoju4 commented on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state URL: https://github.com/apache/cloudstack/pull/3279#issuecomment-484184541 @syed could you take a look ? This is an auto

[GitHub] [cloudstack] svenvogel edited a comment on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state

2019-04-17 Thread GitBox
svenvogel edited a comment on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state URL: https://github.com/apache/cloudstack/pull/3279#issuecomment-484178711 @skattoju3 thanks for that! We will test it tomorrow.

[GitHub] [cloudstack] svenvogel commented on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state

2019-04-17 Thread GitBox
svenvogel commented on issue #3279: WIP: Skip getting used bytes for volumes that are not in Ready state URL: https://github.com/apache/cloudstack/pull/3279#issuecomment-484178711 @skattju3 thanks for that! We will test it tomorrow.

[GitHub] [cloudstack] skattoju4 opened a new pull request #3279: WIP: Skip getting used bytes for volumes that are not in Ready state

2019-04-17 Thread GitBox
skattoju4 opened a new pull request #3279: WIP: Skip getting used bytes for volumes that are not in Ready state URL: https://github.com/apache/cloudstack/pull/3279 ## Description Slow VM creation times are experienced when using solid fire managed storage. It is suspected that this is c

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-04-17 Thread GitBox
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-484150216 Trillian test result (tid-3497) Environment: kvm-centos

[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-04-17 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-484117369 The root cause seems to be that the interfaces (eth1, eth2, eth3) share the same mac address. I'm not really sure where

[GitHub] [cloudstack] blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-484090214 Trillian test result (tid-3499) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[GitHub] [cloudstack] kioie commented on issue #2842: listApis command returns inconsistent results

2019-04-17 Thread GitBox
kioie commented on issue #2842: listApis command returns inconsistent results URL: https://github.com/apache/cloudstack/issues/2842#issuecomment-484067092 Seems like this issue should be closed. This is an automated message fr

[GitHub] [cloudstack] blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484064075 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2707

[GitHub] [cloudstack] pdion891 commented on issue #3138: StrongSwan with several rightsubnet's - ikev1

2019-04-17 Thread GitBox
pdion891 commented on issue #3138: StrongSwan with several rightsubnet's - ikev1 URL: https://github.com/apache/cloudstack/issues/3138#issuecomment-484060499 We need to review on our side, but report look pretty accurate @andrijapanic ! -

[GitHub] [cloudstack] blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484057985 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
rhtyd commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484057661 @blueorangutan package This is an automated m

[GitHub] [cloudstack] blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484054542 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2706

[GitHub] [cloudstack] svenvogel edited a comment on issue #3183: Improvements after jquery update

2019-04-17 Thread GitBox
svenvogel edited a comment on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-484050639 > > @svenvogel in your last reply you hinted that you're creating a new UI library? Can you elaborate, is it already part of this PR? >

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-04-17 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-484050639 @DennisKonrad i wrote that already above This is an automated message from the Apa

[GitHub] [cloudstack] rhtyd commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
rhtyd commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484048763 @blueorangutan package This is an automated m

[GitHub] [cloudstack] blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
blueorangutan commented on issue #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-484048838 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] rhtyd opened a new pull request #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM

2019-04-17 Thread GitBox
rhtyd opened a new pull request #3278: [DO NOT MERGE WIP] systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278 It was reported that systemvm patching broke with qemu-ev 2.12, this fixes for that reported issue: This introduces a n

[GitHub] [cloudstack] DennisKonrad commented on issue #3183: Improvements after jquery update

2019-04-17 Thread GitBox
DennisKonrad commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-484043911 > @svenvogel in your last reply you hinted that you're creating a new UI library? Can you elaborate, is it already part of this PR? No ne

[GitHub] [cloudstack] DennisKonrad commented on issue #3183: Improvements after jquery update

2019-04-17 Thread GitBox
DennisKonrad commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-484043224 We are using this for weeks now and the library update works just fine. LGTM @rhtyd Nearly all of the UI fixes here are not caused by the

[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3277: Marvin can't read config file

2019-04-17 Thread GitBox
ustcweizhou edited a comment on issue #3277: Marvin can't read config file URL: https://github.com/apache/cloudstack/issues/3277#issuecomment-484040687 I run the commands below and it succeed ``` wget -N https://builds.apache.org/job/cloudstack-marvin/lastSuccessfulBuild/artifact/tool

[GitHub] [cloudstack] ustcweizhou commented on issue #3277: Marvin can't read config file

2019-04-17 Thread GitBox
ustcweizhou commented on issue #3277: Marvin can't read config file URL: https://github.com/apache/cloudstack/issues/3277#issuecomment-484040687 I run the commands below and it succeed ``` wget -N https://builds.apache.org/job/cloudstack-marvin/lastSuccessfulBuild/artifact/tools/marvi

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
anuragaw commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276183004 ## File path: api/src/com/cloud/storage/Volume.java ## @@ -52,7 +52,8 @@

[GitHub] [cloudstack] rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-17 Thread GitBox
rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-484031952 The feature of uploading a volume/template and with this PR iso requires that the env has ssl/tls certificates setup. The failure to uplo

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
anuragaw commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276173055 ## File path: api/src/com/cloud/storage/Volume.java ## @@ -52,7 +52,8 @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276172617 ## File path: test/integration/smoke/test_volumes.py ## @@ -857,6 +857,60 @

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276172325 ## File path: api/src/com/cloud/storage/Volume.java ## @@ -119,9 +120,12 @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276172133 ## File path: api/src/com/cloud/storage/Volume.java ## @@ -52,7 +52,8 @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276171842 ## File path: server/src/com/cloud/storage/VolumeApiServiceImpl.java ## @@

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
rhtyd commented on a change in pull request #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#discussion_r276170754 ## File path: api/src/com/cloud/storage/Volume.java ## @@ -52,7 +52,8 @@

[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics

2019-04-17 Thread GitBox
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-484022647 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2705

[GitHub] [cloudstack] anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#issuecomment-484016868 > @anuragaw can you implement a marvin test for the test-case. Done @rhtyd , let me know if this cove

[GitHub] [cloudstack] anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#issuecomment-484016698 @blueorangutan test This is an automat

[GitHub] [cloudstack] blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics

2019-04-17 Thread GitBox
blueorangutan commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-484016161 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progres

[GitHub] [cloudstack] borisstoyanov commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics

2019-04-17 Thread GitBox
borisstoyanov commented on issue #3259: [WIP DO NOT MERGE] server: export granular volume bytes and iops metrics URL: https://github.com/apache/cloudstack/pull/3259#issuecomment-484015848 @blueorangutan package This is an aut

[GitHub] [cloudstack] blueorangutan commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
blueorangutan commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#issuecomment-484013683 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2704

[GitHub] [cloudstack] svenvogel commented on issue #3183: Improvements after jquery update

2019-04-17 Thread GitBox
svenvogel commented on issue #3183: Improvements after jquery update URL: https://github.com/apache/cloudstack/pull/3183#issuecomment-484011690 @rhtyd Hi Rohit, yes the the library are always included in cloudstack because they are a part of JQuery UI. we took a upgrade for any month #3069.

[GitHub] [cloudstack] blueorangutan commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
blueorangutan commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#issuecomment-484006392 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state

2019-04-17 Thread GitBox
anuragaw commented on issue #3276: [DO NOT MERGE WIP] Add more states for attaching disk in allocated state URL: https://github.com/apache/cloudstack/pull/3276#issuecomment-484005971 @blueorangutan package This is an auto

[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-04-17 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-483998833 I found some more time looking into this. @ustcweizhou Do you also think the problem originates in https://github.com/

[GitHub] [cloudstack] pbankonier commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
pbankonier commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483994199 @DaanHoogland I'm currently working on a optimization here. I found that it is not needed to pass the uniquen

[GitHub] [cloudstack] rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-17 Thread GitBox
rhtyd commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-483986497 @anuragaw I would prefer something like "Failed to upload {iso/template} due to system configuration please contact your administrator."

[GitHub] [cloudstack] blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483985942 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483985748 @blueorangutan test This is an automated m

[GitHub] [cloudstack] anuragaw commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI

2019-04-17 Thread GitBox
anuragaw commented on issue #3251: [WIP DO NOT MERGE] Add local ISO upload via UI URL: https://github.com/apache/cloudstack/pull/3251#issuecomment-483985401 Verified @borisstoyanov observation that when create button is clicked for templates or ISOs an entry is created in database and even

[GitHub] [cloudstack] blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483983548 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2703

[GitHub] [cloudstack] DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483979219 @pbankonier as this is marked WIP, what is still to be done for it? ---

[GitHub] [cloudstack] blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
blueorangutan commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483976719 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui

2019-04-17 Thread GitBox
DaanHoogland commented on issue #3198: [WIP DO NOT MERGE] Set service offering unique name over api and gui URL: https://github.com/apache/cloudstack/pull/3198#issuecomment-483976510 @blueorangutan package This is an automate

[GitHub] [cloudstack] borisstoyanov commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-04-17 Thread GitBox
borisstoyanov commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-483974859 @blueorangutan test This is an

[GitHub] [cloudstack] blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints

2019-04-17 Thread GitBox
blueorangutan commented on issue #3245: [WIP DO NOT MERGE] server: allows compute offering with or without constraints URL: https://github.com/apache/cloudstack/pull/3245#issuecomment-483974961 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run s

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-04-17 Thread GitBox
blueorangutan commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-483970350 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt +

[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-04-17 Thread GitBox
borisstoyanov commented on issue #3271: [WIP DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-483969992 @blueorangutan test -