[GitHub] [cloudstack] nvazquez commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
nvazquez commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568159608 @blueorangutan package This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-568146627 Trillian test result (tid-660) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658 ## File path: ui/scripts/instances.js ## @@ -3437,6 +3437,13 @@

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360624658 ## File path: ui/scripts/instances.js ## @@ -3437,6 +3437,13 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579834 ## File path: ui/scripts/templates.js ## @@ -2489,6 +2489,13 @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360579718 ## File path: ui/scripts/instances.js ## @@ -3437,6 +3437,13 @@

[GitHub] [cloudstack] blueorangutan commented on issue #3776: Fix HA config keys

2019-12-20 Thread GitBox
blueorangutan commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-568079770 Trillian test result (tid-657) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33207 seconds Marvin logs:

[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-568077178 Trillian test result (tid-659) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-20 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-568070482 Trillian test result (tid-658) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total

[GitHub] [cloudstack] shindere commented on issue #3692: Accessibility issue: unable to get API and secret keys

2019-12-20 Thread GitBox
shindere commented on issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692#issuecomment-568068829 EK (2019/12/20 05:51 -0800): > Not sure if I'll be at FOSDEM, but we can always setup a call and come > up with a

[GitHub] [cloudstack] andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag

2019-12-20 Thread GitBox
andrijapanicsb commented on issue #3780: Enhancement: Allow creating atmost 1 physical network with null tag URL: https://github.com/apache/cloudstack/pull/3780#issuecomment-568044158 @radeksm I can see edge cases where this constraint can be useful (operator lack of understanding how

[GitHub] [cloudstack] andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13

2019-12-20 Thread GitBox
andrijapanicsb commented on issue #3746: Fix OS category for some OS-es added in 4.13 URL: https://github.com/apache/cloudstack/pull/3746#issuecomment-568043129 @DaanHoogland can we merge this one to 4.13 as well - check the SQLs please, they are safe to be "done" in 4.13.0.0 to 4.13.1.0,

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568041406 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-498 This is an

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-560406657 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-417

[GitHub] [cloudstack] nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561613544 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-56045 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
nvazquez removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-560399923 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561613572 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564536852 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564536985 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-561619635 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-421

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-564546630 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-457

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566090007 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568035792 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566098066 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-473

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-566089627 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567463314 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-491

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567709267 @blueorangutan test matrix This is an automated message

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567819893 Trillian test result (tid-653) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
andrijapanicsb commented on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-568035672 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567710399 @andrijapanicsb a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7)

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
blueorangutan removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567456244 @andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks

2019-12-20 Thread GitBox
andrijapanicsb removed a comment on issue #3732: [Vmware] Enable PVLAN support on L2 networks URL: https://github.com/apache/cloudstack/pull/3732#issuecomment-567456072 @blueorangutan package This is an automated message

[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567985003 We can merge after tests job above succeeds. This is an

[GitHub] [cloudstack] NuxRo opened a new issue #3783: Create volume or template from snapshot is broken

2019-12-20 Thread GitBox
NuxRo opened a new issue #3783: Create volume or template from snapshot is broken URL: https://github.com/apache/cloudstack/issues/3783 Hi, I'm on 4.13 KVM + local storage, trying to create a volume or a template from a snapshot. Cloudmonkey says: ``` (localcloud) >

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445086 ## File path: ui/scripts/instances.js ## @@ -3437,6 +3437,13 @@

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3778: Endless settings on templates and instances

2019-12-20 Thread GitBox
anuragaw commented on a change in pull request #3778: Endless settings on templates and instances URL: https://github.com/apache/cloudstack/pull/3778#discussion_r360445185 ## File path: ui/scripts/templates.js ## @@ -2489,6 +2489,13 @@

[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567981322 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567981071 @blueorangutan test This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567980934 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-497 This

[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567974058 Running Marvin Tests on the PR. @blueorangutan package

[GitHub] [cloudstack] blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
blueorangutan commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567974078 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] anuragaw commented on issue #3776: Fix HA config keys

2019-12-20 Thread GitBox
anuragaw commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567972443 Travis failure was unrelated @mdominka . The tests that I've run are more exhaustive and should succeed in sometime. Did you see unrelated files' changes

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360432047 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml

[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567969213 > > > Code looks good. Haven't tested though. > > > One question - When the IP Address requested is invalid or unavailable

[GitHub] [cloudstack] DaanHoogland merged pull request #3782: 4.13

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3782: 4.13 URL: https://github.com/apache/cloudstack/pull/3782 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cloudstack] DaanHoogland closed issue #3252: Load balancer protocols bug

2019-12-20 Thread GitBox
DaanHoogland closed issue #3252: Load balancer protocols bug URL: https://github.com/apache/cloudstack/issues/3252 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] DaanHoogland closed issue #3702: Cannot create a VM connected to 2 tiers of a VPC

2019-12-20 Thread GitBox
DaanHoogland closed issue #3702: Cannot create a VM connected to 2 tiers of a VPC URL: https://github.com/apache/cloudstack/issues/3702 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland closed issue #3093: KVM Agent with Local Storage requests other local storage pools from LibVirt

2019-12-20 Thread GitBox
DaanHoogland closed issue #3093: KVM Agent with Local Storage requests other local storage pools from LibVirt URL: https://github.com/apache/cloudstack/issues/3093 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland closed issue #3683: Stop "mgmt server needs restart" message on global setting that doesn't require it

2019-12-20 Thread GitBox
DaanHoogland closed issue #3683: Stop "mgmt server needs restart" message on global setting that doesn't require it URL: https://github.com/apache/cloudstack/issues/3683 This is an automated message from the Apache Git

[cloudstack] branch master updated (0606039 -> 482d0fd)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 0606039 Honour promiscuous mode from networkOffering (#3765) (#3781) add 482d0fd 4.13 (#3782) No new

[GitHub] [cloudstack] DaanHoogland closed issue #3596: Zone wide storage pools hypervisor checks missing while retrieving statistics

2019-12-20 Thread GitBox
DaanHoogland closed issue #3596: Zone wide storage pools hypervisor checks missing while retrieving statistics URL: https://github.com/apache/cloudstack/issues/3596 This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] nvazquez commented on issue #3694: Ldap fixes

2019-12-20 Thread GitBox
nvazquez commented on issue #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#issuecomment-567960404 Thanks @DaanHoogland looking good, I'll post my final review once the last comment about reflection is sorted

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
nvazquez commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360414511 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -104,20

[GitHub] [cloudstack] nvazquez commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
nvazquez commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360413353 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml +

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407183 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407044 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360404508 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -38,24

[GitHub] [cloudstack] anuragaw commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
anuragaw commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567949543 > > Code looks good. Haven't tested though. > > One question - When the IP Address requested is invalid or unavailable in

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360403041 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401916 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401970 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360398649 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360396116 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -38,24

[GitHub] [cloudstack] DaanHoogland merged pull request #3729: config: add isdynamic flag in configuration response

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729 This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch 4.13 updated (3ac03c8 -> 2712dec)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 3ac03c8 filter hosts to query on zone wide storage (#3733) add 2712dec config: add isdynamic flag in

[GitHub] [cloudstack] DaanHoogland commented on issue #3729: config: add isdynamic flag in configuration response

2019-12-20 Thread GitBox
DaanHoogland commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-567939411 discussed with @rohit offline. this is a significant improvement over the current situation in spite of his remarks. We'll

[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567939292 > Code looks good. Haven't tested though. > > One question - When the IP Address requested is invalid or unavailable in

[GitHub] [cloudstack] rakgenius commented on issue #3775: New feature: Acquire specific public IP for network

2019-12-20 Thread GitBox
rakgenius commented on issue #3775: New feature: Acquire specific public IP for network URL: https://github.com/apache/cloudstack/pull/3775#issuecomment-567938446 > Can I specify a public IP when creating an isolated network or VPC? If you comment out the first diff in network.js

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360387379 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/LdapConstants.java ## @@ -0,0 +1,21 @@ +//

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360386594 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -81,38 +86,126 @@ **/*Spec.groovy

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360384545 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml

[GitHub] [cloudstack] kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys

2019-12-20 Thread GitBox
kioie commented on issue #3692: Accessibility issue: unable to get API and secret keys URL: https://github.com/apache/cloudstack/issues/3692#issuecomment-567931304 Not sure if I'll be at FOSDEM, but we can always setup a call and come up with a list of things we can do, then we can share

[GitHub] [cloudstack] kioie commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up

2019-12-20 Thread GitBox
kioie commented on issue #3757: Files in /var/cache/cloud/processed on virtual router are not cleaned up URL: https://github.com/apache/cloudstack/issues/3757#issuecomment-567929079 What would trigger a cleanup and what would be the frequency?

[GitHub] [cloudstack] DaanHoogland commented on issue #3776: Fix HA config keys

2019-12-20 Thread GitBox
DaanHoogland commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567923074 @mdominka it is because we strain travis too much but it is unrelated to the tests @anuragaw is doing. The log was longer than travis allows and we've been

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3782: 4.13

2019-12-20 Thread GitBox
DaanHoogland opened a new pull request #3782: 4.13 URL: https://github.com/apache/cloudstack/pull/3782 ## Description some fixess merged forward: Fixes: #3702 Fixes: #3252 Fixes: #3596 Fixes: #3093 ## Types of changes - [ ]

[GitHub] [cloudstack] DaanHoogland merged pull request #3733: filter hosts to query on zone wide storage

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3733: filter hosts to query on zone wide storage URL: https://github.com/apache/cloudstack/pull/3733 This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch 4.13 updated (90ce1d8 -> 3ac03c8)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 90ce1d8 convert protocal names to be found as labels (#3747) add 3ac03c8 filter hosts to query on zone wide

[GitHub] [cloudstack] DaanHoogland merged pull request #3747: convert protocal names to be found as labels

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3747: convert protocal names to be found as labels URL: https://github.com/apache/cloudstack/pull/3747 This is an automated message from the Apache Git Service. To respond to the message,

[cloudstack] branch 4.13 updated (0b34971 -> 90ce1d8)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 0b34971 Once again allow a VM to be on multiple networks from VPCs (#3754) add 90ce1d8 convert protocal

[cloudstack] branch 4.13 updated (5afff61 -> 0b34971)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 5afff61 create template from snapshot regression (partly reverted) (#3767) add 0b34971 Once again allow a VM

[GitHub] [cloudstack] DaanHoogland merged pull request #3754: Once again allow a VM to be on multiple networks from VPCs

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3754: Once again allow a VM to be on multiple networks from VPCs URL: https://github.com/apache/cloudstack/pull/3754 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] mdominka commented on issue #3776: Fix HA config keys

2019-12-20 Thread GitBox
mdominka commented on issue #3776: Fix HA config keys URL: https://github.com/apache/cloudstack/pull/3776#issuecomment-567918671 One travis test failed, but i see no relation to my changes. Can you test again @anuragaw

[cloudstack] branch 4.13 updated (c75c228 -> 5afff61)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from c75c228 Honour promiscuous mode from networkOffering (#3765) add 5afff61 create template from snapshot

[GitHub] [cloudstack] DaanHoogland merged pull request #3767: create template from snapshot regression (partly reverted)

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3767: create template from snapshot regression (partly reverted) URL: https://github.com/apache/cloudstack/pull/3767 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] DaanHoogland commented on issue #3565: vmware dvSwitches - promiscuous mode gets 'reject' when another network is attached to a VM

2019-12-20 Thread GitBox
DaanHoogland commented on issue #3565: vmware dvSwitches - promiscuous mode gets 'reject' when another network is attached to a VM URL: https://github.com/apache/cloudstack/issues/3565#issuecomment-567915930 fixed by merge of 4.13 in master (#3781 )

[GitHub] [cloudstack] DaanHoogland merged pull request #3781: Honour promiscuous mode from networkOffering (#3765)

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3781: Honour promiscuous mode from networkOffering (#3765) URL: https://github.com/apache/cloudstack/pull/3781 This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated (45503e1 -> 0606039)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 45503e1 Revert "Revert "Fix virtual template size for managed storage for KVM / refactor cloud-install-sys-tmplt

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3781: Honour promiscuous mode from networkOffering (#3765)

2019-12-20 Thread GitBox
DaanHoogland opened a new pull request #3781: Honour promiscuous mode from networkOffering (#3765) URL: https://github.com/apache/cloudstack/pull/3781 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause

[cloudstack] branch 4.13 updated (07d64cb -> c75c228)

2019-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.13 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 07d64cb [KVM] Agent LB Fix: Connections from disabled KVM host agents are refused (#3617) add c75c228 Honour

[GitHub] [cloudstack] DaanHoogland merged pull request #3765: Honour promiscuous mode from networkOffering

2019-12-20 Thread GitBox
DaanHoogland merged pull request #3765: Honour promiscuous mode from networkOffering URL: https://github.com/apache/cloudstack/pull/3765 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904671 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904602 @blueorangutan test This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567904119 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-496 This

[GitHub] [cloudstack] rhtyd commented on issue #3729: config: add isdynamic flag in configuration response

2019-12-20 Thread GitBox
rhtyd commented on issue #3729: config: add isdynamic flag in configuration response URL: https://github.com/apache/cloudstack/pull/3729#issuecomment-567902158 cc @PaulAngus this adds feature to know if restarting mgmt server is needed after updating a global setting. I'll see what we can

[GitHub] [cloudstack] blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
blueorangutan commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567899553 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-20 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-567899312 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
anuragaw commented on issue #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#issuecomment-567899360 ping @DaanHoogland for re-review when you have time. @blueorangutan package

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-12-20 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-567899111 @blueorangutan test This is an automated message from

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow additional config to vms

2019-12-20 Thread GitBox
anuragaw commented on a change in pull request #3510: [WIP DO NOT MERGE] Allow additional config to vms URL: https://github.com/apache/cloudstack/pull/3510#discussion_r360337798 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -5105,32

  1   2   >