[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188713 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appro

2021-06-04 Thread GitBox
rhtyd commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188587 @blueorangutan test centos7 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855188370 Trillian test result (tid-863) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 58850 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855164911 Trillian test result (tid-865) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 44415 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-855151925 Trillian test result (tid-862) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46480 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-855086404 Trillian test result (tid-864) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34683 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#issuecomment-854985717 Trillian test result (tid-861) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33555 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854960552 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 170 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-854960034 Trillian test result (tid-859) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37368 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4643: VM dynamic scaling option granularity

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4643: URL: https://github.com/apache/cloudstack/pull/4643#issuecomment-854955142 Trillian test result (tid-858) Environment: xenserver-72 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37475 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4630: disable hot add memory and cpu via vm settings

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4630: URL: https://github.com/apache/cloudstack/pull/4630#issuecomment-854950713 Trillian test result (tid-857) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37551 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854949020 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
nvazquez commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854948788 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854937688 Trillian test result (tid-860) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33666 seconds Marvin logs: https://github

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854916158 Trillian test result (tid-855) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38640 seconds Marvin logs: https://github

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #4958: Improve logs on agent start

2021-06-04 Thread GitBox
GutoVeronezi commented on a change in pull request #4958: URL: https://github.com/apache/cloudstack/pull/4958#discussion_r645748094 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -2436,6 +2436,9 @@ public HostVO fillRoutingHostVO(final Host

[GitHub] [cloudstack] blueorangutan commented on pull request #5074: Check for VLAN or VXLAN in NetworkDaoImpl.listByPhysicalNetworkPvlan

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5074: URL: https://github.com/apache/cloudstack/pull/5074#issuecomment-854867006 Trillian test result (tid-854) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36426 seconds Marvin logs: https://github

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
GutoVeronezi commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854848841 @DaanHoogland actually, there really was an error; It was fixed with last commit. Most of the checks passed now, those that failed seems to fail due to environme

[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-04 Thread GitBox
GutoVeronezi commented on a change in pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#discussion_r645690177 ## File path: engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java ## @@ -1868,6 +1847,65 @@ protected

[GitHub] [cloudstack] weizhouapache commented on pull request #5074: Check for VLAN or VXLAN in NetworkDaoImpl.listByPhysicalNetworkPvlan

2021-06-04 Thread GitBox
weizhouapache commented on pull request #5074: URL: https://github.com/apache/cloudstack/pull/5074#issuecomment-854809486 @rhtyd @GabrielBrascher I confirm that the issue #5071 can be reproduced and fixed by this pr. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-854805590 Trillian test result (tid-845) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 82403 seconds Marvin logs: https://github

[GitHub] [cloudstack] weizhouapache commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
weizhouapache commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854800913 @GabrielBrascher thanks. I can reproduce the issue when create shared network with vxlan in advanced zone. I will test the fix. -- This is an automated message from

[GitHub] [cloudstack] GabrielBrascher commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
GabrielBrascher commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854779565 @rhtyd ah that's the case indeed, shared networks. It was working in 4.13.1.0; I did not test in 4.14. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] rhtyd commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
rhtyd commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854775626 Thanks @GabrielBrascher by networks it wasn't clear if you meant Shared network or isolated network. Does this feature work in 4.14 or before? -- This is an automated message fro

[GitHub] [cloudstack] GabrielBrascher commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
GabrielBrascher commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854762528 @weizhouapache here follows some details: ### Environment 1. CloudStack version: `4.15.0.0` & `4.15.1.0 RC1` 2. Virtualization: KVM 3. Network: Advanced Netw

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854751932 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
nvazquez commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854751224 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854738677 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 169 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854722949 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
nvazquez commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854722216 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854715550 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 168 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854700302 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4585: Externalize kvm agent storage timeout configuration

2021-06-04 Thread GitBox
GutoVeronezi commented on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-854699740 > > About the question: > > This PR intends to externalize the heartbeat timeout configuration on `KVMHAMonitor` via `agent.properties`; And the purpose of these class

[GitHub] [cloudstack] nvazquez commented on pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
nvazquez commented on pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076#issuecomment-854699732 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854699754 @rhtyd a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automa

[GitHub] [cloudstack] nvazquez opened a new pull request #5076: [Vmware] Fix lsilogcsas controller for deploy-as-is

2021-06-04 Thread GitBox
nvazquez opened a new pull request #5076: URL: https://github.com/apache/cloudstack/pull/5076 ### Description This PR fixes deployment of VMs using controller `lsilogicsas` for Vmware deploy-as-is ### Types of changes - [ ] Breaking change (fix or feature that would cau

[GitHub] [cloudstack] rhtyd commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms as appro

2021-06-04 Thread GitBox
rhtyd commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-854698301 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5066: URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-854664956 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 167 -- This is an automated message from the Apache Git Serv

[cloudstack-www] branch asf-yaml updated (ba65cb9 -> fc4ad57)

2021-06-04 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch asf-yaml in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from ba65cb9 staging and publishg directives for asf add fc4ad57 Update .asf.yaml for (future) inclusivity

[GitHub] [cloudstack] DaanHoogland commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #5066: URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-854651031 > @DaanHoogland Yes, we should not encourage people to make '/tmp/' have mode 700. But we still need to encourage users to override "/tmp" with "java.io.tmpdir". repush

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4205: Integrate Tungsten Fabric with CloudStack

2021-06-04 Thread GitBox
DaanHoogland commented on a change in pull request #4205: URL: https://github.com/apache/cloudstack/pull/4205#discussion_r645489863 ## File path: client/pom.xml ## @@ -29,11 +29,17 @@ -juniper-contrail -https://juniper.github.io/con

[GitHub] [cloudstack] andrijapanicsb commented on issue #4169: local iso upload failed

2021-06-04 Thread GitBox
andrijapanicsb commented on issue #4169: URL: https://github.com/apache/cloudstack/issues/4169#issuecomment-854648232 I would not trade security for convenience - thus I wild propose this stays as it is - requiring HTTPS end point on SSVM. -- This is an automated message from the Apache

[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
GutoVeronezi edited a comment on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854645585 @DaanHoogland rebase done, waiting for check and package results. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] GutoVeronezi edited a comment on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
GutoVeronezi edited a comment on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854645585 @DaanHoogland rebase done, waiting for check results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
GutoVeronezi commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854645585 @DaanHoogland rebase done, waiting for test results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] GutoVeronezi commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
GutoVeronezi commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854645057 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] sureshanaparti commented on pull request #4958: Improve logs on agent start

2021-06-04 Thread GitBox
sureshanaparti commented on pull request #4958: URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-854642309 > @sureshanaparti @rhtyd are you guys all right with this? @DaanHoogland seems there are some unaddressed comments. @GutoVeronezi can you please check and resolv

[GitHub] [cloudstack] sureshanaparti commented on pull request #4703: Improve logs on ProcessRunner

2021-06-04 Thread GitBox
sureshanaparti commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854640982 > @sureshanaparti they are not consistent in this pr, so i'm not to worried, but i'll give them one last spin. ok @DaanHoogland -- This is an automated messa

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-04 Thread GitBox
sureshanaparti commented on a change in pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#discussion_r645499790 ## File path: engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java ## @@ -1868,6 +1847,65 @@ protect

[GitHub] [cloudstack] weizhouapache commented on pull request #5073: systemvmtemplate: use latest LTS kernel from buster-ports

2021-06-04 Thread GitBox
weizhouapache commented on pull request #5073: URL: https://github.com/apache/cloudstack/pull/5073#issuecomment-854633356 > @weizhouapache I think it would be too much maintenance work for gain to maintain separate systemvmtemplate for each hypervisor. These days users can download 100MBs

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5073: systemvmtemplate: use latest LTS kernel from buster-ports

2021-06-04 Thread GitBox
weizhouapache commented on a change in pull request #5073: URL: https://github.com/apache/cloudstack/pull/5073#discussion_r645490740 ## File path: tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh ## @@ -53,11 +53,17 @@ function apt_upgrade() { rm -fv /root/*.iso

[GitHub] [cloudstack] lujiefsi commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir

2021-06-04 Thread GitBox
lujiefsi commented on pull request #5066: URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-854632444 @DaanHoogland Yes, we should not encourage people to make '/tmp/' have mode 700. But we still need to encourage users to override "/tmp" with "java.io.tmpdir". repush the ne

[cloudstack-www] 01/01: staging and publishg directives for asf

2021-06-04 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch asf-yaml in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit ba65cb945520580a30b0e0fa180a50df53eb187b Author: Daan Hoogland AuthorDate: Fri Jun 4 13:02:06 2021 +0200 st

[cloudstack-www] branch asf-yaml created (now ba65cb9)

2021-06-04 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch asf-yaml in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. at ba65cb9 staging and publishg directives for asf This branch includes the following new commits: new b

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-854617563 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] rhtyd commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-04 Thread GitBox
rhtyd commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-854617182 @blueorangutan test centos7 xenserver-71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] rhtyd commented on pull request #5073: systemvmtemplate: use latest LTS kernel from buster-ports

2021-06-04 Thread GitBox
rhtyd commented on pull request #5073: URL: https://github.com/apache/cloudstack/pull/5073#issuecomment-854616926 @weizhouapache I think it would be too much maintenance work for gain to maintain separate systemvmtemplate for each hypervisor. These days users can download 100MBs more in fe

[GitHub] [cloudstack] DaanHoogland commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854611595 @GutoVeronezi , can you also rebase and check if it builds? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [cloudstack] DaanHoogland commented on issue #3111: Allow extending and shrinking of public IP address range

2021-06-04 Thread GitBox
DaanHoogland commented on issue #3111: URL: https://github.com/apache/cloudstack/issues/3111#issuecomment-854596631 > A good addition. +1 is that you volunteering, @Spaceman1984 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] blueorangutan commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854594826 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5052 (SL-JID-208) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] DaanHoogland commented on pull request #5066: CLOUDSTACK-10436:remind users to use correct permission for tmp dir

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #5066: URL: https://github.com/apache/cloudstack/pull/5066#issuecomment-854593732 @lujiefsi we should not encourage people to make '/tmp/' have mode 700. That is not a valid mode for /tmp on a unix system. it must have 1777 as mode. You could make sur

[GitHub] [cloudstack] blueorangutan commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854584759 @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] davidjumani commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
davidjumani commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854583571 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] weizhouapache edited a comment on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
weizhouapache edited a comment on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854533076 @GabrielBrascher I was trying to reproduce this issue, but the following works for me (1) create an advanced zone, use VXLAN for guest networks (2) create an

[GitHub] [cloudstack] shwstppr opened a new pull request #5075: ui: vmware vm ingestion

2021-06-04 Thread GitBox
shwstppr opened a new pull request #5075: URL: https://github.com/apache/cloudstack/pull/5075 ### Description Adds UI for importing VMs for a cluster ### Types of changes - [ ] Breaking change (fix or feature that would

[GitHub] [cloudstack] aleskxyz commented on pull request #4890: Universal sshkey and password manager script

2021-06-04 Thread GitBox
aleskxyz commented on pull request #4890: URL: https://github.com/apache/cloudstack/pull/4890#issuecomment-854551529 > Thanks, we need some manual test/confirmation and a doc PR to https://github.com/apache/cloudstack-documentation explaining how to use this. @rhtyd I'm working o

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-854550745 Trillian test result (tid-849) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 54449 seconds Marvin logs: https://github

[GitHub] [cloudstack] utchoang edited a comment on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
utchoang edited a comment on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854543151 @rhtyd Do you mean the same as the settings in the pro version? ![image](https://user-images.githubusercontent.com/13766648/120783442-3d85c100-c555-11eb-9895-51

[GitHub] [cloudstack] utchoang edited a comment on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
utchoang edited a comment on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854543151 @rhtyd Do you mean the same as the settings in the pro version? Or is using the same color codes? ![image](https://user-images.githubusercontent.com/13766648

[GitHub] [cloudstack] utchoang commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
utchoang commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854543151 @rhtyd Do you mean the same as the settings in the pro version? ![image](https://user-images.githubusercontent.com/13766648/120783442-3d85c100-c555-11eb-9895-5139d564b

[GitHub] [cloudstack] blueorangutan commented on pull request #5067: Keep volume policies after migrating it to another primary storage

2021-06-04 Thread GitBox
blueorangutan commented on pull request #5067: URL: https://github.com/apache/cloudstack/pull/5067#issuecomment-854542716 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 166 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] utchoang commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
utchoang commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854540595 @davidjumani Is there any mistake? But I tested it and it's ok ![image](https://user-images.githubusercontent.com/13766648/120782718-7a04ed00-c554-11eb-9d7c-90636490ab

[GitHub] [cloudstack] rhtyd commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
rhtyd commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854537377 @utchoang can you refer to https://preview.pro.ant.design/dashboard/analysis?navTheme=realDark&fixSiderbar=true&colorWeak=false&pwa=false and have the implementation similar to

[GitHub] [cloudstack] davidjumani commented on pull request #5052: UI: Dark mode toggle button on Management Server

2021-06-04 Thread GitBox
davidjumani commented on pull request #5052: URL: https://github.com/apache/cloudstack/pull/5052#issuecomment-854537222 @utchoang The side navbar text is in black ![Screenshot from 2021-06-04 15-10-22](https://user-images.githubusercontent.com/8244774/120781961-2b9d2180-c547-11eb-897d-f8

[GitHub] [cloudstack] weizhouapache commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
weizhouapache commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854533076 @GabrielBrascher I was trying to reproduce this issue, but the following works for me (1) create an advanced zone, use VXLAN for guest networks (2) create an isolate

[GitHub] [cloudstack] DaanHoogland commented on pull request #4585: Externalize kvm agent storage timeout configuration

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-854526484 > About the question: > This PR intends to externalize the heartbeat timeout configuration on `KVMHAMonitor` via `agent.properties`; And the purpose of these classes i

[GitHub] [cloudstack] DaanHoogland commented on issue #5046: vmware: affinity and anti-affinity rules must be followed when VMware cluster DRS is enabled

2021-06-04 Thread GitBox
DaanHoogland commented on issue #5046: URL: https://github.com/apache/cloudstack/issues/5046#issuecomment-854522652 good point @aleskxyz , thanks. This worth some investigation. @shwstppr had you looked into this as well? So if the zone is a vphere dc, antiaffinity should be ignored by t

[GitHub] [cloudstack] blueorangutan commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854505299 Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 165 -- This is an automated message from t

[GitHub] [cloudstack] blueorangutan commented on pull request #4703: Improve logs on ProcessRunner

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854501551 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 164 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] DaanHoogland commented on pull request #5060: ui: Adding option to choose between name and displayname

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #5060: URL: https://github.com/apache/cloudstack/pull/5060#issuecomment-854488891 +0 but i agree with @rhtyd , is it possible to make the column header a drop down? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] DaanHoogland commented on pull request #4703: Improve logs on ProcessRunner

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #4703: URL: https://github.com/apache/cloudstack/pull/4703#issuecomment-854485548 @sureshanaparti they are not consistent in this pr, so i'm not to worried, but i'll give them one last spin. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] DaanHoogland commented on pull request #4958: Improve logs on agent start

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #4958: URL: https://github.com/apache/cloudstack/pull/4958#issuecomment-854458383 @sureshanaparti @rhtyd are you guys all right with this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4630: disable hot add memory and cpu via vm settings

2021-06-04 Thread GitBox
blueorangutan removed a comment on pull request #4630: URL: https://github.com/apache/cloudstack/pull/4630#issuecomment-836501783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] blueorangutan commented on pull request #4577: [HEALTH] 4.16/master Health Check please don't merge this

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4577: URL: https://github.com/apache/cloudstack/pull/4577#issuecomment-854476597 Trillian test result (tid-850) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47565 seconds Marvin logs: https://github

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4886: server: list routers by healthchecksfailed

2021-06-04 Thread GitBox
DaanHoogland commented on a change in pull request #4886: URL: https://github.com/apache/cloudstack/pull/4886#discussion_r645351586 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1341,6 +1343,27 @@ sb.and("networkId", sb.entity(

[GitHub] [cloudstack] DaanHoogland commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
DaanHoogland commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854453916 rebuilding and re-testing I think these errors are environmental/incidental. @GutoVeronezi can you find someone to review/test for a second :+1: , please? -- This is

[GitHub] [cloudstack] weizhouapache commented on pull request #5070: systemvmtemplate: reduce template by using cloud kernel

2021-06-04 Thread GitBox
weizhouapache commented on pull request #5070: URL: https://github.com/apache/cloudstack/pull/5070#issuecomment-854379691 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [cloudstack] blueorangutan commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-854462399 Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 162 -- This is an automated message from t

[GitHub] [cloudstack] blueorangutan commented on pull request #4630: disable hot add memory and cpu via vm settings

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4630: URL: https://github.com/apache/cloudstack/pull/4630#issuecomment-854476980 Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 163 -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] weizhouapache commented on pull request #5073: systemvmtemplate: use latest LTS kernel from buster-ports

2021-06-04 Thread GitBox
weizhouapache commented on pull request #5073: URL: https://github.com/apache/cloudstack/pull/5073#issuecomment-854393798 @rhtyd good. maybe consider #3900 and set a smaller template size ? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] GabrielBrascher commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
GabrielBrascher commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-854159467 @rhtyd I am sorry for the delay. PR ##5074 is out. I appreciate any test & review :+1: -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] sureshanaparti commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
sureshanaparti commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853894609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

[GitHub] [cloudstack] blueorangutan commented on pull request #4922: Inclusivity changes for CloudStack - change default git branch name from 'master' to 'main', and rename some offensive words/terms

2021-06-04 Thread GitBox
blueorangutan commented on pull request #4922: URL: https://github.com/apache/cloudstack/pull/4922#issuecomment-853660768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. Fo

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5074: Check for VLAN or VXLAN in NetworkDaoImpl.listByPhysicalNetworkPvlan

2021-06-04 Thread GitBox
GabrielBrascher commented on pull request #5074: URL: https://github.com/apache/cloudstack/pull/5074#issuecomment-854158556 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] GabrielBrascher commented on issue #4657: Management server looses MySQL connection: Timeout waiting for idle object

2021-06-04 Thread GitBox
GabrielBrascher commented on issue #4657: URL: https://github.com/apache/cloudstack/issues/4657#issuecomment-854112884 It looks like changing the MySQL global variables solved this issue. Closing this issue for now; I may re-open if it happens again. -- This is an automated message fro

[GitHub] [cloudstack] rhtyd commented on pull request #5024: Health Check PR: 4.15

2021-06-04 Thread GitBox
rhtyd commented on pull request #5024: URL: https://github.com/apache/cloudstack/pull/5024#issuecomment-853507735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For querie

[GitHub] [cloudstack] Pearl1594 commented on pull request #5034: [WIP] UI: bulk action support for various resources

2021-06-04 Thread GitBox
Pearl1594 commented on pull request #5034: URL: https://github.com/apache/cloudstack/pull/5034#issuecomment-853639804 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] wido commented on issue #5071: Error when 'createNetwork' with VXLAN: "VLAN requested but URI is not in the expected format"

2021-06-04 Thread GitBox
wido commented on issue #5071: URL: https://github.com/apache/cloudstack/issues/5071#issuecomment-853918570 > @GabrielBrascher can you check if it affects 4.15.1.0RC1 too? Afaik it does -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] shwstppr commented on pull request #5072: Fix of some UEFI related issues

2021-06-04 Thread GitBox
shwstppr commented on pull request #5072: URL: https://github.com/apache/cloudstack/pull/5072#issuecomment-853967981 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] sureshanaparti commented on pull request #5037: Updated PowerFlex/ScaleIO gateway client with some improvements.

2021-06-04 Thread GitBox
sureshanaparti commented on pull request #5037: URL: https://github.com/apache/cloudstack/pull/5037#issuecomment-853862990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. F

  1   2   >