[GitHub] [cloudstack] DK101010 commented on pull request #4399: PR multi tags in compute offering [#4398]

2021-07-22 Thread GitBox
DK101010 commented on pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-885436838 > found two bugs in testing > (1) list hosts response lists only 1 host tag, although hosts have multiple host tags. > for example > > ``` > (localcloud) SBCM

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4766: UI: Submit the form when press CTRL + ENTER

2021-07-22 Thread GitBox
davidjumani commented on a change in pull request #4766: URL: https://github.com/apache/cloudstack/pull/4766#discussion_r675322567 ## File path: ui/src/views/compute/EditVM.vue ## @@ -73,7 +73,7 @@ {{ this.$t('label.cancel') }} -{{ this.$t('label.ok

[GitHub] [cloudstack] davidjumani edited a comment on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
davidjumani edited a comment on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885413262 Works for key combos like ctrl+shift+esc or shift+number but not shift+alphabet since novnc prioritizes the ascii value of an alphabet sent rather than the combo o

[GitHub] [cloudstack] davidjumani commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
davidjumani commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885413262 Works for key combos like ctrl+shift+esc or shift+number but not shift+alphabet since novnc prioritizes the ascii value of an alphabet sent rather than the combo of shift

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5227: Store Vm migration details in db

2021-07-22 Thread GitBox
harikrishna-patnala commented on pull request #5227: URL: https://github.com/apache/cloudstack/pull/5227#issuecomment-885412965 @ravening thanks for explaining and I agree this adds some user friendliness but my main concern is, this looks more like fixing a single usecase. If we have to t

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
davidjumani commented on a change in pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#discussion_r675313414 ## File path: systemvm/agent/noVNC/app/ui.js ## @@ -1551,6 +1553,17 @@ const UI = { } }, +toggleShift() { +const btn =

[GitHub] [cloudstack] davidjumani edited a comment on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
davidjumani edited a comment on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885370657 > sorry, That will leave people with disfunctional environments. -1 Reasons why I'm against adding anything to the upgrade path : 1. Pvlans are also created on

[GitHub] [cloudstack] blueorangutan commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-885398210 @davidjumani a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
davidjumani commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-885397936 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-885389367 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 635 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885384686 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 634 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5206: UI: only display host information, if they are relevant

2021-07-22 Thread GitBox
davidjumani commented on a change in pull request #5206: URL: https://github.com/apache/cloudstack/pull/5206#discussion_r675292125 ## File path: ui/src/views/infra/HostInfo.vue ## @@ -83,15 +83,15 @@ - + Review comment: Ah yes,

[GitHub] [cloudstack] blueorangutan commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-885379917 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
davidjumani commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-885379745 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885376012 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] davidjumani commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
davidjumani commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885375769 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] davidjumani edited a comment on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
davidjumani edited a comment on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885370657 > sorry, That will leave people with disfunctional environments. -1 Reasons why I'm against adding anything to the upgrade path : 1. It is a bad assumption that

[GitHub] [cloudstack] davidjumani edited a comment on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
davidjumani edited a comment on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885370657 > sorry, That will leave people with disfunctional environments. -1 Two reasons why I'm against adding anything to the upgrade path : 1. It is a bad assumption

[GitHub] [cloudstack] davidjumani commented on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
davidjumani commented on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885370657 > sorry, That will leave people with disfunctional environments. -1 Two reasons why I'm against adding anything to the upgrade path : 1. It is a bad assumption that al

[GitHub] [cloudstack] blueorangutan commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885354012 Trillian test result (tid-1357) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33373 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-885339711 Trillian test result (tid-1355) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34095 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5225: Fix of shrinking volumes with QCOW2 format

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5225: URL: https://github.com/apache/cloudstack/pull/5225#issuecomment-885302081 Trillian test result (tid-1352) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40270 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4780: Add SharedMountPoint to KVMs supported storage pool types

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4780: URL: https://github.com/apache/cloudstack/pull/4780#issuecomment-885263713 Trillian test result (tid-1350) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49986 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-885262483 Trillian test result (tid-1351) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41427 seconds Marvin logs: https://githu

[GitHub] [cloudstack] mib1185 commented on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
mib1185 commented on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885253048 > sorry, That will leave people with disfunctional environments. 👎 This could be the case for every user, who has updated to 4.15.x, since approache, how `boadcast_uri` is b

[GitHub] [cloudstack] tampler opened a new issue #5238: NFS backed SecondaryStorage is unavailable after Basic Zone setup

2021-07-22 Thread GitBox
tampler opened a new issue #5238: URL: https://github.com/apache/cloudstack/issues/5238 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Secondary Storage, NFS, SystemVM ~~~ # CLOUDSTACK VERSION ~~~ 4.15.1 ~~~ #

[GitHub] [cloudstack] blueorangutan commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885238024 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5237 (SL-JID-410) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885235288 @GabrielBrascher a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] GabrielBrascher commented on pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
GabrielBrascher commented on pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237#issuecomment-885235060 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #5237: [UI] Add Shift key for noVNC consoles

2021-07-22 Thread GitBox
GabrielBrascher opened a new pull request #5237: URL: https://github.com/apache/cloudstack/pull/5237 ### Description Some key combinations, such as Task Manager (ctrl+shift+esc) cannot be executed in noVNC console as the 'Shift' key is not supported. This PR proposes to add a

[GitHub] [cloudstack] GutoVeronezi commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
GutoVeronezi commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885198386 @nvazquez ASAP I will review this :smiley: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] DaanHoogland commented on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
DaanHoogland commented on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-885135622 sorry, That will leave people with disfunctional environments. :-1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] sureshanaparti closed pull request #5216: Support for new Feature: Clone a Virtual Machine (#4818)

2021-07-22 Thread GitBox
sureshanaparti closed pull request #5216: URL: https://github.com/apache/cloudstack/pull/5216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [cloudstack] blueorangutan commented on pull request #4959: Improve logs on ConsoleProxyManagerImpl and refactor a few process

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4959: URL: https://github.com/apache/cloudstack/pull/4959#issuecomment-885121592 Trillian test result (tid-1349) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35594 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4378: server: Optional destination host when migrate a vm

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-885077062 Trillian test result (tid-1348) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37172 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885048810 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
nvazquez commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885048433 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] blueorangutan commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885047063 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 631 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez removed a comment on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
nvazquez removed a comment on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885018007 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack] nvazquez commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
nvazquez commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885037267 @GutoVeronezi @DaanHoogland @davidjumani please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [cloudstack] blueorangutan commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885028972 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
nvazquez commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885028443 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] shwstppr commented on issue #4187: Migration not working in ACS 4.14 with Basic Network - VMware Local storage

2021-07-22 Thread GitBox
shwstppr commented on issue #4187: URL: https://github.com/apache/cloudstack/issues/4187#issuecomment-885025014 @weizhouapache will try to have a look. @ccycv is it possible to test 4.15.1 to reproduce it? Other than #4385 , VMware migration improvements were also made with #4895 & #475

[GitHub] [cloudstack] blueorangutan commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-885018814 Trillian Build Failed (tid-1354) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack] nvazquez commented on pull request #5103: Extend the Annotations framework

2021-07-22 Thread GitBox
nvazquez commented on pull request #5103: URL: https://github.com/apache/cloudstack/pull/5103#issuecomment-885018007 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] weizhouapache commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
weizhouapache commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884994900 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] blueorangutan commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884995056 @weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is a

[GitHub] [cloudstack] weizhouapache edited a comment on issue #4187: Migration not working in ACS 4.14 with Basic Network - VMware Local storage

2021-07-22 Thread GitBox
weizhouapache edited a comment on issue #4187: URL: https://github.com/apache/cloudstack/issues/4187#issuecomment-884960230 @nvazquez I was not able to create a vmware basic zone with local storage for testing. for vmware basic zone with shared storage, it works in my testing. @shwst

[GitHub] [cloudstack] weizhouapache commented on issue #4187: Migration not working in ACS 4.14 with Basic Network - VMware Local storage

2021-07-22 Thread GitBox
weizhouapache commented on issue #4187: URL: https://github.com/apache/cloudstack/issues/4187#issuecomment-884960230 @nvazquez I was not able to create a vmware basic zone with local storage for testing. for vmware basic zone with shared storage, it works in my testing. @shwstppr I n

[GitHub] [cloudstack] sureshanaparti commented on pull request #4378: server: Optional destination host when migrate a vm

2021-07-22 Thread GitBox
sureshanaparti commented on pull request #4378: URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-884949132 > > Sorry for the late reply, @ustcweizhou. > > > @GabrielBrascher @sureshanaparti > > > we have 3 options > > > (1) autoselect is 'true' by default > > > (2

[GitHub] [cloudstack] weizhouapache commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
weizhouapache commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884941192 @nvazquez tested ok, this pr is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [cloudstack] blueorangutan commented on pull request #5043: Allow updating the storage/host tags of service offerings

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5043: URL: https://github.com/apache/cloudstack/pull/5043#issuecomment-884924970 Trillian test result (tid-1340) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 86022 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5236: server: fix VR health check in vmware basic zone

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884918571 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 630 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] blueorangutan commented on pull request #5236: fix #4158: VR health check in vmware basic zone

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884899809 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] weizhouapache commented on pull request #5236: fix #4158: VR health check in vmware basic zone

2021-07-22 Thread GitBox
weizhouapache commented on pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236#issuecomment-884899511 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] weizhouapache opened a new pull request #5236: fix #4158: VR health check in vmware basic zone

2021-07-22 Thread GitBox
weizhouapache opened a new pull request #5236: URL: https://github.com/apache/cloudstack/pull/5236 ### Description This PR fixes VR heallth check in vmware basic zone. ### Types of changes - [ ] Breaking change (fix

[GitHub] [cloudstack] weizhouapache commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
weizhouapache commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884893717 > LGTM > > Before changes (Scale VM disabled for a stopped VM): > ![Screenshot from 2021-07-22 17-15-36](https://user-images.githubusercontent.com/153340/12663

[GitHub] [cloudstack] blueorangutan commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-884892891 @nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-07-22 Thread GitBox
nvazquez commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-884892367 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] tampler commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
tampler commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884892135 > @tampler could you please check if SSVM (secondary storage vm) is running and its Agent state is Up ? > Infrastructure -> System VMs -> s-X-VM No, they are NOT. I can't

[GitHub] [cloudstack] tampler commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
tampler commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884888247 > > I see the same issue for Management Servers. I got only one management server, but see three with different IDs in the GUI and can't remove any of them as well > > @tam

[GitHub] [cloudstack] weizhouapache commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
weizhouapache commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884887684 > @ustcweizhou I'm not sure which logs do you want. Here's an exert from the `/var/logs/cloudstack/management/management-server.log`. See the file attached. > > Let me

[GitHub] [cloudstack] weizhouapache commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
weizhouapache commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884886467 > I see the same issue for Management Servers. I got only one management server, but see three with different IDs in the GUI and can't remove any of them as well @tam

[GitHub] [cloudstack] blueorangutan commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-884866905 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 629 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] nvazquez commented on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
nvazquez commented on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-884864072 The logic to upgrade older pvlans should be smarter than a DB upgrade. I would propose to proceed with the PR #5194 without any DB upgrade, leaving this ticket open for future fi

[GitHub] [cloudstack] blueorangutan commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-07-22 Thread GitBox
blueorangutan commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-884854380 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #4701: Added support for removing unused port groups on VMWare

2021-07-22 Thread GitBox
nvazquez commented on pull request #4701: URL: https://github.com/apache/cloudstack/pull/4701#issuecomment-884853966 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] blueorangutan commented on pull request #5225: Fix of shrinking volumes with QCOW2 format

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5225: URL: https://github.com/apache/cloudstack/pull/5225#issuecomment-884852405 @shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] shwstppr commented on pull request #5225: Fix of shrinking volumes with QCOW2 format

2021-07-22 Thread GitBox
shwstppr commented on pull request #5225: URL: https://github.com/apache/cloudstack/pull/5225#issuecomment-884852083 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [cloudstack] davidjumani commented on issue #5202: Addition to #5194 - update of `broadcast_uri` for all existing pvlan networks is necessary during upgrade to 4.15.x

2021-07-22 Thread GitBox
davidjumani commented on issue #5202: URL: https://github.com/apache/cloudstack/issues/5202#issuecomment-884850858 If I'm understanding this correctly, other existing pvlans (in vmware) were created as isolated in cloudstack as that's the only one that was supported at that time. If that's

[GitHub] [cloudstack] tampler commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
tampler commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884849373 @ustcweizhou I'm not sure which logs do you want. Here's an exert from the `/var/logs/cloudstack/management/management-server.log`. See the file attached. Let me know if you

[GitHub] [cloudstack] blueorangutan commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884848129 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5233 (SL-JID-409) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] shwstppr removed a comment on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr removed a comment on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884807331 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
blueorangutan removed a comment on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884810085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] blueorangutan commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884846042 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] shwstppr commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884845707 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
weizhouapache commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674715615 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how

[GitHub] [cloudstack] tampler commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
tampler commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884843423 I see the same issue for Management Servers. I got only one management server, but see three with different IDs in the GUI and can't remove any of them as well ![Screenshot

[GitHub] [cloudstack] tampler commented on issue #5235: Minimum required IP range for a single ZONE

2021-07-22 Thread GitBox
tampler commented on issue #5235: URL: https://github.com/apache/cloudstack/issues/5235#issuecomment-884827608 I'm using the Basic Zone. I bought 3 ext IPs from my provider. IP0 - NIC, cloudbr0 IP1 - Management Range [IP1:IP1] IP2 - Guest Range [IP2:IP2] With such setup,

[GitHub] [cloudstack] weizhouapache commented on issue #5235: Minimum required IP range for a single ZONE

2021-07-22 Thread GitBox
weizhouapache commented on issue #5235: URL: https://github.com/apache/cloudstack/issues/5235#issuecomment-884815609 @tampler what type of zone do you use ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack] blueorangutan commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884810085 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5233 (SL-JID-408) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884807620 @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] shwstppr commented on pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#issuecomment-884807331 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [cloudstack] tampler opened a new issue #5235: Minimum required IP range for a single ZONE

2021-07-22 Thread GitBox
tampler opened a new issue #5235: URL: https://github.com/apache/cloudstack/issues/5235 # ISSUE TYPE * Documentation Request # COMPONENT NAME ~~~ Zone Configuration ~~~ # CLOUDSTACK VERSION ~~~ 4.15.1 ~~~ # CO

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674672211 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how-to-d

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674671873 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how-to-d

[GitHub] [cloudstack] ravening commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
ravening commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674665625 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how-to-d

[GitHub] [cloudstack] tampler opened a new issue #5234: Choose between Public or VPN based IPs for KVM VMs

2021-07-22 Thread GitBox
tampler opened a new issue #5234: URL: https://github.com/apache/cloudstack/issues/5234 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ VPN, Connectivity ~~~ # CLOUDSTACK VERSION ~~~ 4.15.1 ~~~ # CONFI

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674660272 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how-to-d

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
shwstppr commented on a change in pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233#discussion_r674660272 ## File path: ui/src/config/section/compute.js ## @@ -299,7 +299,7 @@ export default { docHelp: 'adminguide/virtual_machines.html#how-to-d

[GitHub] [cloudstack] blueorangutan commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-884785653 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
Pearl1594 commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-884785376 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-884768428 Trillian test result (tid-1343) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49263 seconds Marvin logs: https://gith

[GitHub] [cloudstack] rp- commented on a change in pull request #4994: Linstor volume plugin

2021-07-22 Thread GitBox
rp- commented on a change in pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#discussion_r674624082 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java ## @@ -0,0 +1,578 @@ +package com.cloud.hy

[GitHub] [cloudstack] blueorangutan commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-884760973 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 628 -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] weizhouapache commented on issue #5230: Can't remove a failed ISO

2021-07-22 Thread GitBox
weizhouapache commented on issue #5230: URL: https://github.com/apache/cloudstack/issues/5230#issuecomment-884753488 @tampler ssl is required in SSVM when upload template/iso form local, see @Pearl1594 's comment above you may find information on https://www.shapeblue.com/securing-clou

[GitHub] [cloudstack] weizhouapache commented on pull request #4399: PR multi tags in compute offering [#4398]

2021-07-22 Thread GitBox
weizhouapache commented on pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-884750586 @nvazquez here is update: 1. found two bugs in my testing, see my comments above. 2. fixed another ui bug: https://github.com/apache/cloudstack/pull/5233 -- This

[GitHub] [cloudstack] weizhouapache opened a new pull request #5233: ui bug fix: scalevm is disabled when vm is Stopped

2021-07-22 Thread GitBox
weizhouapache opened a new pull request #5233: URL: https://github.com/apache/cloudstack/pull/5233 ### Description This PR fixes the issue on ui that scalevm button is disabled when vm is stopped. ### Types of changes

[GitHub] [cloudstack] Pearl1594 commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
Pearl1594 commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-884746630 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5231: api: Fix pagination for list PublicIPAddresses

2021-07-22 Thread GitBox
blueorangutan commented on pull request #5231: URL: https://github.com/apache/cloudstack/pull/5231#issuecomment-884747233 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

  1   2   >