[GitHub] [cloudstack] rhtyd commented on pull request #4141: [New feature] Load balancer customization (haproxy-based)

2021-09-13 Thread GitBox
rhtyd commented on pull request #4141: URL: https://github.com/apache/cloudstack/pull/4141#issuecomment-918865984 Ping @weizhouapache I think some more work may be needed on this as now Debian 11 has moved to haproxy 2.x, should this be targeted for next milestone. I worry it may not be st

[GitHub] [cloudstack] weizhouapache commented on pull request #4634: Display vlan ip range for specified domainid

2021-09-13 Thread GitBox
weizhouapache commented on pull request #4634: URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-918864973 > > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer` > > > > > > > > > > > > @DaanHoogland any idea where els

[GitHub] [cloudstack] rhtyd commented on issue #3689: Add LDAP account button is not being shown when ldap configuration is added at domain level

2021-09-13 Thread GitBox
rhtyd commented on issue #3689: URL: https://github.com/apache/cloudstack/issues/3689#issuecomment-918864889 It has a closable label, can it be closed @DaanHoogland @borisstoyanov @andrijapanicsb? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918863599 @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an aut

[GitHub] [cloudstack] rhtyd commented on pull request #4687: [WIP] - refactor: remove trailing whitespace from Python files

2021-09-13 Thread GitBox
rhtyd commented on pull request #4687: URL: https://github.com/apache/cloudstack/pull/4687#issuecomment-918863606 Ping @jbampton are you working on this, can you resolve conflicts? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
nvazquez commented on pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918863101 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] rhtyd commented on pull request #4875: Fix data volume import / export functionality when using swift as secondary storage

2021-09-13 Thread GitBox
rhtyd commented on pull request #4875: URL: https://github.com/apache/cloudstack/pull/4875#issuecomment-918862818 Ping @skattoju4 can you fix conflicts and address comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5310: Support docker builds for ubuntu 20.04

2021-09-13 Thread GitBox
rhtyd commented on a change in pull request #5310: URL: https://github.com/apache/cloudstack/pull/5310#discussion_r707963322 ## File path: debian/control ## @@ -2,8 +2,7 @@ Source: cloudstack Section: libs Priority: extra Maintainer: Wido den Hollander -Build-Depends: debhe

[GitHub] [cloudstack] rhtyd commented on pull request #4977: Enable creation of vms with solidfire root volumes on vmware67

2021-09-13 Thread GitBox
rhtyd commented on pull request #4977: URL: https://github.com/apache/cloudstack/pull/4977#issuecomment-918861000 Ping @skattoju4 any update on this for 4.16, would it say be ready in two weeks (which is tentative date for cutting RC) -- This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd edited a comment on issue #5189: Kubuntu returns Neon which causes error

2021-09-13 Thread GitBox
rhtyd edited a comment on issue #5189: URL: https://github.com/apache/cloudstack/issues/5189#issuecomment-918858018 Hi @abdelouahabb community can't commit to supporting and testing non-LTS and non-mainstream distros. But we'll be happy to accept any PRs if somebody wants to maintain suppo

[GitHub] [cloudstack] rhtyd commented on issue #5189: Kubuntu returns Neon which causes error

2021-09-13 Thread GitBox
rhtyd commented on issue #5189: URL: https://github.com/apache/cloudstack/issues/5189#issuecomment-918858018 Hi @abdelouahabb community can't commit to supporting and testing non-LTS and non-mainstream distros. But we'll be happy to accept any PRs of somebody wants to maintain support for

[GitHub] [cloudstack] rhtyd closed issue #5189: Kubuntu returns Neon which causes error

2021-09-13 Thread GitBox
rhtyd closed issue #5189: URL: https://github.com/apache/cloudstack/issues/5189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918857373 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1231 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5446: OVS/GRE: bug fixes

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5446: URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918855003 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests -- This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] rhtyd commented on issue #5433: KVM problem with volume snapshots kept only on the primary storage (non-managed storages)

2021-09-13 Thread GitBox
rhtyd commented on issue #5433: URL: https://github.com/apache/cloudstack/issues/5433#issuecomment-918854574 @slavkap thanks, I suggest that you start a discussion thread on dev@ ML as a lot of people don't check/read Github comments (I'm guilty of that too). -- This is an automated mes

[GitHub] [cloudstack] weizhouapache commented on pull request #5446: OVS/GRE: bug fixes

2021-09-13 Thread GitBox
weizhouapache commented on pull request #5446: URL: https://github.com/apache/cloudstack/pull/5446#issuecomment-918853825 @blueorangutan test centos7 xenserver-71 keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [cloudstack] blueorangutan commented on pull request #3724: Storage-based Snapshots for KVM VMs

2021-09-13 Thread GitBox
blueorangutan commented on pull request #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-918852225 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #3724: Storage-based Snapshots for KVM VMs

2021-09-13 Thread GitBox
rhtyd commented on pull request #3724: URL: https://github.com/apache/cloudstack/pull/3724#issuecomment-918851942 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #3804: Display capability info in listNetwork response

2021-09-13 Thread GitBox
blueorangutan commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-918851041 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #3804: Display capability info in listNetwork response

2021-09-13 Thread GitBox
rhtyd commented on pull request #3804: URL: https://github.com/apache/cloudstack/pull/3804#issuecomment-918850092 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] rhtyd commented on pull request #4230: Enable resetting config values to default value

2021-09-13 Thread GitBox
rhtyd commented on pull request #4230: URL: https://github.com/apache/cloudstack/pull/4230#issuecomment-918848446 Ping @ravening can you fix build failure? I like this feature, would be really useful for users. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [cloudstack] blueorangutan commented on pull request #4438: Prometheus exporter enhancement

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4438: URL: https://github.com/apache/cloudstack/pull/4438#issuecomment-918848245 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] blueorangutan commented on pull request #4276: ListAll including VMs in projects for ADMIN

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4276: URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-918848227 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4259: Reserve memory for host

2021-09-13 Thread GitBox
rhtyd commented on pull request #4259: URL: https://github.com/apache/cloudstack/pull/4259#issuecomment-918848007 Ping @ravening -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN

2021-09-13 Thread GitBox
rhtyd commented on pull request #4276: URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-918847825 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] rhtyd commented on pull request #4438: Prometheus exporter enhancement

2021-09-13 Thread GitBox
rhtyd commented on pull request #4438: URL: https://github.com/apache/cloudstack/pull/4438#issuecomment-918847201 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] rhtyd commented on pull request #4634: Display vlan ip range for specified domainid

2021-09-13 Thread GitBox
rhtyd commented on pull request #4634: URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-918847002 Ping @ravening can you address review and fix conflicts, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [cloudstack] blueorangutan commented on pull request #4635: Persist vpn connection state before restarting

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4635: URL: https://github.com/apache/cloudstack/pull/4635#issuecomment-918846031 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4635: Persist vpn connection state before restarting

2021-09-13 Thread GitBox
rhtyd commented on pull request #4635: URL: https://github.com/apache/cloudstack/pull/4635#issuecomment-918845869 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] rhtyd commented on pull request #4641: Speed up SSVM startup time by postponing checks

2021-09-13 Thread GitBox
rhtyd commented on pull request #4641: URL: https://github.com/apache/cloudstack/pull/4641#issuecomment-918844695 Pl discuss on dev@, in my opinion this should be closed as postponing check isn't something we would want. The tradeoff of speedup vs check needs to be discussed. -- This i

[GitHub] [cloudstack] rhtyd commented on pull request #4708: kvm: Handle storage issue on NFS/KVM in multiple ways

2021-09-13 Thread GitBox
rhtyd commented on pull request #4708: URL: https://github.com/apache/cloudstack/pull/4708#issuecomment-918844081 Ping @weizhouapache can you fix the conflicts, is this essential for 4.16? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5448: URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918843532 Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1229 -- This is an automated message

[GitHub] [cloudstack] rhtyd commented on pull request #4741: VM has wrong network statistics with multiple nics in shared networks

2021-09-13 Thread GitBox
rhtyd commented on pull request #4741: URL: https://github.com/apache/cloudstack/pull/4741#issuecomment-918843645 Ping @ravening can you fix conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #5410: CloudStack fails to migrate VM with volume when there are datadisks attatched

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5410: URL: https://github.com/apache/cloudstack/pull/5410#issuecomment-918843531 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1230 -- This is an automated message from

[cloudstack] branch main updated: server: skip max guest limit check for KVM host (#5417)

2021-09-13 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new fb8d40d server: skip max guest limit check fo

[GitHub] [cloudstack] blueorangutan commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4826: URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-918839765 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] nvazquez closed issue #3015: Hypervisor max guest limit

2021-09-13 Thread GitBox
nvazquez closed issue #3015: URL: https://github.com/apache/cloudstack/issues/3015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [cloudstack] nvazquez merged pull request #5417: server: skip max guest limit check for KVM host

2021-09-13 Thread GitBox
nvazquez merged pull request #5417: URL: https://github.com/apache/cloudstack/pull/5417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] rhtyd commented on pull request #4826: Allow storage plugins to get storage/volume stats without sending commands to hosts

2021-09-13 Thread GitBox
rhtyd commented on pull request #4826: URL: https://github.com/apache/cloudstack/pull/4826#issuecomment-918839114 We need test matrix on this @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] rhtyd commented on pull request #4890: Universal sshkey and password manager script

2021-09-13 Thread GitBox
rhtyd commented on pull request #4890: URL: https://github.com/apache/cloudstack/pull/4890#issuecomment-918838470 Ping @aleskxyz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] rhtyd edited a comment on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-09-13 Thread GitBox
rhtyd edited a comment on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-918837390 We need test matrix on this @nvazquez General note: such a refactoring PR worries me closer to a RC, I've seen my share of blockers which get introduced due to refacto

[GitHub] [cloudstack] blueorangutan commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-918837818 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] xuanyuanaosheng commented on issue #5443: How to configure the OpenVswitch using bond on Centos 8 or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng commented on issue #5443: URL: https://github.com/apache/cloudstack/issues/5443#issuecomment-918837787 https://github.com/apache/cloudstack/issues/5426 https://github.com/apache/cloudstack/issues/5409 -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-09-13 Thread GitBox
rhtyd commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-918837390 We need test matrix on this @nvazquez General note: such a refactoring PR worries me closer to a RC, I've seen my share of blockers which get introduced due to refactoring ch

[GitHub] [cloudstack] xuanyuanaosheng closed issue #5409: How to configure the OpenVswitch using Single network card on Centos 8 Or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng closed issue #5409: URL: https://github.com/apache/cloudstack/issues/5409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [cloudstack] xuanyuanaosheng closed issue #5426: How to configure the OpenVswitch using bond on Centos 7 or Oracle 7?

2021-09-13 Thread GitBox
xuanyuanaosheng closed issue #5426: URL: https://github.com/apache/cloudstack/issues/5426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [cloudstack] xuanyuanaosheng closed issue #5443: How to configure the OpenVswitch using bond on Centos 8 or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng closed issue #5443: URL: https://github.com/apache/cloudstack/issues/5443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [cloudstack] nvazquez commented on pull request #5388: kvm: honor migrate.wait and abort vm migration job

2021-09-13 Thread GitBox
nvazquez commented on pull request #5388: URL: https://github.com/apache/cloudstack/pull/5388#issuecomment-918835678 Hi @NuxRo kindly update/review after your tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack] rhtyd commented on pull request #4994: Linstor volume plugin

2021-09-13 Thread GitBox
rhtyd commented on pull request #4994: URL: https://github.com/apache/cloudstack/pull/4994#issuecomment-918835114 @rp- can you fix the conflicts? I think this is otherwise good to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] xuanyuanaosheng commented on issue #5409: How to configure the OpenVswitch using Single network card on Centos 8 Or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng commented on issue #5409: URL: https://github.com/apache/cloudstack/issues/5409#issuecomment-918834964 1. https://github.com/apache/cloudstack/issues/5426 2. https://github.com/apache/cloudstack/issues/5443 -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-918832603 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] Pearl1594 commented on pull request #5157: UI: Support to upload resource icons

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-918832031 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] xuanyuanaosheng commented on issue #5426: How to configure the OpenVswitch using bond on Centos 7 or Oracle 7?

2021-09-13 Thread GitBox
xuanyuanaosheng commented on issue #5426: URL: https://github.com/apache/cloudstack/issues/5426#issuecomment-918830985 @weizhouapache It just like a magic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5369: kvm: Add check if host meets the minimum requirements

2021-09-13 Thread GitBox
rhtyd commented on a change in pull request #5369: URL: https://github.com/apache/cloudstack/pull/5369#discussion_r707934720 ## File path: python/lib/cloudutils/serviceConfig.py ## @@ -495,6 +495,30 @@ def config(self): logging.debug(formatExceptionInfo())

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-918830029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5369: kvm: Add check if host meets the minimum requirements

2021-09-13 Thread GitBox
rhtyd commented on a change in pull request #5369: URL: https://github.com/apache/cloudstack/pull/5369#discussion_r707934127 ## File path: python/lib/cloudutils/serviceConfig.py ## @@ -495,6 +495,30 @@ def config(self): logging.debug(formatExceptionInfo())

[GitHub] [cloudstack] rhtyd commented on pull request #5419: CPVM: use X509ExtendedTrustManager to skip hostname verification

2021-09-13 Thread GitBox
rhtyd commented on pull request #5419: URL: https://github.com/apache/cloudstack/pull/5419#issuecomment-918827252 cc @DaanHoogland @nvazquez @davidjumani - do we know what causes so many smoketest failures with Vmware7, can we fix them? -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] rhtyd commented on pull request #5424: Updated pod response, grouped the parameters: "startip, endip, vlanid, forsystemvms" as ip range response and added to ipranges parameter.

2021-09-13 Thread GitBox
rhtyd commented on pull request #5424: URL: https://github.com/apache/cloudstack/pull/5424#issuecomment-918826775 @sureshanaparti pl fix conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
rhtyd commented on pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447#issuecomment-918826489 Ah okay that makes sense, maybe we can add a dummy ID of 0 for default view? But this change also LGTM if it works. -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] rhtyd commented on pull request #5448: [Vmware] Fix for ovf templates with prefix

2021-09-13 Thread GitBox
rhtyd commented on pull request #5448: URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918826064 Hi @nvazquez do we know what causes the prefix to be added? Is this due to exporting ovf template from vmware, virtualbox or something else? -- This is an automated message

[cloudstack] branch main updated (7c7b624 -> c85eb10)

2021-09-13 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 7c7b624 ui: Fix Scale VM failure - missing args when customized compute offering is used (#5439) add c85eb10

[GitHub] [cloudstack] rhtyd merged pull request #5421: server: fix addCluster for vmware, others

2021-09-13 Thread GitBox
rhtyd merged pull request #5421: URL: https://github.com/apache/cloudstack/pull/5421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [cloudstack] Pearl1594 commented on pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447#issuecomment-918825118 > LGTM but instead of comparing objects should we compare the ID of new and old values? @rhtyd There isn't an id (project ID) for default view - which was the reason

[cloudstack] branch main updated: ui: Fix Scale VM failure - missing args when customized compute offering is used (#5439)

2021-09-13 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 7c7b624 ui: Fix Scale VM failure - missing ar

[GitHub] [cloudstack] nvazquez merged pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected

2021-09-13 Thread GitBox
nvazquez merged pull request #5439: URL: https://github.com/apache/cloudstack/pull/5439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] Pearl1594 commented on pull request #5425: api: Update DNS on changing VM name

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5425: URL: https://github.com/apache/cloudstack/pull/5425#issuecomment-918824265 Sure @nvazquez - I am currently working towards refactoring based on provided comments. I think @shwstppr's point is valid as well. -- This is an automated message from

[GitHub] [cloudstack] nvazquez edited a comment on pull request #5425: api: Update DNS on changing VM name

2021-09-13 Thread GitBox
nvazquez edited a comment on pull request #5425: URL: https://github.com/apache/cloudstack/pull/5425#issuecomment-918823121 @shwstppr I think your remark makes sense, @Pearl1594 do you think that can be included on this PR or maybe on a separate one? Also, can you please address the other

[GitHub] [cloudstack] nvazquez commented on pull request #5425: api: Update DNS on changing VM name

2021-09-13 Thread GitBox
nvazquez commented on pull request #5425: URL: https://github.com/apache/cloudstack/pull/5425#issuecomment-918823121 @shwstppr I think your remark makes sense, @Pearl1594 do you think that can be included on this PR or maybe a separate one? Also, can you please address the other open comme

[GitHub] [cloudstack] blueorangutan commented on pull request #4966: Refactor few process of VirtualMachineManagerImpl and improve logs

2021-09-13 Thread GitBox
blueorangutan commented on pull request #4966: URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-918822240 Trillian test result (tid-2029) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34697 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-918821439 Trillian test result (tid-2025) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43708 seconds Marvin logs: https://githu

[GitHub] [cloudstack] nvazquez commented on issue #5308: VMWare host do not receive commands to cleanup nics

2021-09-13 Thread GitBox
nvazquez commented on issue #5308: URL: https://github.com/apache/cloudstack/issues/5308#issuecomment-918820374 @weizhouapache there is a corner please in which finalizaExpungeNics returns a list of commands but these commands are never sent to the hypervisor, please check #5449, -- Th

[GitHub] [cloudstack] blueorangutan commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918819785 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
nvazquez commented on pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449#issuecomment-918819278 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] nvazquez opened a new pull request #5449: [Vmware] Add missing condition to cleanup nics if there are commands to send

2021-09-13 Thread GitBox
nvazquez opened a new pull request #5449: URL: https://github.com/apache/cloudstack/pull/5449 ### Description This PR allows cleaning up nics in case there are nicExpunge commands to be sent Fixes: #5308 ### Types of changes - [ ] Breaking change (fix or featur

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-918816706 Trillian test result (tid-2024) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43320 seconds Marvin logs: https://gith

[GitHub] [cloudstack] rp- commented on issue #5433: KVM problem with volume snapshots kept only on the primary storage (non-managed storages)

2021-09-13 Thread GitBox
rp- commented on issue #5433: URL: https://github.com/apache/cloudstack/issues/5433#issuecomment-918816315 For me(or Linstors POV) it make no sense (and doesn't work) to have snapshots without the volume. So deleting would be fine for me, also in Linstor you can't delete a volume as lon

[GitHub] [cloudstack] xuanyuanaosheng edited a comment on issue #5443: How to configure the OpenVswitch using bond on Centos 8 or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng edited a comment on issue #5443: URL: https://github.com/apache/cloudstack/issues/5443#issuecomment-918813184 1. I restart using the kernel : Linux (hostname) 5.4.17-2011.7.4.el8uek.x86_64 #2 SMP Fri Oct 2 14:39:04 PDT 2020 x86_64 x86_64 x86_64 GNU/Linux 2.sys

[GitHub] [cloudstack] nvazquez closed issue #5336: Public IP for system VM is unreachable

2021-09-13 Thread GitBox
nvazquez closed issue #5336: URL: https://github.com/apache/cloudstack/issues/5336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [cloudstack] nvazquez commented on pull request #5362: Support Ubuntu 21.04

2021-09-13 Thread GitBox
nvazquez commented on pull request #5362: URL: https://github.com/apache/cloudstack/pull/5362#issuecomment-918813684 Ping @tetra12 can you please address the open comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] xuanyuanaosheng commented on issue #5443: How to configure the OpenVswitch using bond on Centos 8 or Oracle 8?

2021-09-13 Thread GitBox
xuanyuanaosheng commented on issue #5443: URL: https://github.com/apache/cloudstack/issues/5443#issuecomment-918813184 1. I restart using the kernel : Linux (hostname) 5.4.17-2011.7.4.el8uek.x86_64 #2 SMP Fri Oct 2 14:39:04 PDT 2020 x86_64 x86_64 x86_64 GNU/Linux 2.systemctl

[GitHub] [cloudstack] blueorangutan commented on pull request #5410: CloudStack fails to migrate VM with volume when there are datadisks attatched

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5410: URL: https://github.com/apache/cloudstack/pull/5410#issuecomment-918811388 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5410: CloudStack fails to migrate VM with volume when there are datadisks attatched

2021-09-13 Thread GitBox
nvazquez commented on pull request #5410: URL: https://github.com/apache/cloudstack/pull/5410#issuecomment-918811171 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] weizhouapache commented on issue #5443: How to configure the OpenVswitch using bond on Centos 8 or Oracle 8?

2021-09-13 Thread GitBox
weizhouapache commented on issue #5443: URL: https://github.com/apache/cloudstack/issues/5443#issuecomment-918809956 > The openvswitch config will become the below when I restart the network. > > ![image](https://user-images.githubusercontent.com/4197714/133191973-b16f866b-bc58-47de-

[GitHub] [cloudstack] blueorangutan commented on pull request #5448: [Vmware] Fix for ovf templates with prefix

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5448: URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918806725 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] nvazquez commented on pull request #5448: [Vmware] Fix for ovf templates with prefix

2021-09-13 Thread GitBox
nvazquez commented on pull request #5448: URL: https://github.com/apache/cloudstack/pull/5448#issuecomment-918806338 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] nvazquez opened a new pull request #5448: [Vmware] Fix for ovf templates with prefix

2021-09-13 Thread GitBox
nvazquez opened a new pull request #5448: URL: https://github.com/apache/cloudstack/pull/5448 ### Description This PR adds a "ovf" prefix check on Vmware template OVF files. Fixes: #5415 ### Types of changes - [ ] Breaking change (fix or feature that would cause

[GitHub] [cloudstack] blueorangutan commented on pull request #5157: UI: Support to upload resource icons

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-918800559 @Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] Pearl1594 commented on pull request #5157: UI: Support to upload resource icons

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5157: URL: https://github.com/apache/cloudstack/pull/5157#issuecomment-918799802 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [cloudstack] blueorangutan commented on pull request #5428: resource limit: Fix resource limit check on VM start

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5428: URL: https://github.com/apache/cloudstack/pull/5428#issuecomment-918797929 @Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5428: resource limit: Fix resource limit check on VM start

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5428: URL: https://github.com/apache/cloudstack/pull/5428#issuecomment-918797602 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] blueorangutan commented on pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447#issuecomment-918796628 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5447 (SL-JID-647) -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] blueorangutan commented on pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447#issuecomment-918795136 @Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] Pearl1594 commented on pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
Pearl1594 commented on pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447#issuecomment-918794889 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [cloudstack] blueorangutan commented on pull request #5201: [HEALTH] 4.16 Health Checks - Please don't merge

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5201: URL: https://github.com/apache/cloudstack/pull/5201#issuecomment-918794723 Trillian test result (tid-2026) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39480 seconds Marvin logs: https://githu

[GitHub] [cloudstack] Pearl1594 commented on issue #5440: Dashboard/project UI issues as user account role

2021-09-13 Thread GitBox
Pearl1594 commented on issue #5440: URL: https://github.com/apache/cloudstack/issues/5440#issuecomment-918794555 @rhtyd @nvazquez regarding step #2 i.e., On creation of a project - the project tab doesn't auto-refresh, I was able to reproduce the issue, but on clearing the cache - surprisi

[GitHub] [cloudstack] Pearl1594 opened a new pull request #5447: ui: Refresh Usage dashboard when swapping between Project and Default view

2021-09-13 Thread GitBox
Pearl1594 opened a new pull request #5447: URL: https://github.com/apache/cloudstack/pull/5447 ### Description This PR fixes https://github.com/apache/cloudstack/issues/5440 - where we notice that when logged in with a User role, and on swapping between project and default view, the

[GitHub] [cloudstack] blueorangutan commented on pull request #5419: CPVM: use X509ExtendedTrustManager to skip hostname verification

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5419: URL: https://github.com/apache/cloudstack/pull/5419#issuecomment-918779265 Trillian test result (tid-2016) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47889 seconds Marvin logs: https://gith

[GitHub] [cloudstack] nvazquez commented on issue #5418: Hide SSO Provider URL

2021-09-13 Thread GitBox
nvazquez commented on issue #5418: URL: https://github.com/apache/cloudstack/issues/5418#issuecomment-918778177 Thanks @rhtyd - @ngrosc does it fix the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack] blueorangutan commented on pull request #5419: CPVM: use X509ExtendedTrustManager to skip hostname verification

2021-09-13 Thread GitBox
blueorangutan commented on pull request #5419: URL: https://github.com/apache/cloudstack/pull/5419#issuecomment-918778111 Trillian test result (tid-2015) Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53170 seconds Marvin logs: https://githu

[GitHub] [cloudstack] nvazquez commented on issue #5433: KVM problem with volume snapshots kept only on the primary storage (non-managed storages)

2021-09-13 Thread GitBox
nvazquez commented on issue #5433: URL: https://github.com/apache/cloudstack/issues/5433#issuecomment-918776474 Thanks @slavkap - looping @andrijapanicsb @sureshanaparti as well for feedback/discussion -- This is an automated message from the Apache Git Service. To respond to the message

  1   2   3   >