Re: [PR] feature: webhooks [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-1980277231 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] feature: webhooks [cloudstack]

2024-03-05 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-1980275708 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

(cloudstack) branch 4.18 updated: SG: fix SQL exception when add security group rule with allowed account/group (#8616)

2024-03-05 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.18 by this push: new 986d754768d SG: fix SQL exception when add secu

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
weizhouapache merged PR #8616: URL: https://github.com/apache/cloudstack/pull/8616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
weizhouapache commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1980239411 Merging based on approvals and manual/smoke test results -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(cloudstack-terraform-provider) branch main updated: added noderootdisksize parameter (#90)

2024-03-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new 35307e1 added noderootdisksi

(cloudstack-terraform-provider) branch main updated: Update details if changed for an instance (#91)

2024-03-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new 5be794b Update details if ch

(cloudstack-terraform-provider) branch main updated: Support adding templates in all zones (#92)

2024-03-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new 976e564 Support adding templ

Re: [I] Host evacuation after KVM Host failed [cloudstack]

2024-03-05 Thread via GitHub
boring-cyborg[bot] commented on issue #8749: URL: https://github.com/apache/cloudstack/issues/8749#issuecomment-1979918432 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] Host evacuation after KVM Host failed [cloudstack]

2024-03-05 Thread via GitHub
Psyma opened a new issue, #8749: URL: https://github.com/apache/cloudstack/issues/8749 # ISSUE TYPE * Other # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION # OS / ENVI

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1979862306 [SF] Trillian test result (tid-9394) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 52646 seconds Marvin logs: https://github.co

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1979853869 [SF] Trillian test result (tid-9398) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40986 seconds Marvin logs: https://github.com

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1979778573 [SF] Trillian test result (tid-9395) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47264 seconds Marvin logs: https://github.com

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1979754212 [SF] Trillian test result (tid-9393) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46035 seconds Marvin logs: https://github.co

Re: [PR] Quota email configuration [cloudstack]

2024-03-05 Thread via GitHub
winterhazel commented on PR #8307: URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-1979546446 I tested the feature introduced in this PR. It seems to be working as intended. First, I configured Quota to send e-mails. I also created an account with my e-mail, added 9

Re: [PR] Add indexes for vm_stats [cloudstack]

2024-03-05 Thread via GitHub
vishesh92 commented on PR #8737: URL: https://github.com/apache/cloudstack/pull/8737#issuecomment-1979497377 > @vishesh92 could you share a description of the tests that you've done and their results? Sure. I created a table with 661683 entries for timestamp ranging from `1970-11-29`

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-03-05 Thread via GitHub
vishesh92 commented on code in PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513378431 ## framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java: ## @@ -1208,9 +1208,14 @@ public boolean expunge(final ID id) { } } -// F

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-03-05 Thread via GitHub
vishesh92 commented on code in PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513377957 ## framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java: ## @@ -1223,6 +1228,11 @@ public int expunge(final SearchCriteria sc) { str.appe

[I] volume was locked forever as "migration in progress" [cloudstack]

2024-03-05 Thread via GitHub
jhondoue opened a new issue, #8748: URL: https://github.com/apache/cloudstack/issues/8748 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VolumeManagemet,Migration ~~~ # CLOUDSTACK VERSION ~~~ 4.18.1 ~~~ # C

Re: [PR] Fix `deleteAccount` API to prevent deletion of the caller [cloudstack]

2024-03-05 Thread via GitHub
lucas-a-martins commented on code in PR #8743: URL: https://github.com/apache/cloudstack/pull/8743#discussion_r1513234550 ## server/src/main/java/com/cloud/user/AccountManagerImpl.java: ## @@ -1815,7 +1815,15 @@ public boolean deleteUserAccount(long accountId) { // If t

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-03-05 Thread via GitHub
JoaoJandre commented on code in PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513204284 ## framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java: ## @@ -1208,9 +1208,14 @@ public boolean expunge(final ID id) { } } -//

Re: [PR] Add indexes for vm_stats [cloudstack]

2024-03-05 Thread via GitHub
JoaoJandre commented on PR #8737: URL: https://github.com/apache/cloudstack/pull/8737#issuecomment-1979253335 > > Hey, @vishesh92 > > Adding the `vm_stats` -> `timestamp` index to the table might not produce the effect that you want. When deleting very specific rows, adding an index to t

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1978724141 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8856 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1978722141 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8855 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[I] ROOT volume got deleted in failure to migrate [cloudstack]

2024-03-05 Thread via GitHub
rajujith opened a new issue, #8747: URL: https://github.com/apache/cloudstack/issues/8747 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMware, Migration ~~~ # CLOUDSTACK VERSION ~~~ 4.17.2 ~~~ # OS /

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-03-05 Thread via GitHub
JoaoJandre commented on code in PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1512752381 ## server/src/main/java/com/cloud/server/StatsCollector.java: ## @@ -290,6 +287,11 @@ public String toString() { protected static ConfigKey vmStatsCollectUse

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1978666781 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
sureshanaparti commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1978665354 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Unable to create a instance on hyper-v host [cloudstack]

2024-03-05 Thread via GitHub
kedupuganti-kub commented on issue #8738: URL: https://github.com/apache/cloudstack/issues/8738#issuecomment-1978626264 I have tried to https://github.com/apache/cloudstack/pull/7692 tried in this way but the problem here the error which i am getting is 22 port on hyperv and s

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1978611527 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8854 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1978600707 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-03-05 Thread via GitHub
DaanHoogland commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-1978600140 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1978572088 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
vishesh92 commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1978570021 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1978489978 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] SG: fix SQL exception when add security group rule with allowed account/group [cloudstack]

2024-03-05 Thread via GitHub
weizhouapache commented on PR #8616: URL: https://github.com/apache/cloudstack/pull/8616#issuecomment-1978487654 > clgtm and confirmed in lab-env that rules can be added after creating a VM with the SG assigned great, thanks @DaanHoogland ! @blueorangutan package -- This is

Re: [PR] Support KVM storage implementations controlling logical/physical block io size [cloudstack]

2024-03-05 Thread via GitHub
sureshanaparti commented on PR #8724: URL: https://github.com/apache/cloudstack/pull/8724#issuecomment-1978429363 Hi @mlsorensen can this be targeted for 4.19.1? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Log4j2 refactor cloud api module [cloudstack]

2024-03-05 Thread via GitHub
DaanHoogland commented on PR #8728: URL: https://github.com/apache/cloudstack/pull/8728#issuecomment-1978428601 > > clgtm, I think we need to implement some policies on when to log stack traces though. cc @JoaoJandre > > I think that some guidelines would be good, sadly the discussion

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1978306012 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- Thi

Re: [PR] Fix resource count discrepancies [cloudstack]

2024-03-05 Thread via GitHub
rohityadavcloud commented on PR #8302: URL: https://github.com/apache/cloudstack/pull/8302#issuecomment-1978305125 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

(cloudstack-terraform-provider) branch main updated: added podid (#89)

2024-03-05 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-terraform-provider.git The following commit(s) were added to refs/heads/main by this push: new c8279b9 added podid (#89) c8

Re: [PR] feature: webhooks [cloudstack]

2024-03-05 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-1978283558 [SF] Trillian test result (tid-9390) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 51048 seconds Marvin logs: https://github.com

[I] haproxy misconfiguration after restarting VPC with cleanup [cloudstack]

2024-03-05 Thread via GitHub
weizhouapache opened a new issue, #8745: URL: https://github.com/apache/cloudstack/issues/8745 Steps to reproduce the issue - Create 1 VPC - create 2 VPC tiers, and a VM on each VPC tier - acquire 2 public IPs - create LB rules to the VM in each tier The VR has correct

Re: [PR] Log4j2 refactor cloud engine orchestration module [cloudstack]

2024-03-05 Thread via GitHub
codecov[bot] commented on PR #8742: URL: https://github.com/apache/cloudstack/pull/8742#issuecomment-1978171319 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8742?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] VR: fix dnmasq misconfiguration if there are multiple IP ranges in a shared network [cloudstack]

2024-03-05 Thread via GitHub
sureshanaparti commented on code in PR #8741: URL: https://github.com/apache/cloudstack/pull/8741#discussion_r1512295137 ## systemvm/debian/opt/cloud/bin/cs/CsHelper.py: ## @@ -113,22 +113,20 @@ def bool_to_yn(val): def get_device_info(): """ Returns all devices on system