Re: [I] Disk offering doesn't change when resize operation is performed [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on issue #8413: URL: https://github.com/apache/cloudstack/issues/8413#issuecomment-2159931442 > > as far as I know, `size` is just a property of `disk offering`. `disk offering` has other properties, for instance, storage type, QoS, service offering, etc. I think the

Re: [PR] List volumes by service offering id [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9211: URL: https://github.com/apache/cloudstack/pull/9211#issuecomment-2159929218 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9211?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#discussion_r1634287418 ## engine/storage/src/main/java/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java: ## @@ -536,7 +536,7 @@ private Integer getCopyCmdsCountToSpec

Re: [PR] List volumes by service offering id [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9211: URL: https://github.com/apache/cloudstack/pull/9211#issuecomment-2159919230 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix NPE when sending copy command to least busy SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on PR #9125: URL: https://github.com/apache/cloudstack/pull/9125#issuecomment-2159918549 @winterhazel , do you think my comment is worth your effort now? If not I'll add a suggestion for a comment for later work. -- This is an automated message from the Apache Git S

Re: [PR] List volumes by service offering id [cloudstack]

2024-06-10 Thread via GitHub
vishesh92 commented on PR #9211: URL: https://github.com/apache/cloudstack/pull/9211#issuecomment-2159916471 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] List volumes by service offering id [cloudstack]

2024-06-10 Thread via GitHub
vishesh92 opened a new pull request, #9211: URL: https://github.com/apache/cloudstack/pull/9211 ### Description This PR allows listing of volumes by service offering id. If both service offering id and disk offering id are passed, service offering id is ignored. UI is also updated

(cloudstack) branch 4.19-dummy updated (1c1221fbefb -> c32f8ef7daf)

2024-06-10 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19-dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git discard 1c1221fbefb do not merge add ad66edf6e65 UI: Add search filters (#9068) add 283a4853aad ui: fix create

Re: [I] Disk offering doesn't change when resize operation is performed [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on issue #8413: URL: https://github.com/apache/cloudstack/issues/8413#issuecomment-2159913907 > as far as I know, `size` is just a property of `disk offering`. `disk offering` has other properties, for instance, storage type, QoS, service offering, etc. I think the di

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2159909249 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9857 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

(cloudstack) branch revert-9106-add-volumeresponse-encryptformat deleted (was 2fc55212dc3)

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch revert-9106-add-volumeresponse-encryptformat in repository https://gitbox.apache.org/repos/asf/cloudstack.git was 2fc55212dc3 Revert "api,server: encryptformat in volume response (#9

Re: [I] Bug: UI fails with 503 just after a successful install [cloudstack]

2024-06-10 Thread via GitHub
nizigama commented on issue #8218: URL: https://github.com/apache/cloudstack/issues/8218#issuecomment-2159903098 > Not sure if this is related, but I found that in setting up the db.properties file, the `cluster.node.IP` was getting set to 127.0.1.1, which, is not configured on any of the v

Re: [I] cloud-init not running after boot [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on issue #8129: URL: https://github.com/apache/cloudstack/issues/8129#issuecomment-2159902233 ok, the doc change looks good to me. Any other work, or can we merge the doc and close this, @weizhouapache ? -- This is an automated message from the Apache Git Service. T

Re: [PR] api,server: purge expunged resources [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #8999: URL: https://github.com/apache/cloudstack/pull/8999#issuecomment-2159896873 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,server: purge expunged resources [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #8999: URL: https://github.com/apache/cloudstack/pull/8999#issuecomment-2159896327 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] list by isEncrypted [cloudstack]

2024-06-10 Thread via GitHub
github-actions[bot] commented on PR #8643: URL: https://github.com/apache/cloudstack/pull/8643#issuecomment-2159895641 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [I] Allow Users To Change Guest VM 'Hardware Information' [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on issue #9142: URL: https://github.com/apache/cloudstack/issues/9142#issuecomment-2159892412 @rohityadavcloud , is there an alternative we can propose? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

(cloudstack) branch revert-9106-add-volumeresponse-encryptformat created (now 2fc55212dc3)

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch revert-9106-add-volumeresponse-encryptformat in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 2fc55212dc3 Revert "api,server: encryptformat in volume response (#9

(cloudstack) 01/01: Revert "api,server: encryptformat in volume response (#9106)"

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a commit to branch revert-9106-add-volumeresponse-encryptformat in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 2fc55212dc346e73daee834392c5449d22b46df0 Author: kiranchavala AuthorDat

Re: [I] Security group fields in the listVirtualmachines API call's response doesn't change [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on issue #6999: URL: https://github.com/apache/cloudstack/issues/6999#issuecomment-2159887371 @soreana , kind of, but 'we' are free to postpone as well ;) . On the other hand we can `Severity:Minor` so we can postpone. please adjust the milestone (4.20 or create a 4.1

Re: [PR] ui: refactor global createmenu [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland closed pull request #9139: ui: refactor global createmenu URL: https://github.com/apache/cloudstack/pull/9139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159876619 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9856 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1634245196 ## engine/schema/src/main/resources/META-INF/db/views/cloud.volume_view.sql: ## @@ -39,6 +39,8 @@ SELECT `volumes`.`path` AS `path`, `volumes`.`chain_

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2159861245 [SF] Trillian test result (tid-10406) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 46256 seconds Marvin logs: https://github.co

Re: [PR] Update the java doc for the method disconnectPhysicalDiskByPath [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9210: URL: https://github.com/apache/cloudstack/pull/9210#issuecomment-2159859253 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9210?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

(cloudstack) branch 4.19 updated (fcca3e8f391 -> 7aacbcb559e)

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from fcca3e8f391 api,server: encryptformat in volume response (#9106) add 7aacbcb559e api: listApis should ret

Re: [PR] api: listApis should return params based on caller [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala merged PR #8973: URL: https://github.com/apache/cloudstack/pull/8973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] Fixup startVM on simulator [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9199: URL: https://github.com/apache/cloudstack/pull/9199#issuecomment-2159856346 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9855 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] add `encryptionformat` to volume reponse for admins [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala commented on issue #9014: URL: https://github.com/apache/cloudstack/issues/9014#issuecomment-2159847996 Closing the issue as the pr is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] add `encryptionformat` to volume reponse for admins [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala closed issue #9014: add `encryptionformat` to volume reponse for admins URL: https://github.com/apache/cloudstack/issues/9014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

(cloudstack) branch 4.19 updated: api,server: encryptformat in volume response (#9106)

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new fcca3e8f391 api,server: encryptformat in v

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala merged PR #9106: URL: https://github.com/apache/cloudstack/pull/9106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on code in PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#discussion_r1634228124 ## engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java: ## @@ -532,11 +532,6 @@ public void handleTemplateSync(DataStore

Re: [I] Recurring volume snapshots strange behaviour on 4.19 [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on issue #8780: URL: https://github.com/apache/cloudstack/issues/8780#issuecomment-2159846226 @levindecaro Is this still an issue? - Do you have logs to go with this? - Are the management server and the hosts far apart (lots od latency, other timezone)? - Can

Re: [I] Ability to select account and user in the drop down when adding to the project [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala commented on issue #7216: URL: https://github.com/apache/cloudstack/issues/7216#issuecomment-2159845211 Closing the issue as the PR is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] Ability to select account and user in the drop down when adding to the project [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala closed issue #7216: Ability to select account and user in the drop down when adding to the project URL: https://github.com/apache/cloudstack/issues/7216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(cloudstack) branch 4.19 updated (3f2761ec7c6 -> 3321971adc1)

2024-06-10 Thread kiranchavala
This is an automated email from the ASF dual-hosted git repository. kiranchavala pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3f2761ec7c6 Merge remote-tracking branch 'origin/4.18' into 4.19 add 3321971adc1 UI: Update AddAccountOrU

Re: [PR] UI: Update AddAccountOrUserToProject to show a drop down for account & user [cloudstack]

2024-06-10 Thread via GitHub
kiranchavala merged PR #9072: URL: https://github.com/apache/cloudstack/pull/9072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[PR] Update the java doc for the method disconnectPhysicalDiskByPath [cloudstack]

2024-06-10 Thread via GitHub
harikrishna-patnala opened a new pull request, #9210: URL: https://github.com/apache/cloudstack/pull/9210 ### Description This PR addresses the issue #8789 The original issue is disconnectPhysicalDiskByPath() implementation in FibreChannelAdaptor always returns true irrespecti

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1634221117 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java: ## @@ -0,0 +1,50 @@ +package org.apache.cloudstac

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2159830143 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#issuecomment-2159829293 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [WIP] Storage Filesystem as a First Class Feature [cloudstack]

2024-06-10 Thread via GitHub
github-actions[bot] commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2159829109 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] api,server: encryptformat in volume response [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on code in PR #9106: URL: https://github.com/apache/cloudstack/pull/9106#discussion_r1634213864 ## engine/schema/src/main/resources/META-INF/db/views/cloud.volume_view.sql: ## @@ -39,6 +39,8 @@ SELECT `volumes`.`path` AS `path`, `volumes`.`chain_info

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159811824 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [I] java.lang.NullPointerException while volume list [cloudstack]

2024-06-10 Thread via GitHub
anjanahkarthic commented on issue #9160: URL: https://github.com/apache/cloudstack/issues/9160#issuecomment-2159808023 @DaanHoogland @sureshanaparti After further checking I was able to isolate the issue. One specific ROOT disk list was causing issue. On searching the specific disk in volum

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159805539 @harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make p

[PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-10 Thread via GitHub
harikrishna-patnala opened a new pull request, #9209: URL: https://github.com/apache/cloudstack/pull/9209 ### Description This PR fixes the issue #9190 Encryption type change is not allowed for the root volume during the scaleVM and upgradeVM operations. Same check should be m

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-10 Thread via GitHub
harikrishna-patnala commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2159803810 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] engine/schema: force index in user_vm_view to speed up instance listing [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9198: URL: https://github.com/apache/cloudstack/pull/9198#issuecomment-2159797351 [SF] Trillian test result (tid-10407) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42731 seconds Marvin logs: https://github.co

Re: [PR] Fixup startVM on simulator [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9199: URL: https://github.com/apache/cloudstack/pull/9199#issuecomment-2159792847 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] Fixup startVM on simulator [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud commented on PR #9199: URL: https://github.com/apache/cloudstack/pull/9199#issuecomment-2159792428 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] FibreChannelAdaptor disconnectPhysicalDiskByPath should not always return true [cloudstack]

2024-06-10 Thread via GitHub
harikrishna-patnala commented on issue #8789: URL: https://github.com/apache/cloudstack/issues/8789#issuecomment-2159746054 Thanks @rp- let me add a clear java doc for that purpose and explaining the possible bug. -- This is an automated message from the Apache Git Service. To respond to

[PR] [WIP] Storage Filesystem as a First Class Feature [cloudstack]

2024-06-10 Thread via GitHub
abh1sar opened a new pull request, #9208: URL: https://github.com/apache/cloudstack/pull/9208 ### Description This PR implements Storage filesystem as a first class feature. https://cwiki.apache.org/confluence/display/CLOUDSTACK/Storage+Filesystem+as+a+First+Class+Feature

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2159718697 [SF] Trillian test result (tid-10401) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43304 seconds Marvin logs: https://github.co

Re: [PR] Configure config drive ISO with password file on reinstallation of VM with password-enabled template [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9113: URL: https://github.com/apache/cloudstack/pull/9113#issuecomment-2159552974 [SF] Trillian test result (tid-10400) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42332 seconds Marvin logs: https://github.co

Re: [PR] Download Volume Snapshots [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2159268614 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9850 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Improve error messaging / logs when listing VMs on the remote KVM host (for import) [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9204: URL: https://github.com/apache/cloudstack/pull/9204#issuecomment-2159194362 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2159194321 @sureshanaparti a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
sureshanaparti commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2159192855 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Improve error messaging / logs when listing VMs on the remote KVM host (for import) [cloudstack]

2024-06-10 Thread via GitHub
sureshanaparti commented on PR #9204: URL: https://github.com/apache/cloudstack/pull/9204#issuecomment-2159192480 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Network ACL check is bypassed on Load balancing rules in VPC [cloudstack]

2024-06-10 Thread via GitHub
GutoVeronezi commented on issue #9054: URL: https://github.com/apache/cloudstack/issues/9054#issuecomment-2159179266 Implementing the ACL rules in the `FORWARD` chain is the feature's design. We have some limitations with it for sure; why it was designed that way I cannot tell; however, we

Re: [PR] Download Volume Snapshots [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2159152008 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Download Volume Snapshots [cloudstack]

2024-06-10 Thread via GitHub
JoaoJandre commented on PR #8878: URL: https://github.com/apache/cloudstack/pull/8878#issuecomment-2159150087 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Develocity integration [cloudstack]

2024-06-10 Thread via GitHub
clayburn commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2159132731 Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Develocity integration [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2159095238 > @weizhouapache - an admin can do this. Are you referring to the 4 local build scans from this project? If so, I can ensure this happens @clayburn Yes, can you please

Re: [PR] Develocity integration [cloudstack]

2024-06-10 Thread via GitHub
clayburn commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2159040092 @weizhouapache - an admin can do this. Are you referring to the 4 local build scans from this project? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Develocity integration [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2159035967 @ribafish quick question, is it possible to remove some build scans ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-06-10 Thread via GitHub
gpordeus closed pull request #8689: Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow URL: https://github.com/apache/cloudstack/pull/8689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] engine/schema: force index in user_vm_view to speed up instance listing [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9198: URL: https://github.com/apache/cloudstack/pull/9198#issuecomment-2158848597 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. T

Re: [PR] engine/schema: force index in user_vm_view to speed up instance listing [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud commented on PR #9198: URL: https://github.com/apache/cloudstack/pull/9198#issuecomment-2158847549 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158834961 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To re

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158830967 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add configuration to limit the number of rows deleted from vm_stats [cloudstack]

2024-06-10 Thread via GitHub
JoaoJandre commented on PR #8740: URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2158815915 @vishesh92 @DaanHoogland I agree that if we are to have a configuration for each table it would be too much. However, the configuration that @vishesh92 proposed to use (`detail.batc

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1633511469 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java: ## @@ -0,0 +1,50 @@ +package org.apache.cloudstac

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1633511235 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java: ## @@ -0,0 +1,50 @@ +package org.apache.cloudstac

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1633509894 ## systemvm/debian/opt/cloud/bin/cs/CsHelper.py: ## @@ -221,7 +221,7 @@ def save_iptables(command, iptables_file): def execute2(command, wait=True): """

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2158759809 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9849 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158718735 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9848 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] Network ACL check is bypassed on Load balancing rules in VPC [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on issue #9054: URL: https://github.com/apache/cloudstack/issues/9054#issuecomment-2158691863 > Hello @weizhouapache > > You can check PR #6460 that explains why the LB traffic is not blocked with ACL rules and how to achieve that. thanks @GutoVeronezi f

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2158691785 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9847 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158635096 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9206?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2158621826 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To resp

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-10 Thread via GitHub
vishesh92 commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2158619710 @blueorangutan test keepEnv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] updated install-non-oss with vmware v7.0 and v8.0 [cloudstack]

2024-06-10 Thread via GitHub
rohityadavcloud commented on PR #9205: URL: https://github.com/apache/cloudstack/pull/9205#issuecomment-2158618002 cc @nvazquez @Pearl1594 @oferchen I think what @weizhouapache is more appropriate it’s because most of us or our CI automation don’t use this script anymore. -- This is

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2158610089 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9207?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2158599066 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
sureshanaparti commented on PR #9207: URL: https://github.com/apache/cloudstack/pull/9207#issuecomment-2158596436 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] VMware: VMs can't be started when no secondary storage with enough capacity + wrong messages around secondary storage [cloudstack]

2024-06-10 Thread via GitHub
sureshanaparti commented on issue #8390: URL: https://github.com/apache/cloudstack/issues/8390#issuecomment-2158594503 Hi @andrijapanicsb ACS checks for enough capacity on secondary storage while starting non-user VMs (mainly system VMs), to patch systemvm ISO. In case, no NFS secondary sto

[PR] VMware: Improve error messaging / logs when starting non-user VMs, and secondary storage not available or doesn't have enough capacity [cloudstack]

2024-06-10 Thread via GitHub
sureshanaparti opened a new pull request, #9207: URL: https://github.com/apache/cloudstack/pull/9207 ### Description This PR improves error messaging / logs when starting non-user VMs in VMware, and secondary storage not available or doesn't have enough capacity. It addresses inappro

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
nvazquez commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1633387408 ## systemvm/debian/opt/cloud/bin/cs/CsHelper.py: ## @@ -221,7 +221,7 @@ def save_iptables(command, iptables_file): def execute2(command, wait=True): """ Exe

Re: [I] Network ACL check is bypassed on Load balancing rules in VPC [cloudstack]

2024-06-10 Thread via GitHub
GutoVeronezi commented on issue #9054: URL: https://github.com/apache/cloudstack/issues/9054#issuecomment-2158571946 Hello @weizhouapache You can check PR #6460 that explains why the LB traffic is not blocked with ACL rules and how to achieve that. -- This is an automated message

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158550815 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158548917 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9206: URL: https://github.com/apache/cloudstack/pull/9206#issuecomment-2158548467 this is related to #7485 needs some discussion . cc @shwstppr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] updated install-non-oss with vmware v7.0 and v8.0 [cloudstack]

2024-06-10 Thread via GitHub
codecov[bot] commented on PR #9205: URL: https://github.com/apache/cloudstack/pull/9205#issuecomment-2158545318 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9205?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2158546098 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-10 Thread via GitHub
DaanHoogland commented on PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#issuecomment-2158543839 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] updated install-non-oss with vmware v7.0 and v8.0 [cloudstack]

2024-06-10 Thread via GitHub
oferchen commented on PR #9205: URL: https://github.com/apache/cloudstack/pull/9205#issuecomment-2158541609 > thanks for the pr @oferchen actually more packages are needed see https://github.com/shapeblue/cloudstack-nonoss/blob/main/install-non-ossI also added vsphere and customer connect

[PR] storage: fix private templates are not copied to new image store [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache opened a new pull request, #9206: URL: https://github.com/apache/cloudstack/pull/9206 ### Description when add a new image store, some templates/ISOs are copied, but some are not. ``` 2024-06-10T12:24:50,711 INFO [o.a.c.s.i.TemplateServiceImpl] (qtp776484396-2

  1   2   3   >