(cloudstack) branch 4.19 updated (5c749eced26 -> b2ef53b8a2d)

2024-06-12 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 5c749eced26 logging: httpupload do not warn with exception trace (#9220) add b2ef53b8a2d kvm: replace ISO

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636521466 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java: ## @@ -105,6 +105,7 @@

Re: [I] Data Disks get unavailable when VM is shut down [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on issue #7490: URL: https://github.com/apache/cloudstack/issues/7490#issuecomment-2163087257 I was not able to reproduce the issue when add 6 data disk (7 in total including root disk), the xml has the following ``` # virsh dumpxml i-2-9-VM |grep scsi

(cloudstack) branch main updated: test update and get connected hosts (#9136)

2024-06-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 64593574d88 test update and get connected hosts

Re: [PR] test update and get connected hosts [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland merged PR #9136: URL: https://github.com/apache/cloudstack/pull/9136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] linstor: ui show Server and resource-group fields with custom protocol [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on code in PR #9138: URL: https://github.com/apache/cloudstack/pull/9138#discussion_r1636510486 ## ui/src/views/infra/AddPrimaryStorage.vue: ## @@ -162,7 +162,7 @@ +(form.protocol === 'PreSetup' && hypervisorType ===

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2163067242 > @vishesh92 I tested host-affinity, > > ``` > command="cmk deploy virtualmachine zoneid=5a6557c9-b1e0-4fbf-bca4-7f376a96df65

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on code in PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#discussion_r1636492789 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -5068,31 +5068,66 @@ public Pair, Integer> listHypervisorCapab return new Pair,

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2163017776 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9901 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Develocity integration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2163008235 > * For ASF committers - no data will be shared unless the committer explicitly opts-in by [provisioning an access

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2163004564 @vishesh92 I tested host-affinity, ``` command="cmk deploy virtualmachine zoneid=5a6557c9-b1e0-4fbf-bca4-7f376a96df65

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2163002656 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9900 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] VM allocation on Primary Storage [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on issue #8959: URL: https://github.com/apache/cloudstack/issues/8959#issuecomment-2163001174 @JoaoJandre I don't have much idea about flexible tags. Can you provide an example rule of how someone can use flexible tags in a way similar to `preferred.storage.pool`? --

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on code in PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#discussion_r1636454963 ## server/src/main/java/com/cloud/server/ManagementServerImpl.java: ## @@ -5068,31 +5068,66 @@ public Pair, Integer> listHypervisorCapab return new

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
nvazquez commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1636423903 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/IpTablesHelper.java: ## @@ -0,0 +1,66 @@ +// +// Licensed to the Apache

Re: [I] Unable to start instances with DATA volumes of deploy-as-is template having instance snapshots [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on issue #9180: URL: https://github.com/apache/cloudstack/issues/9180#issuecomment-2162951870 I am able to reproduce the issue by the following steps - register a deploy-as-is template - create a vm - create a datadisk and attach to the vm - create

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2162950482 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9899 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] server: fix resource count updated unmanage vm [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #8169: URL: https://github.com/apache/cloudstack/pull/8169#issuecomment-2162943671 Added steps to reproduce in the PR description. cc @DaanHoogland -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162925420 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9898 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Develocity integration [cloudstack]

2024-06-12 Thread via GitHub
clayburn commented on PR #9167: URL: https://github.com/apache/cloudstack/pull/9167#issuecomment-2162913599 > have we (a) added the token secrets.GE_ACCESS_TOKEN to the repo GE_ACCESS_TOKEN is an org-wide secret for the GitHub Apache org, managed by ASF Infra. As such, it is

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1636379344 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java: ## @@ -1127,14 +1127,14 @@ private void

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1636377895 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java: ## @@ -1128,17 +1126,19 @@ private void

Re: [PR] prevent duplicate ip table rules in SSVM [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on code in PR #8530: URL: https://github.com/apache/cloudstack/pull/8530#discussion_r1636374861 ## services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java: ## @@ -1128,17 +1126,19 @@ private void

Re: [PR] cks: fix list apis response count [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #8701: URL: https://github.com/apache/cloudstack/pull/8701#issuecomment-2162887386 @kiranchavala here is an example in an env without fix, ``` (local)  > list kubernetessupportedversions pagesize=2 page=1 filter=id,name { "count": 2,

(cloudstack-www) branch asf-site updated: Automated CloudStack website deployment completed on branch @ 3c6d5820134baefba3ebddad2fc3cdf921b5f3af

2024-06-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/asf-site by this push: new 9ea94ce2 Automated CloudStack

(cloudstack-www) branch main updated: fix createVMSchedule action name (#215)

2024-06-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/main by this push: new 3c6d5820 fix createVMSchedule action name

(cloudstack) branch main updated: fix createVMSchedule action name (#9226)

2024-06-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 66f7f762636 fix createVMSchedule action name

Re: [PR] fix createVMSchedule action name [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9226: URL: https://github.com/apache/cloudstack/pull/9226#issuecomment-2162881472 Thanks for the PR @ahmedali6 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] fix createVMSchedule action name [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud merged PR #9226: URL: https://github.com/apache/cloudstack/pull/9226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162880582 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] fix createVMSchedule action name [cloudstack]

2024-06-12 Thread via GitHub
boring-cyborg[bot] commented on PR #9226: URL: https://github.com/apache/cloudstack/pull/9226#issuecomment-2162881616 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162877784 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on code in PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#discussion_r1636366530 ## test/integration/smoke/test_cluster_drs.py: ## @@ -256,12 +294,15 @@ def test_02_balanced_drs_algorithm(self): migration["virtualmachineid"]:

Re: [PR] cks: fix list apis response count [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #8701: URL: https://github.com/apache/cloudstack/pull/8701#issuecomment-2162877547 @kiranchavala can you please try giving a pagesize lesser than the number of resources present in the env? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2162869265 @kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] api,server: allow updating hypervisor capabilities with hypervisor and version [cloudstack]

2024-06-12 Thread via GitHub
kiranchavala commented on PR #8475: URL: https://github.com/apache/cloudstack/pull/8475#issuecomment-2162868444 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162865871 > Hi @JoaoJandre, thanks for this suggestion. > > if we consolidate all link clone created VMs after migration, wouldn't that create a massive overhead in storage as they

Re: [PR] Fix error message if specific host does not have capacity [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland closed pull request #9218: Fix error message if specific host does not have capacity URL: https://github.com/apache/cloudstack/pull/9218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] allow users to add description to private gateway and static routes [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on PR #9135: URL: https://github.com/apache/cloudstack/pull/9135#issuecomment-2162857472 @charlesweng , I reviewed your changes and am still a bit confused. The changes look good but they seem to add descriptions to `VpcGateway`s and `Network`s but not to static

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162846405 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9897 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Empty resources in dashboard [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on issue #9045: URL: https://github.com/apache/cloudstack/issues/9045#issuecomment-2162832159 Fixed by https://github.com/apache/cloudstack/pull/9097 Tested on https://qa.cloudstack.cloud/simulator/ using SAML using `rick` @cdfgallo please test latest 4.19

Re: [I] Empty resources in dashboard [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud closed issue #9045: Empty resources in dashboard URL: https://github.com/apache/cloudstack/issues/9045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ui: fix dashboard on saml user login [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2162830739 Fixed by https://github.com/apache/cloudstack/pull/9097 Tested on https://qa.cloudstack.cloud/simulator/ using SAML using `rick` -- This is an automated message from the

Re: [I] Dashboard doesn't update for SAML user upon login [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud closed issue #8950: Dashboard doesn't update for SAML user upon login URL: https://github.com/apache/cloudstack/issues/8950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Dashboard doesn't update for SAML user upon login [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on issue #8950: URL: https://github.com/apache/cloudstack/issues/8950#issuecomment-2162829739 Fixed by https://github.com/apache/cloudstack/pull/9097 Tested on https://qa.cloudstack.cloud/simulator/ using SAML using `rick` -- This is an automated message from

Re: [I] Exceptions in cloud.log related to VMware, while uploading a KVM template/iso "From local" [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland closed issue #8376: Exceptions in cloud.log related to VMware, while uploading a KVM template/iso "From local" URL: https://github.com/apache/cloudstack/issues/8376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(cloudstack) branch 4.19 updated (e2e46e31087 -> 5c749eced26)

2024-06-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from e2e46e31087 ui: fix dashboard on saml user login (#9097) add 5c749eced26 logging: httpupload do not warn with

Re: [PR] logging: httpupload do not warn with exception trace [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on PR #9220: URL: https://github.com/apache/cloudstack/pull/9220#issuecomment-2162824207 log only + gha runs, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Exceptions in cloud.log related to VMware, while uploading a KVM template/iso "From local" [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland commented on issue #8376: URL: https://github.com/apache/cloudstack/issues/8376#issuecomment-2162825198 fixed by #9220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] logging: httpupload do not warn with exception trace [cloudstack]

2024-06-12 Thread via GitHub
DaanHoogland merged PR #9220: URL: https://github.com/apache/cloudstack/pull/9220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
shwstppr commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2162814663 Thanks @rohityadavcloud. Reverted `package-lock.json`. I must've added it by mistake -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2162813064 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Build: support JRE17 for building and sonar check [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2162814351 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636324203 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java: ## @@ -105,6 +105,7 @@

Re: [PR] fix error during kubernetes cluster creation [cloudstack]

2024-06-12 Thread via GitHub
GaOrtiga commented on code in PR #9223: URL: https://github.com/apache/cloudstack/pull/9223#discussion_r1636324016 ## plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java: ## @@ -379,8 +380,8 @@ public VMTemplateVO

(cloudstack) branch 4.19 updated: ui: fix dashboard on saml user login (#9097)

2024-06-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new e2e46e31087 ui: fix dashboard on saml user login

Re: [PR] ui: fix dashboard on saml user login [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud merged PR #9097: URL: https://github.com/apache/cloudstack/pull/9097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ui: fix dashboard on saml user login [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9097: URL: https://github.com/apache/cloudstack/pull/9097#issuecomment-2162809587 LGTM - let me merge this and help test against the QA server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162807531 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] cks: fix events [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9070: URL: https://github.com/apache/cloudstack/pull/9070#issuecomment-2162807801 @shwstppr LGTM but pl check if the package-lock.json needs to be removed and re-added in format/version 1, if only required: ``` npm i --lockfile-version 1 ``` This

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162804829 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
JoaoJandre commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162804001 > @JoaoJandre The constructor and `Type` enum of `MigrationOptions`, and `StorageSystemDataMotionStrategy.createLinkedCloneMigrationOptions` are now dead code. > >

Re: [PR] Normalizing volume consolidation in live migration on KVM [cloudstack]

2024-06-12 Thread via GitHub
github-actions[bot] commented on PR #8911: URL: https://github.com/apache/cloudstack/pull/8911#issuecomment-2162798451 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache

Re: [PR] make server threads configurable with server.properties file [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on code in PR #9165: URL: https://github.com/apache/cloudstack/pull/9165#discussion_r1636310899 ## client/src/main/java/org/apache/cloudstack/ServerDaemon.java: ## @@ -158,8 +164,8 @@ public void init(final DaemonContext context) { public void

Re: [PR] make server threads configurable with server.properties file [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on code in PR #9165: URL: https://github.com/apache/cloudstack/pull/9165#discussion_r1636310899 ## client/src/main/java/org/apache/cloudstack/ServerDaemon.java: ## @@ -158,8 +164,8 @@ public void init(final DaemonContext context) { public void

Re: [PR] make server threads configurable with server.properties file [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on code in PR #9165: URL: https://github.com/apache/cloudstack/pull/9165#discussion_r1636310899 ## client/src/main/java/org/apache/cloudstack/ServerDaemon.java: ## @@ -158,8 +164,8 @@ public void init(final DaemonContext context) { public void

Re: [PR] listNetworks optimization [cloudstack]

2024-06-12 Thread via GitHub
abh1sar closed pull request #9096: listNetworks optimization URL: https://github.com/apache/cloudstack/pull/9096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(cloudstack) branch main updated: Add unit tests for null cpu for null parameters for set allocated cpu (#9137)

2024-06-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new c9a95bc22c5 Add unit tests for null cpu for null

Re: [PR] Add unit tests for null cpu for null parameters for set allocated cpu [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud merged PR #9137: URL: https://github.com/apache/cloudstack/pull/9137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add unit tests for null cpu for null parameters for set allocated cpu [cloudstack]

2024-06-12 Thread via GitHub
boring-cyborg[bot] commented on PR #9137: URL: https://github.com/apache/cloudstack/pull/9137#issuecomment-2162781136 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

(cloudstack) branch 4.19 updated: ui; fix admin dashboard vue warnings (#9140)

2024-06-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new 10dc5ad7744 ui; fix admin dashboard vue warnings

Re: [PR] ui: fix admin dashboard vue warnings [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud merged PR #9140: URL: https://github.com/apache/cloudstack/pull/9140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] make server threads configurable with server.properties file [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9165: URL: https://github.com/apache/cloudstack/pull/9165#issuecomment-2162776851 Ideally max thread could be 4 or 8 times the number of CPUs, need to explore how jetty connection pooling works - in which case we may only want to configure the max threads

Re: [PR] fix: domain limits tab ui is now able to present 0 to the user [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9166: URL: https://github.com/apache/cloudstack/pull/9166#issuecomment-2162773747 As it appears a bugfix, can you change base branch to 4.19 @KlausDornsbach ? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] ui: list only accessible networks during import [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9194: URL: https://github.com/apache/cloudstack/pull/9194#issuecomment-2162773000 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9896 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] vxlan: do not create duplicated network for private gateway [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9232: URL: https://github.com/apache/cloudstack/pull/9232#issuecomment-2162750113 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9895 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main] [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9063: URL: https://github.com/apache/cloudstack/pull/9063#issuecomment-2162750112 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9894 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2162747317 > > @vishesh92 have you tested it ? > > I tested with simulator. I was able to reproduce and fix the issue for strict anti affinity. thanks @vishesh92 I will

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-12 Thread via GitHub
harikrishna-patnala commented on code in PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#discussion_r1636277636 ## engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java: ## @@ -2794,6 +2799,16 @@ public void

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162735048 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] assertion improvement on cluster DRS [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on PR #8508: URL: https://github.com/apache/cloudstack/pull/8508#issuecomment-2162732404 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refactor: cloud-sysvmadm script [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9200: URL: https://github.com/apache/cloudstack/pull/9200#issuecomment-2162732252 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9892 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add volume encryption checks during the disk offering change [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9209: URL: https://github.com/apache/cloudstack/pull/9209#issuecomment-2162732256 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9893 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] Allow Domain Admins to deploy VMs in subdomain networks [cloudstack]

2024-06-12 Thread via GitHub
rajujith closed issue #7391: Allow Domain Admins to deploy VMs in subdomain networks URL: https://github.com/apache/cloudstack/issues/7391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Allow Domain Admins to deploy VMs in subdomain networks [cloudstack]

2024-06-12 Thread via GitHub
rajujith commented on issue #7391: URL: https://github.com/apache/cloudstack/issues/7391#issuecomment-2162715531 thanks @harikrishna-patnala we can close this now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] engine/schema: force index in user_vm_view to speed up instance listing [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9198: URL: https://github.com/apache/cloudstack/pull/9198#issuecomment-2162710447 cc @NuxRo - if you have any insights from a production env (user/customer)? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] saml: introduce saml2.check.signature [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #9219: URL: https://github.com/apache/cloudstack/pull/9219#issuecomment-2162709390 @rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service.

Re: [PR] engine/schema: force index in user_vm_view to speed up instance listing [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9198: URL: https://github.com/apache/cloudstack/pull/9198#issuecomment-2162709202 Tested locally on a 4.19/KVM env homelab with 3 hosts and less than 20 user VMs (across accounts & projects), with this changes my own listing of 10 VMs reduces from about 1s

Re: [PR] saml: introduce saml2.check.signature [cloudstack]

2024-06-12 Thread via GitHub
rohityadavcloud commented on PR #9219: URL: https://github.com/apache/cloudstack/pull/9219#issuecomment-2162707290 Tested locally, in default case the checks are totally skipped; more secured env will need testing with and without encrypted assertions - real world users can test those.

Re: [PR] Fix snapshot scheduling with expired jobs [cloudstack]

2024-06-12 Thread via GitHub
borisstoyanov commented on PR #8832: URL: https://github.com/apache/cloudstack/pull/8832#issuecomment-2162696625 @hsato03 could you look into the merge conflicts please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] list VMs by displayname instead of name [cloudstack]

2024-06-12 Thread via GitHub
blueorangutan commented on PR #8503: URL: https://github.com/apache/cloudstack/pull/8503#issuecomment-2162694399 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8503 (QA-JID-372) -- This is an automated message from the Apache Git Service. To respond

(cloudstack) branch main updated (3b8d2202dcd -> faf94387a63)

2024-06-12 Thread bstoyanov
This is an automated email from the ASF dual-hosted git repository. bstoyanov pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3b8d2202dcd fix unwanted kvm root volume migration (#8908) add faf94387a63 Disable logs to stdout and

Re: [PR] Disable logs to stdout and capture remaining stdout logs to a file [cloudstack]

2024-06-12 Thread via GitHub
borisstoyanov merged PR #8880: URL: https://github.com/apache/cloudstack/pull/8880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Ensure affinity groups are honored when VMs are deployed in parallel [cloudstack]

2024-06-12 Thread via GitHub
vishesh92 commented on PR #9201: URL: https://github.com/apache/cloudstack/pull/9201#issuecomment-2162692186 > @vishesh92 have you tested it ? I tested with simulator. I was able to reproduce and fix the issue for strict anti affinity. -- This is an automated message from the

Re: [I] List volume api should have the parameter service offering id [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on issue #8646: URL: https://github.com/apache/cloudstack/issues/8646#issuecomment-2162690090 @kiranchavala Closing this, as the fix PR got merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] List volume api should have the parameter service offering id [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti closed issue #8646: List volume api should have the parameter service offering id URL: https://github.com/apache/cloudstack/issues/8646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

(cloudstack) branch 4.19 updated: List volumes by service offering id (#9211)

2024-06-12 Thread sureshanaparti
This is an automated email from the ASF dual-hosted git repository. sureshanaparti pushed a commit to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.19 by this push: new c756e4370ad List volumes by service

Re: [PR] List volumes by service offering id [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti merged PR #9211: URL: https://github.com/apache/cloudstack/pull/9211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] List volumes by service offering id [cloudstack]

2024-06-12 Thread via GitHub
sureshanaparti commented on PR #9211: URL: https://github.com/apache/cloudstack/pull/9211#issuecomment-2162686937 Merging on the tests and reviews done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

(cloudstack) branch main updated (3fe2b46dd0b -> 3b8d2202dcd)

2024-06-12 Thread bstoyanov
This is an automated email from the ASF dual-hosted git repository. bstoyanov pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 3fe2b46dd0b [UI] Add option to specify account/project while deploying VMs and creating networks (#8919)

<    1   2   3   4   >