[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-24 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r361098706 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-23 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360813276 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360432047 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407183 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360407044 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -66,34

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360404508 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -38,24

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360403041 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401916 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360401970 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360398649 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360396116 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/command/LdapListUsersCmd.java ## @@ -38,24

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360387379 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/api/LdapConstants.java ## @@ -0,0 +1,21 @@ +//

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360386594 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -81,38 +86,126 @@ **/*Spec.groovy

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360384545 ## File path: plugins/user-authenticators/ldap/pom.xml ## @@ -27,6 +27,11 @@ 4.14.0.0-SNAPSHOT ../../pom.xml

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3694: Ldap fixes

2019-12-20 Thread GitBox
DaanHoogland commented on a change in pull request #3694: Ldap fixes URL: https://github.com/apache/cloudstack/pull/3694#discussion_r360311276 ## File path: plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java ## @@ -142,12