[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-18 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r182386542 ## File path: server/src/main/java/com/cloud/projects/ProjectManagerImpl.java ## @@ -479,7 +479,7 @@ public void

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-17 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r182090707 ## File path: server/src/main/java/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java ## @@ -740,14 +740,14 @@

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181792497 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ## @@

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181790224 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10 @@ public

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181789077 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ## @@

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181781752 ## File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java ## @@

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181776550 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10 @@ public

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181775057 ## File path: engine/schema/src/main/java/com/cloud/configuration/dao/ResourceCountDaoImpl.java ## @@ -126,8 +126,10 @@ public

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

2018-04-16 Thread GitBox
lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r181772009 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java ## @@