DaanHoogland merged PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2176259560
Packaging result [SF]: ✔️ el7 ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2176104719
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2176102840
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2167259236
This pull request has merge conflicts. Dear author, please fix the conflicts
and sync your branch with the base branch.
--
This is an automated message from the Apache
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2163215354
> > @vishesh92 @DaanHoogland I agree that if we are to have a configuration
for each table it would be too much. However, the configuration that @vishesh92
proposed to use
vishesh92 commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2160653431
> @vishesh92 @DaanHoogland I agree that if we are to have a configuration
for each table it would be too much. However, the configuration that @vishesh92
proposed to use
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2158815915
@vishesh92 @DaanHoogland I agree that if we are to have a configuration for
each table it would be too much. However, the configuration that @vishesh92
proposed to use
DaanHoogland commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2144761905
@vishesh92 , is this something that would block this PR, or can it be added
as a future improvement. cc @JoaoJandre .
In any case do you agree on a way forward?
--
This is
vishesh92 commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2142880511
> @JoaoJandre It seems Vishesh had some concerns, not sure if they are
addressed
My only concern is increasing number of global settings. I would personally
prefer a generic
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2142709110
> @JoaoJandre It seems Vishesh had some concerns, not sure if they are
addressed
@weizhouapache I've answered @vishesh92's concerns a few months ago, as he
did not respond
JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1622755613
##
engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDao.java:
##
@@ -75,8 +75,9 @@ public interface VmStatsDao extends GenericDao {
/**
* Removes
weizhouapache commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1622701710
##
engine/schema/src/main/java/com/cloud/vm/dao/VmStatsDao.java:
##
@@ -75,8 +75,9 @@ public interface VmStatsDao extends GenericDao {
/**
*
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2142586597
@sureshanaparti I think we are ready to merge this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2139038896
[SF] Trillian test result (tid-10312)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44434 seconds
Marvin logs:
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138139939
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8)
has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To
weizhouapache commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138137511
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2138125745
@sureshanaparti @DaanHoogland could we run the CI here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137587186
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137430831
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2137426806
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2115956772
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
blueorangutan commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2115832776
@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be
bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you
posted as I make progress.
JoaoJandre commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-2115828932
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1514463855
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -1223,6 +1228,11 @@ public int expunge(final SearchCriteria sc) {
vishesh92 commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513378431
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -1208,9 +1208,14 @@ public boolean expunge(final ID id) {
}
}
-//
vishesh92 commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513377957
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -1223,6 +1228,11 @@ public int expunge(final SearchCriteria sc) {
JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1513204284
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -1208,9 +1208,14 @@ public boolean expunge(final ID id) {
}
}
-//
JoaoJandre commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1512752381
##
server/src/main/java/com/cloud/server/StatsCollector.java:
##
@@ -290,6 +287,11 @@ public String toString() {
protected static ConfigKey
vishesh92 commented on code in PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#discussion_r1512245114
##
framework/db/src/main/java/com/cloud/utils/db/GenericDaoBase.java:
##
@@ -1208,9 +1208,14 @@ public boolean expunge(final ID id) {
}
}
-//
codecov[bot] commented on PR #8740:
URL: https://github.com/apache/cloudstack/pull/8740#issuecomment-1976590519
##
[Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8740?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
All
JoaoJandre opened a new pull request, #8740:
URL: https://github.com/apache/cloudstack/pull/8740
### Description
ACS has a job that periodically removes records from the `vm_stats` table
that are older than the retention time (setting `vm.stats.max.retention.time`).
In environments
32 matches
Mail list logo
