Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache merged PR #9212: URL: https://github.com/apache/cloudstack/pull/9212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-12 Thread via GitHub
weizhouapache commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2163089437 > LGTM based on manual testing. I cannot reproduce the problem after this patch. thanks @vladimirpetrov ! merging -- This is an automated message from the Apache

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
blueorangutan commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2162063718 [SF] Trillian test result (tid-10414) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47174 seconds Marvin logs:

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
blueorangutan commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160906191 @weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160904518 @blueorangutan test rocky8 kvm-rocky8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
blueorangutan commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160805273 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9869 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
blueorangutan commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160620543 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160616242 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634741701 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -175,6 +178,12 @@ Use

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
shwstppr commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634657512 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -175,6 +178,12 @@ Use

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634505797 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -175,6 +178,12 @@ Use

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634499005 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -702,6 +711,81 @@ private String

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
shwstppr commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634451600 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -175,6 +178,12 @@ Use

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
DaanHoogland commented on code in PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#discussion_r1634429792 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java: ## @@ -702,6 +711,81 @@ private String

Re: [PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
codecov[bot] commented on PR #9212: URL: https://github.com/apache/cloudstack/pull/9212#issuecomment-2160092629 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9212?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

[PR] kvm: replace ISO path in vm XML configuration during vm migration [cloudstack]

2024-06-11 Thread via GitHub
weizhouapache opened a new pull request, #9212: URL: https://github.com/apache/cloudstack/pull/9212 ### Description This PR fixes #8901 steps to reproduce the issue - create env with 2 image store - create a vm - register an ISO - attach the ISO to the vm -