[GitHub] marcaurele opened a new pull request #2578: api: add command to list management servers

marcaurele opened a new pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578 ## Description New API command to list the management servers, following the discussion on the mailing list. It adds back (I think it was removed a

[GitHub] blueorangutan commented on issue #2578: api: add command to list management servers

blueorangutan commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-382304582 @marcaurele a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on a change in pull request #2578: api: add command to list management servers

DaanHoogland commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182347596 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19 +14,2

[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356

DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382310815 @brettKK this can not be merged, I think you based on master and then pointed the pull request at 4.11. I think you need to rebase your changes on the branch y

[GitHub] blueorangutan commented on issue #2578: api: add command to list management servers

blueorangutan commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-382312660 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-1940 This is an a

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182353080 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19 +14,23

[GitHub] marcaurele commented on issue #2578: api: add command to list management servers

marcaurele commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-382314118 @DaanHoogland what kind of tests do you expect on a pure list operation ? I thought it's pretty straight forward and would not need any

[GitHub] brettKK commented on issue #2573: Cloudstack 10356

brettKK commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382322131 @DaanHoogland, yes , you are right. I need to merge 4.11 with my branch if I want to diff with it. ---

[GitHub] brettKK commented on issue #2573: Cloudstack 10356

brettKK commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382322131 @DaanHoogland, yes , you are right. I need to merge 4.11 with my branch if I want to diff with it. By the way, I wonder thay why the others diff their branch wi

[GitHub] blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update

blueorangutan commented on issue #2574: [CLOUDSTACK-5235] ask users old password when they are executing a password update URL: https://github.com/apache/cloudstack/pull/2574#issuecomment-382333691 Trillian test result (tid-2516) Environment: kvm-centos7 (x2), Advanced Networking with Mg

[GitHub] rafaelweingartner commented on issue #2573: Cloudstack 10356

rafaelweingartner commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382335214 @brettKK you can point it directly to master if you want. Then, you do not need any re-work. If you want to target 4.11 instead of master, you indeed ne

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182377121 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182377300 ## File path: api/src/main/java/com/cloud/management/ManagementServerHostPeer.java ## @@ -0,

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182380752 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -3760,6 +

[GitHub] DaanHoogland commented on issue #2578: api: add command to list management servers

DaanHoogland commented on issue #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#issuecomment-382342273 @marcaurele I don't expect test on the list operation. it is to trivial. I am thinking about the underlying constructs, the change i

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382345465 @blueorangutan test

[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356

DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345484 @brettKK what @rafaelweingartner is refering to is the following procedure: $ git checkout -b 4.11 origin/4.11 $ git pull # may not be needed anymore ;)

[GitHub] blueorangutan commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

blueorangutan commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382345602 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kick

[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356

DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345761 i reset the base to master in case someone accidentally would merge This is an automated messag

[GitHub] DaanHoogland commented on issue #2573: Cloudstack 10356

DaanHoogland commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382345484 @brettKK what @rafaelweingartner is refering to is the following procedure: $ git checkout -b 4.11 origin/4.11 $ git pull # may not be needed anymore ;)

[GitHub] lujiefsi commented on a change in pull request #2573: Cloudstack 10356

lujiefsi commented on a change in pull request #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#discussion_r182386542 ## File path: server/src/main/java/com/cloud/projects/ProjectManagerImpl.java ## @@ -479,7 +479,7 @@ public void doInTransactionW

[GitHub] lujiefsi commented on issue #2573: Cloudstack 10356

lujiefsi commented on issue #2573: Cloudstack 10356 URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382348646 Seem that this pull request does not associate with JIRA [CLOUDSTACK-10356](https://issues.apache.org/jira/browse/CLOUDSTACK-10356) -

[GitHub] DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289

DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382352827 @blueorangutan package This is an automated message from

[GitHub] blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289

blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382353035 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382353181 @lujiefsi what do you mean by, "does not associate"? --

[GitHub] DaanHoogland closed pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

DaanHoogland closed pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

DaanHoogland commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382353436 trying to get a new ci run This is an automate

[GitHub] brettKK opened a new pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

brettKK opened a new pull request #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573 @lujiefsi found a potential NPE in Cloudstack --- We have developed a static analysis tool NPEDetector to find some potential

[GitHub] lujiefsi commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

lujiefsi commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382356636 We should also need to delete the method updateDomainCount in ResourceCountDao, which is also @Deprecated

[GitHub] lujiefsi commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector

lujiefsi commented on issue #2573: [CLOUDSTACK-10356] Fix NPE in Cloudstack found with NPEDetector URL: https://github.com/apache/cloudstack/pull/2573#issuecomment-382356636 After checking the output of jenkins, the error is we only delete updateDomainCount in ResourceCountDaoImpl . We

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182396207 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -3760,6 +3767,22

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182396540 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19 +14,23

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182396611 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -3760,6 +

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182396653 ## File path: api/src/main/java/com/cloud/management/ManagementServerHostPeer.java ## @@ -0,0 +1,30

[GitHub] blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289

blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382358880 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1941 Th

[GitHub] rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers

rafaelweingartner commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182397190 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19

[GitHub] marcaurele commented on a change in pull request #2578: api: add command to list management servers

marcaurele commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182402821 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19 +14,23

[GitHub] DaanHoogland commented on a change in pull request #2578: api: add command to list management servers

DaanHoogland commented on a change in pull request #2578: api: add command to list management servers URL: https://github.com/apache/cloudstack/pull/2578#discussion_r182406831 ## File path: api/src/main/java/com/cloud/management/ManagementServerHost.java ## @@ -14,19 +14,2

[GitHub] DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289

DaanHoogland commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382368598 @blueorangutan test This is an automated message from the

[GitHub] blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289

blueorangutan commented on issue #2566: ConfigDrive fixes: CLOUDSTACK-10288, CLOUDSTACK-10289 URL: https://github.com/apache/cloudstack/pull/2566#issuecomment-382368864 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-382381952 Trillian test result (tid-2511) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 101659 seconds Mar

[cloudstack-www] branch master updated (7c9640b -> c78e824)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 7c9640b 4.9.3.1 release add cc698c4 Add Apache event banner. new c78e824 Merge pull request #44

[cloudstack-www] 01/01: Merge pull request #44 from rafaelweingartner/apacheBanner

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit c78e824a7dd57b7363c17f50319b0817e0d56f16 Merge: 7c9640b cc698c4 Author: Rafael Weingärtner AuthorDate: Wed Apr 1

[cloudstack-www] 01/02: updated PR44 to include compiled content

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 06846268dbf9820237ee47c458b2e75fe489d784 Author: Rafael Weingärtner AuthorDate: Wed Apr 18 15:53:07 2018 +0200

[cloudstack-www] 02/02: Merge branch 'master' into asf-site

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 94807d62ae2641cee9c9f84ecfb7fdbc82a63904 Merge: 4daa65b 0684626 Author: Rafael Weingärtner AuthorDate: Wed Apr

[cloudstack-www] branch asf-site updated (4daa65b -> 94807d6)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 4daa65b Merge branch 'master' into asf-site add cc698c4 Add Apache event banner. add c78e824 M

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382410765 @rafaelweingartner I've reproduce the issue, will send a fix in separate PR. @ustcwei

[GitHub] blueorangutan commented on issue #2505: WIP CLOUDSTACK-10333: Secure Live VM Migration for KVM

blueorangutan commented on issue #2505: WIP CLOUDSTACK-10333: Secure Live VM Migration for KVM URL: https://github.com/apache/cloudstack/pull/2505#issuecomment-382412378 Trillian test result (tid-2514) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time ta

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382413535 @rhtyd sure. No problem. I still do not understand how to do it via routin

[GitHub] blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576#issuecomment-382415770 Trillian test result (tid-2515) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 To

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382410765 @rafaelweingartner I've reproduce the issue, will send a fix in separate PR. @ustcwei

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382440734 @rhtyd the first time I looked at that code I asked myself the same thing.

[GitHub] rafaelweingartner closed pull request #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

rafaelweingartner closed pull request #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake o

[cloudstack] branch 4.11 updated: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" (#2576)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new bfe4cb0 Fix Python code checkstyle execute by

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382440734 @rhtyd the first time I looked at that code I asked myself the same thing.

[GitHub] blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576#issuecomment-382441274 @rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack] 01/01: Forward merge branch '4.11' (PR: #2576) to master

This is an automated email from the ASF dual-hosted git repository. rafael pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 15afc35ff978bcedb05d0a0673f8bac9ac49743a Merge: b940a89 bfe4cb0 Author: Rafael Weingärtner AuthorDate: Wed Apr 18 13

[cloudstack] branch master updated (b940a89 -> 15afc35)

This is an automated email from the ASF dual-hosted git repository. rafael pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from b940a89 Merge branch '4.11' add bfe4cb0 Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382445669 @rafaelweingartner I found some issues with mangle table, can you attempt this workar

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382445669 @rafaelweingartner I found some issues with mangle table, can you attempt this workar

[GitHub] blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576#issuecomment-382450210 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1942 ---

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382459118 What do you mean by "SNAT"? Are you referring to "enable static NAT" featu

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382459118 What do you mean by "SNAT"? Are you referring to "enable static NAT" featu

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382459118 What do you mean by "SNAT"? Are you referring to "enable static NAT" featu

[GitHub] rhtyd opened a new pull request #2579: router: don't mark packets permanently on SNAT

rhtyd opened a new pull request #2579: router: don't mark packets permanently on SNAT URL: https://github.com/apache/cloudstack/pull/2579 This will remove MARK-ing of packets via the mangle table. This also fixes an unexplained issue of failure of access via public SNAT ips across VMS

[GitHub] blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT

blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382463659 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382463735 @rafaelweingartner I'm not sure why it failed for you, can you share your env details

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382464622 Nothing fancy here. The difference is that I am using XenServer, but that

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382466586 @rafaelweingartner thanks. Yes, you are right I tested/fix it against only the SNAT f

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382468606 @rafaelweingartner okay I did a quick test. I allocated a public IP to my VPC, but di

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382468755 @rafaelweingartner what is the ACLs for the VPC? I used an allow all policy (i.e. bot

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382470270 I just tested in your system, and it is indeed working. I applied your ch

[GitHub] blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT

blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382472101 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1943 This is a

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382473012 No success :( Here goes my iptables (with PR2579): ``` # Generat

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382474173 I forgot to mention. In this test environment I am using ACS 4.9. You s

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-382475771 Trillian test result (tid-2512) Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7 Total time taken: 119012 seconds Marvi

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382478623 @rafaelweingartner can you test against 4.11? I tested it against 4.11 ( you can veri

[GitHub] rhtyd commented on issue #2579: router: don't mark packets permanently on SNAT

rhtyd commented on issue #2579: router: don't mark packets permanently on SNAT URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382478850 @blueorangutan test matrix This is an automated message from the Apache

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382478943 That is what I am doing now. I am building 4.11 with your PR to test.

[GitHub] blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT

blueorangutan commented on issue #2579: router: don't mark packets permanently on SNAT URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382479326 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked t

[GitHub] blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh"

blueorangutan commented on issue #2576: Fix Python code checkstyle execute by "systemvm\test\runtests.sh" URL: https://github.com/apache/cloudstack/pull/2576#issuecomment-382496608 Trillian test result (tid-2517) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 To

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382496686 @rafaelweingartner On further investigation and hints from Jayapal's reply on dev@ I

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382497739 That is what you do in #2579, right? What does `ip route add throw`

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382498868 The first time when I saw this `throw` clause in the @ustcweizhou comments

[GitHub] rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rafaelweingartner commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382498868 The first time when I saw this `throw` clause in the @ustcweizhou comments

[GitHub] blueorangutan commented on issue #2376: [4.11] Smoketest Health Check

blueorangutan commented on issue #2376: [4.11] Smoketest Health Check URL: https://github.com/apache/cloudstack/pull/2376#issuecomment-382499980 Trillian test result (tid-2510) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 6 Total time taken: 123842 seconds Ma

[GitHub] lzh3636 opened a new pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

lzh3636 opened a new pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580 ## Description There are some possible copy and paste errors in the log messages (The logging statement was

[GitHub] blueorangutan commented on issue #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

blueorangutan commented on issue #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#issuecomment-382503229 @lzh3636 a Jenkins job has been kicked to build packages. I'll keep you posted as I make pro

[GitHub] rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#discussion_r182544640 ## File path: plugins/dedicated-resources/src/main/java/org/ap

[GitHub] rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

rafaelweingartner commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#discussion_r182544717 ## File path: plugins/hypervisors/baremetal/src/main/java/org/

[GitHub] lzh3636 commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

lzh3636 commented on a change in pull request #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#discussion_r182547786 ## File path: plugins/hypervisors/baremetal/src/main/java/org/apache/clo

[GitHub] rhtyd commented on issue #2579: router: fix routing table for marked packets

rhtyd commented on issue #2579: router: fix routing table for marked packets URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382509372 @rafaelweingartner based on @ustcweizhou 's comment, I've updated and tested the code to add routing rules for fwmarked (MARK-ed) packets.

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-38251 @rafaelweingartner yes I've updated https://github.com/apache/cloudstack/pull/2579, d

[GitHub] blueorangutan commented on issue #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function

blueorangutan commented on issue #2580: CLOUDSTACK-10357 Improve log messages that do not match with their method function URL: https://github.com/apache/cloudstack/pull/2580#issuecomment-382510349 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1944 --

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382510915 @rafaelweingartner okay let me try to explain what I understand (and btw this is wrt

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382510915 @rafaelweingartner okay let me try to explain what I understand (and btw this is wrt

[GitHub] rhtyd commented on issue #2579: router: fix routing table for marked packets

rhtyd commented on issue #2579: router: fix routing table for marked packets URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382509372 @rafaelweingartner based on @ustcweizhou 's comment, I've updated and tested the code to add routing rules for fwmarked (MARK-ed) packets.

[GitHub] blueorangutan commented on issue #2579: router: fix routing table for marked packets

blueorangutan commented on issue #2579: router: fix routing table for marked packets URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382479326 @rhtyd a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to

[GitHub] blueorangutan commented on issue #2579: router: fix routing table for marked packets

blueorangutan commented on issue #2579: router: fix routing table for marked packets URL: https://github.com/apache/cloudstack/pull/2579#issuecomment-382472101 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1943 This is an

[GitHub] rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs

rhtyd commented on issue #2514: [CLOUDSTACK-10346] Problem with NAT configuration and VMs not accessing each other via public IPs URL: https://github.com/apache/cloudstack/pull/2514#issuecomment-382510915 @rafaelweingartner okay let me try to explain what I understand (and btw this is wrt

  1   2   >