[GitHub] brodybits opened a new pull request #834: CB-14152 add cordova-js@4.2.4 blog post

brodybits opened a new pull request #834: CB-14152 add cordova-js@4.2.4 blog post URL: https://github.com/apache/cordova-docs/pull/834 ### Platforms affected All ### What does this PR do? - cordova-js@4.2.4 blog post ### What testing has been done on

svn commit: r27640 - in /dev/cordova/CB-14152: ./ cordova-js-4.2.4.tgz cordova-js-4.2.4.tgz.asc cordova-js-4.2.4.tgz.md5 cordova-js-4.2.4.tgz.sha512

Author: brodybits Date: Fri Jun 22 04:16:31 2018 New Revision: 27640 Log: CB-14152 upload release candidate for cordova-js 4.2.4 tools release Added: dev/cordova/CB-14152/ dev/cordova/CB-14152/cordova-js-4.2.4.tgz (with props) dev/cordova/CB-14152/cordova-js-4.2.4.tgz.asc

[GitHub] knight9999 commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing

knight commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing URL: https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399312189 Ok, I have rebased master.

[GitHub] shazron commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing

shazron commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing URL: https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399309428 Looks like commit from master has passed, so feel free to rebase/merge this

[GitHub] shazron commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing

shazron commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing URL: https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399308180 I've pulled in #166. Once https://travis-ci.org/apache/cordova-plugin-media

[cordova-plugin-media] branch master updated: CB-14091: fix tests code for stream url and remove browser (#166)

This is an automated email from the ASF dual-hosted git repository. shazron pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-media.git The following commit(s) were added to refs/heads/master by this push: new 524c337 CB-14091: fix tests

[GitHub] shazron closed pull request #166: CB-14091: fix tests code for stream url and remove browser

shazron closed pull request #166: CB-14091: fix tests code for stream url and remove browser URL: https://github.com/apache/cordova-plugin-media/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] knight9999 commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing

knight commented on issue #168: CB-12849: checking mediaState in destroy method, and moving file by stream when renameTo failing URL: https://github.com/apache/cordova-plugin-media/pull/168#issuecomment-399305568 The travis CI errors are resolved by other PR

[GitHub] brodybits opened a new pull request #174: WORKAROUND SOLUTION for local grunt issue in cordova-js

brodybits opened a new pull request #174: WORKAROUND SOLUTION for local grunt issue in cordova-js URL: https://github.com/apache/cordova-coho/pull/174 ### Platforms affected All ### What does this PR do? **Resolves the following issue:** If I would

[cordova-android] branch master updated (559b083 -> e9750b5)

This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 559b083 Add unit tests for run and retryPromise add f90f004 Add unit tests for Adb.js add

[GitHub] raphinesse closed pull request #456: More android tests

raphinesse closed pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[cordova-android] 01/01: Merge pull request #456 from Menardi/more_android_tests

This is an automated email from the ASF dual-hosted git repository. raphinesse pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit e9750b5cabe70b1fc9abfad28fd1239d9b9415c2 Merge: 559b083 0bf0e48 Author: Raphael von der Grün AuthorDate:

[GitHub] raphinesse commented on issue #456: More android tests

raphinesse commented on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399290852 Thanks again for these wonderful tests. :1st_place_medal: Thanks to you we have now over 50% coverage! Time to get us some badges :grin:

[GitHub] codecov-io edited a comment on issue #456: More android tests

codecov-io edited a comment on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399022994 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/456?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #456: More android tests

codecov-io edited a comment on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399022994 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/456?src=pr=h1) Report > Merging

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197316519 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197316373 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] codecov-io edited a comment on issue #456: More android tests

codecov-io edited a comment on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399022994 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/456?src=pr=h1) Report > Merging

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197310789 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197306635 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197307268 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197309116 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197310236 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197305634 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] Menardi commented on a change in pull request #456: More android tests

Menardi commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197310101 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] jazbek opened a new issue #833: Missing documentation for OSX icons

jazbek opened a new issue #833: Missing documentation for OSX icons URL: https://github.com/apache/cordova-docs/issues/833 **Issue Type** [ x] Bug [ ] Feature Request **Priority** [ x ] Minor [ ] Major [ ] Critical [ ] Blocker **Environment** * OS: OS

[GitHub] brodybits commented on issue #162: [CB-14156 WIP] Remove browserify - WIP NOT TESTED

brodybits commented on issue #162: [CB-14156 WIP] Remove browserify - WIP NOT TESTED URL: https://github.com/apache/cordova-js/pull/162#issuecomment-399216641 I just raised [CB-14156](https://issues.apache.org/jira/browse/CB-14156) to report the problems with `browserify` in general,

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197131057 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197131057 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[cordova-js] branch master updated: CB-14155 fix btest part 2: export npm script

This is an automated email from the ASF dual-hosted git repository. brodybits pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-js.git The following commit(s) were added to refs/heads/master by this push: new cc069cc CB-14155 fix btest part 2:

[GitHub] brodybits closed pull request #164: CB-14155 fix btest part 2: export npm script

brodybits closed pull request #164: CB-14155 fix btest part 2: export npm script URL: https://github.com/apache/cordova-js/pull/164 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] brodybits opened a new pull request #164: CB-14155 fix btest part 2: export npm script

brodybits opened a new pull request #164: CB-14155 fix btest part 2: export npm script URL: https://github.com/apache/cordova-js/pull/164 ### Platforms affected All ### What does this PR do? Followup to btest fix in PR #160: export npm script in package.json

[GitHub] brodybits commented on issue #160: CB-14155: Fix btest by using express (instead of connect, etc.)

brodybits commented on issue #160: CB-14155: Fix btest by using express (instead of connect, etc.) URL: https://github.com/apache/cordova-js/pull/160#issuecomment-399135610 Just raised Apache CB-14155 () to track these changes.

[GitHub] raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type

raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399133263 Thanks for your answer. This is an automated

[GitHub] brodybits commented on issue #160: Fix btest by using express (instead of connect, etc.)

brodybits commented on issue #160: Fix btest by using express (instead of connect, etc.) URL: https://github.com/apache/cordova-js/pull/160#issuecomment-399117573 Looks to me like "btest" means "run tests in the browser" ref:

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197121985 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197126426 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197133206 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197128582 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197131057 ## File path: spec/unit/AndroidManifest.spec.js ## @@ -0,0 +1,311 @@ +/** +Licensed to the Apache Software Foundation

[GitHub] janpio edited a comment on issue #160: Fix btest by using express (instead of connect, etc.)

janpio edited a comment on issue #160: Fix btest by using express (instead of connect, etc.) URL: https://github.com/apache/cordova-js/pull/160#issuecomment-399061047 What is the motivation behind this? What is "btest"? Why no issue?

[GitHub] janpio commented on issue #160: Fix btest by using express (instead of connect, etc.)

janpio commented on issue #160: Fix btest by using express (instead of connect, etc.) URL: https://github.com/apache/cordova-js/pull/160#issuecomment-399061047 What is the motivation behind this? What is "btest"? This is an

[GitHub] jcesarmobile commented on issue #437: CB-14038 (android): fix false positive detecting project type

jcesarmobile commented on issue #437: CB-14038 (android): fix false positive detecting project type URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399060126 No, there is no work about it because the idea was to do a patch or minor release with this changes to unblock

[GitHub] janpio commented on issue #162: [WIP] Remove browserify - WIP NOT TESTED

janpio commented on issue #162: [WIP] Remove browserify - WIP NOT TESTED URL: https://github.com/apache/cordova-js/pull/162#issuecomment-399059926 Why? Do you know the reason why this was there and what it was used for in the first place?

[GitHub] janpio commented on issue #163: [WIP] package.json update eslint & other devDependencies

janpio commented on issue #163: [WIP] package.json update eslint & other devDependencies URL: https://github.com/apache/cordova-js/pull/163#issuecomment-399059723 (Placed the [WIP] in front of the title to make it more obvious and visible)

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197064564 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] janpio closed pull request #455: Start 8.0.0-dev in master - WIP

janpio closed pull request #455: Start 8.0.0-dev in master - WIP URL: https://github.com/apache/cordova-android/pull/455 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] janpio commented on issue #455: Start 8.0.0-dev in master - WIP

janpio commented on issue #455: Start 8.0.0-dev in master - WIP URL: https://github.com/apache/cordova-android/pull/455#issuecomment-399058927 (Forgot actually closing? Did it for you @brodybits) This is an automated message

[GitHub] janpio commented on issue #456: More android tests

janpio commented on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399058579 Wheee, additional tests are always nice. Great work @Menardi ! This is an automated message

[GitHub] raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type

raphinesse commented on issue #437: CB-14038 (android): fix false positive detecting project type URL: https://github.com/apache/cordova-android/pull/437#issuecomment-399058403 @jcesarmobile Is there any WIP for the aforementioned refactor? Losing some dead weight would definitely be

[GitHub] janpio commented on issue #277: VS Professional 2017 v15.7: MSBuild v4.0 is not supported, aborting.

janpio commented on issue #277: VS Professional 2017 v15.7: MSBuild v4.0 is not supported, aborting. URL: https://github.com/apache/cordova-windows/issues/277#issuecomment-399056266 cordova-windows 5.x had problems with VS2017 in general, that's probably why that is not working.

[GitHub] raphinesse commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release

raphinesse commented on issue #451: CB-14145: update to cordova-common@2.2.4 to resolve npm audit & other issues in patch release URL: https://github.com/apache/cordova-android/pull/451#issuecomment-399056204 I'd be happy to see these fixes in the upcoming release. I don't see why these

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197070463 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197064564 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197078202 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197074184 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197075573 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197067599 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] raphinesse commented on a change in pull request #456: More android tests

raphinesse commented on a change in pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#discussion_r197072184 ## File path: spec/unit/Adb.spec.js ## @@ -0,0 +1,222 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] liuxh0 opened a new issue #277: VS Professional 2017 v15.7: MSBuild v4.0 is not supported, aborting.

liuxh0 opened a new issue #277: VS Professional 2017 v15.7: MSBuild v4.0 is not supported, aborting. URL: https://github.com/apache/cordova-windows/issues/277 Hello everyone, Installed cordova-windows@5.x + VS 2017 v15.5: MSBuild v4.0 is not supported, aborting. Updated to

[GitHub] codecov-io commented on issue #456: More android tests

codecov-io commented on issue #456: More android tests URL: https://github.com/apache/cordova-android/pull/456#issuecomment-399022994 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/456?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support

codecov-io edited a comment on issue #448: CB-13685 android: Adaptive Icon Support URL: https://github.com/apache/cordova-android/pull/448#issuecomment-397924030 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/448?src=pr=h1) Report > Merging

[GitHub] Menardi opened a new pull request #456: More android tests

Menardi opened a new pull request #456: More android tests URL: https://github.com/apache/cordova-android/pull/456 ### Platforms affected Android ### What does this PR do? Adds more unit tests for Android. Since my last PR adding tests went well, I decided to add