aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406496259
@Menardi i think you're right. I've pushed a change with constant and some
readme updates. Please check out.
Menardi commented on issue #98: Add `getStatusBarHeight` method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406464984
@aszmyd Looking at the Android code, the statusbar height is always `24dp`
(see
janpio edited a comment on issue #67: CB-12024: Browser platform support
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-406247727
Thanks.
I installed the plugin from your PR branch and adapted the default project:
janpio commented on issue #67: CB-12024: Browser platform support
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-406247727
Thanks.
I installed the plugin, adapted the default project:
janpio commented on issue #468: Update CordovaResourceApi.java
URL: https://github.com/apache/cordova-android/pull/468#issuecomment-406245109
Hey @bikcrum, thanks for this PR.
What is the motivation for and use of this change?
Is there a JIRA issue that belongs to this code
janpio commented on issue #849: Document how to install branch of Github repo /
PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849#issuecomment-406237253
Ugh, ok.
I think we're better of making it explicit in the Cordova docs then - as it
is a pretty
raphinesse commented on issue #849: Document how to install branch of Github
repo / PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849#issuecomment-406236081
The docs you linked to refer to it as `#` since you can specify
a tag or a commit hash too.
janpio commented on issue #849: Document how to install branch of Github repo /
PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849#issuecomment-406234470
Surprisingly https://docs.npmjs.com/cli/install doesn't mention "branch" at
all.
But I think
raphinesse commented on issue #849: Document how to install branch of Github
repo / PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849#issuecomment-406232992
It should work exactly like for any npm package AFAICT. So if we add
something, we might be able to
janpio commented on issue #849: Document how to install branch of Github repo /
PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849#issuecomment-406232511
Using a `#` to separate the branch name from the repo URL worked:
```
cordova plugin add
janpio opened a new issue #849: Document how to install branch of Github repo /
PR as platform/plugin
URL: https://github.com/apache/cordova-docs/issues/849
I couldn't find any documentation on how to install a branch of a Github
Repo (e.g. a PR to one of the Cordova plugins). This should
raphinesse commented on a change in pull request #848: Remove deprecated
platforms from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203676749
##
File path: www/static/plugins/supportedplatforms.jsx
##
@@ -1,83 +1,32 @@
-var Preact =
erisu commented on a change in pull request #848: Remove deprecated platforms
from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203666592
##
File path: www/static/plugins/supportedplatforms.jsx
##
@@ -1,83 +1,32 @@
-var Preact =
erisu commented on a change in pull request #848: Remove deprecated platforms
from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203666592
##
File path: www/static/plugins/supportedplatforms.jsx
##
@@ -1,83 +1,32 @@
-var Preact =
codecov-io commented on issue #468: Update CordovaResourceApi.java
URL: https://github.com/apache/cordova-android/pull/468#issuecomment-406211779
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/468?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #468: Update CordovaResourceApi.java
URL: https://github.com/apache/cordova-android/pull/468#issuecomment-406211779
#
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/468?src=pr=h1)
Report
> Merging
aszmyd commented on issue #98: Add `getStatusBarHeight` method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#issuecomment-406208406
I've pushed changes that fixes split mode issue - If we detect that we're in
split mode at the bottom, we simply return height
bikcrum opened a new pull request #468: Update CordovaResourceApi.java
URL: https://github.com/apache/cordova-android/pull/468
Add FileUtils class to support URI to getting real file path for different
APIs.
### Platforms affected
### What does this PR do?
aszmyd commented on a change in pull request #98: Add `getStatusBarHeight`
method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#discussion_r203640805
##
File path: src/android/StatusBar.java
##
@@ -273,4 +285,13 @@ private void
janpio commented on a change in pull request #848: Remove deprecated platforms
from plugin page
URL: https://github.com/apache/cordova-docs/pull/848#discussion_r203630772
##
File path: www/static/plugins/supportedplatforms.jsx
##
@@ -1,83 +1,32 @@
-var Preact =
Menardi commented on a change in pull request #98: Add `getStatusBarHeight`
method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#discussion_r203617460
##
File path: www/statusbar.js
##
@@ -93,6 +93,13 @@ var StatusBar = {
show: function
Menardi commented on a change in pull request #98: Add `getStatusBarHeight`
method for Android
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/98#discussion_r203621392
##
File path: src/android/StatusBar.java
##
@@ -273,4 +285,13 @@ private void
wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to
allow custom schemes
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406176669
Thanks for testing. Apparently I didn't test it enough, sorry. Still, for me
it works on iOS, except
dudeofawesome commented on issue #67: CB-12024: Browser platform support
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-406173094
@janpio Rebased!
To try it out, I'd pretty much just set up a regular demo project for the
statusbar plugin, but add the
dudeofawesome commented on a change in pull request #67: CB-12024: Browser
platform support
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r203616362
##
File path: README.md
##
@@ -30,7 +30,7 @@ description: Control the device status bar.
dudeofawesome commented on a change in pull request #67: CB-12024: Browser
platform support
URL:
https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r203615276
##
File path: README.md
##
@@ -30,7 +30,7 @@ description: Control the device status bar.
26 matches
Mail list logo
