[cordova-android] branch master updated (576ad18 -> cf5915a)

This is an automated email from the ASF dual-hosted git repository. dpogue pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from 576ad18 Merge pull request #542 from brodybits/gh-540-hotfix add a4caa87 add missing cast for cdvMinS

[cordova-android] 01/01: Merge pull request #551 from DavidWiesner/cast-min-sdk-version

This is an automated email from the ASF dual-hosted git repository. dpogue pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git commit cf5915ad017c2b15579d5ae893858d41a2b31538 Merge: 576ad18 a4caa87 Author: Darryl Pogue AuthorDate: Tue Nov 13 23:

[GitHub] dpogue closed pull request #551: (android) add missing cast for cdvMinSdkVersion

dpogue closed pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] DavidWiesner commented on issue #489: Incorrect default min SDK version ternary in build.gradle

DavidWiesner commented on issue #489: Incorrect default min SDK version ternary in build.gradle URL: https://github.com/apache/cordova-android/issues/489#issuecomment-438556580 @dpogue I did not understand the motivation for not including this in the bugfix branch it is [documentented](

[GitHub] DavidWiesner opened a new pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory

DavidWiesner opened a new pull request #553: #552: (android) check for build-extras.gradle in the app-parent directory URL: https://github.com/apache/cordova-android/pull/553 ### Platforms affected - android ### What does this PR do? - solves issue #552. Therefor include the bu

[GitHub] DavidWiesner opened a new issue #552: Cordova CLI project ignores build-extras after toolchain upgrade

DavidWiesner opened a new issue #552: Cordova CLI project ignores build-extras after toolchain upgrade URL: https://github.com/apache/cordova-android/issues/552 This is an automated message from the Apache Git Service. To re

[GitHub] codecov-io edited a comment on issue #551: (android) add missing cast for cdvMinSdkVersion

codecov-io edited a comment on issue #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#issuecomment-438547086 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/551?src=pr&el=h1) Report > Merging [#551](https://cod

[GitHub] codecov-io commented on issue #551: (android) add missing cast for cdvMinSdkVersion

codecov-io commented on issue #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551#issuecomment-438547086 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/551?src=pr&el=h1) Report > Merging [#551](https://codecov.io

[GitHub] DavidWiesner opened a new pull request #551: (android) add missing cast for cdvMinSdkVersion

DavidWiesner opened a new pull request #551: (android) add missing cast for cdvMinSdkVersion URL: https://github.com/apache/cordova-android/pull/551 ### Platforms affected - android ### What does this PR do? - re-add the cast for cdvMinSdkVersion this was in already inc

[GitHub] shineabel commented on issue #64: Network.type is throwing as none after 24 hours of idle

shineabel commented on issue #64: Network.type is throwing as none after 24 hours of idle URL: https://github.com/apache/cordova-plugin-network-information/issues/64#issuecomment-438521527 Is there any solution? This is an a

[GitHub] ceeespinosa19 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

ceeespinosa19 commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-438520617 @theMartux Hi! to upload your app, did you use this command? ionic cordova run ios --l -- --buildFlag="-UseModernBuildSystem=0" or ca

[GitHub] ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices

ffMathy commented on issue #100: CB-13683: (android) cordova-plugin-media-capture rotates pictures with some devices URL: https://github.com/apache/cordova-plugin-media-capture/pull/100#issuecomment-438506676 @janpio sorry for bothering you again, but is there anything we can do to involv

[GitHub] dpogue commented on issue #489: Incorrect default min SDK version ternary in build.gradle

dpogue commented on issue #489: Incorrect default min SDK version ternary in build.gradle URL: https://github.com/apache/cordova-android/issues/489#issuecomment-438490667 This was not cherry-picked to the bugfix branch for 7.1.x, it will be included in the next major version.

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438482470 I don’t know any plugin with such files (other than the one you linked and it’s fixed already), so unit tests should be en

[GitHub] brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438480204 > `app/src/main` is used multiple times, might be worth to put it in a variable I can do this, would favor doing the s

[GitHub] codecov-io commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

codecov-io commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438479228 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/550?src=pr&el=h1) Report > Merging [#550](https://codecov

[GitHub] codecov-io edited a comment on issue #550: Fix for old plugins with non-Java sources (GH-547)

codecov-io edited a comment on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438479228 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/550?src=pr&el=h1) Report > Merging [#550](https://

[GitHub] jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547)

jcesarmobile commented on issue #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438479177 Looking at the plugin you linked in the comment, it also has .h and .c files that are treated as .java files. They were

[GitHub] brodybits commented on a change in pull request #550: Fix for old plugins with non-Java sources (GH-547)

brodybits commented on a change in pull request #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#discussion_r233263028 ## File path: bin/templates/cordova/lib/pluginHandlers.js ## @@ -293,20 +293,28 @@ functio

[GitHub] jcesarmobile commented on a change in pull request #550: Fix for old plugins with non-Java sources (GH-547)

jcesarmobile commented on a change in pull request #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550#discussion_r233261415 ## File path: bin/templates/cordova/lib/pluginHandlers.js ## @@ -293,20 +293,28 @@ func

[GitHub] brodybits edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2

brodybits edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-438369590 Issues with `cordova-plugin-deezer` and should now be solv

[GitHub] jcesarmobile closed pull request #549: Cherry picks

jcesarmobile closed pull request #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] jcesarmobile commented on a change in pull request #549: Cherry picks

jcesarmobile commented on a change in pull request #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549#discussion_r233254818 ## File path: bin/templates/cordova/lib/pluginHandlers.js ## @@ -44,11 +37,8 @@ var handlers = { } },

[GitHub] brodybits opened a new pull request #550: Fix for old plugins with non-Java sources (GH-547)

brodybits opened a new pull request #550: Fix for old plugins with non-Java sources (GH-547) URL: https://github.com/apache/cordova-android/pull/550 ## Proposed changes - Unit tests to cover GH-547 for AIDL, AAR, JAR, and `.so` file with old target-dir scheme (cordova-android pre-7.

[GitHub] brodybits commented on issue #549: Cherry picks

brodybits commented on issue #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549#issuecomment-438464905 Thanks @jcesarmobile for your efforts. I am actually in the process of raising another PR to resolve GH-547, and I have already unit-tested a rebase of my fixes (G

[GitHub] jcesarmobile closed issue #540: Issue to copy library from plugin after updating to v7.1.2

jcesarmobile closed issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jcesarmobile commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

jcesarmobile commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-438464420 Closing as the PR was merged in master This is

[GitHub] brodybits commented on a change in pull request #549: Cherry picks

brodybits commented on a change in pull request #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549#discussion_r233247934 ## File path: bin/templates/cordova/lib/pluginHandlers.js ## @@ -44,11 +37,8 @@ var handlers = { } },

[GitHub] brodybits commented on a change in pull request #549: Cherry picks

brodybits commented on a change in pull request #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549#discussion_r233247721 ## File path: bin/templates/cordova/lib/pluginHandlers.js ## @@ -28,14 +28,7 @@ var handlers = { if (!obj.src) throw

[GitHub] jcesarmobile commented on issue #548: How to use build-extras.gradle

jcesarmobile commented on issue #548: How to use build-extras.gradle URL: https://github.com/apache/cordova-android/issues/548#issuecomment-438461061 Yeah, what @dpogue said, you can use it to add extra configurations, but not to overwrite current file, and you can use 7.1.2 now. Closing

[GitHub] jcesarmobile closed issue #548: How to use build-extras.gradle

jcesarmobile closed issue #548: How to use build-extras.gradle URL: https://github.com/apache/cordova-android/issues/548 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHu

[GitHub] jcesarmobile opened a new pull request #549: Cherry picks

jcesarmobile opened a new pull request #549: Cherry picks URL: https://github.com/apache/cordova-android/pull/549 ### Platforms affected android ### What does this PR do? cherry-picks #539 and #540 fixes on 7.1.x branch ### What testing has been done on this chang

[cordova-plugin-camera] branch master updated: Bump minor version (#370)

This is an automated email from the ASF dual-hosted git repository. jcesarmobile pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cordova-plugin-camera.git The following commit(s) were added to refs/heads/master by this push: new eed4433 Bump minor version

[GitHub] diegodotta commented on issue #109: Status bar is always white

diegodotta commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-438433130 Basically, you need to add splashscreen plugin to fix this issue @Dwarfex. I was also having a weird issue using "window.cordova" befor

[GitHub] utiq commented on issue #109: Status bar is always white

utiq commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-438399808 @Dwarfex Exactly the steps that Stackoverflow response says. This is an autom

[GitHub] j3k0 commented on issue #547: Compatibility of old plugins with non-Java source-file entries

j3k0 commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438396827 > I was able to get https://github.com/j3k0/cordova-plugin-purchase#v7.1.0 to build Great! I'll prepare a new

[GitHub] xGeorge commented on issue #168: Invoke plugin initialize if the os restore the app

xGeorge commented on issue #168: Invoke plugin initialize if the os restore the app URL: https://github.com/apache/cordova-plugin-splashscreen/issues/168#issuecomment-438389547 webview ..invoke(intent).-> sdk activity, OS .if needs memory -> reset o frees memory from backgro

[GitHub] janpio commented on issue #168: Invoke plugin initialize if the os restore the app

janpio commented on issue #168: Invoke plugin initialize if the os restore the app URL: https://github.com/apache/cordova-plugin-splashscreen/issues/168#issuecomment-438387563 I still don't know what is happening when. This

[GitHub] xGeorge commented on issue #168: Invoke plugin initialize if the os restore the app

xGeorge commented on issue #168: Invoke plugin initialize if the os restore the app URL: https://github.com/apache/cordova-plugin-splashscreen/issues/168#issuecomment-438385381 At the moment android, basically im invoking a sdk(intent) but if it takes more than 5 minutes the OS restores t

[GitHub] martinhorvath commented on issue #904: Android WebViews documentation update

martinhorvath commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438379874 This sounds interesting but I have never stumbled across it. I'll get back here if I have an update on this.

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233163612 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233163348 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `Cordov

[GitHub] dpogue commented on issue #904: Android WebViews documentation update

dpogue commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438377307 I *believe* that would be true, but I've never tried it. This is an automated me

[GitHub] janpio commented on issue #904: Android WebViews documentation update

janpio commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438371744 @dpogue That would probably replace the first two steps... no need to copy any files around, right?

[GitHub] dpogue commented on issue #904: Android WebViews documentation update

dpogue commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438371037 Not sure where exactly this belongs, but if you're wanting to just pull cordova-android as a framework into an existing app, it's [published to

[GitHub] janpio commented on issue #168: Invoke plugin initialize if the os restore the app

janpio commented on issue #168: Invoke plugin initialize if the os restore the app URL: https://github.com/apache/cordova-plugin-splashscreen/issues/168#issuecomment-438370462 What platform are you referring to? What is happening when exactly? --

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233154802 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233154615 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-438369590 Issues with `cordova-plugin-deezer` and should now be solved by P

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438368308 @j3k0 I was able to get `https://github.com/j3k0/cordova-plugin-purchase#v7.1.0` (version before you started m

[GitHub] brodybits commented on issue #546: cordova-plugin-purchase plugin issues

brodybits commented on issue #546: cordova-plugin-purchase plugin issues URL: https://github.com/apache/cordova-android/issues/546#issuecomment-438368509 Now part of #547, closing as a duplicate This is an automated message fr

[GitHub] brodybits closed issue #546: cordova-plugin-purchase plugin issues

brodybits closed issue #546: cordova-plugin-purchase plugin issues URL: https://github.com/apache/cordova-android/issues/546 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries

brodybits commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438365548 > Seems to have a similar issue with plugin cordova-plugin-app-preferences This is due to their use of ho

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233149199 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `Cordov

[GitHub] xGeorge opened a new issue #168: Invoke plugin initialize if the os restore the app

xGeorge opened a new issue #168: Invoke plugin initialize if the os restore the app URL: https://github.com/apache/cordova-plugin-splashscreen/issues/168 If the OS restore(reset) the app a white screen is showing, unfortunately the cordova init and deviceready it's still not available ---

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233145627 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio edited a comment on issue #904: Android WebViews documentation update

janpio edited a comment on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438350020 You learned something for life now - I expect lots of future PRs from you :) -

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233144714 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `Cordov

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233141536 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233138104 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `Cordov

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233137000 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233136888 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233137000 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233136888 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233136656 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233136420 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233136226 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,56 @@ legacy `CordovaActivi

[GitHub] janpio commented on issue #904: Android WebViews documentation update

janpio commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438350020 You learned something for live now - I expect lots of future PRs from you :) Thi

[GitHub] martinhorvath commented on issue #904: Android WebViews documentation update

martinhorvath commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438349538 Applied the changes and thanks for getting me ramped up with the flow here. --

[GitHub] janpio commented on issue #904: Android WebViews documentation update

janpio commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438346483 You yourself usually don't use the "Suggest a change" functionality but make the changes in your codebase directly.

[GitHub] janpio commented on issue #904: Android WebViews documentation update

janpio commented on issue #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#issuecomment-438346251 I suggested some changes, you can either accept these here in the GitHub UI (Don't just resolve the conversation, you have to accept the changes

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233130517 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233130413 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233130130 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233129661 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233129330 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233127907 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] martinhorvath commented on a change in pull request #904: Android WebViews documentation update

martinhorvath commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233127095 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `Cordov

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233124549 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233124402 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `CordovaActivi

[GitHub] janpio commented on a change in pull request #904: Android WebViews documentation update

janpio commented on a change in pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904#discussion_r233124107 ## File path: www/docs/en/dev/guide/platforms/android/webview.md ## @@ -38,97 +38,57 @@ legacy `CordovaActivi

[GitHub] martinhorvath commented on issue #884: Embedding Android WebView doc looks broken

martinhorvath commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438339830 PR done, I tried my best to follow the contribution guidelines. Would appreciate if you let me know what I missed to do. --> h

[GitHub] martinhorvath opened a new pull request #904: Android WebViews documentation update

martinhorvath opened a new pull request #904: Android WebViews documentation update URL: https://github.com/apache/cordova-docs/pull/904 ### Platforms affected Android ### What does this PR do? Update outdated documentation ### What testing has been done on this change?

[GitHub] thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438325344 Seems to have a similar issue with plugin cordova-plugin-app-preferences Got the following e

[GitHub] thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438325344 Seems to have a similar problem with plugin cordova-plugin-app-preferences Got the following

[GitHub] thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries

thibaud-sanchez edited a comment on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438325344 Seems to have a similar problem with plugin cordova-plugin-app-preferences Got the following

[GitHub] thibaud-sanchez commented on issue #547: Compatibility of old plugins with non-Java source-file entries

thibaud-sanchez commented on issue #547: Compatibility of old plugins with non-Java source-file entries URL: https://github.com/apache/cordova-android/issues/547#issuecomment-438325344 Seems to have a similar problem with plugin cordova-plugin-app-preferences Got the following error

[GitHub] martinhorvath commented on issue #884: Embedding Android WebView doc looks broken

martinhorvath commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438322511 Ok let's see if I can fix this... This is an automated message fr

[GitHub] brodybits commented on issue #884: Embedding Android WebView doc looks broken

brodybits commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438322318 And we can always use `git show -b 6dc8836` or `git diff -b` to ignore the space changes.

[GitHub] janpio commented on issue #884: Embedding Android WebView doc looks broken

janpio commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321814 You can just create a Pull Request into this repository from your `patch-1` branch. Start here: https://github.com/apache/cordova-docs/com

[GitHub] janpio edited a comment on issue #884: Embedding Android WebView doc looks broken

janpio edited a comment on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321814 You can just create a Pull Request into this repository from your `patch-1` branch. Start here @martinhorvath: https://github.com

[GitHub] janpio commented on issue #884: Embedding Android WebView doc looks broken

janpio commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321625 Got it: https://github.com/martinhorvath/cordova-docs/commit/6dc8836ff669dbd6825093740a3115cb0c08b1c2 ---

[GitHub] janpio edited a comment on issue #884: Embedding Android WebView doc looks broken

janpio edited a comment on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321814 You can just create a Pull Request into this repository from your `patch-1` branch. Start here @brodybits: https://github.com/apac

[GitHub] brodybits commented on issue #884: Embedding Android WebView doc looks broken

brodybits commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321583 @martinhorvath a pull request would be much easier for us to track and comment on than a loose commit. While we would prefer the propos

[GitHub] martinhorvath commented on issue #884: Embedding Android WebView doc looks broken

martinhorvath commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438321427 It indeed is... I thought "lets see what happens if I suggest an edit using the url from the offical docs". So what shall I do

[GitHub] dpogue commented on issue #884: Embedding Android WebView doc looks broken

dpogue commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438320723 @janpio The commit is in his fork, it's just a GitHub URL/UI thing that makes it appear like it's in apache/cordova-docs. ---

[GitHub] janpio commented on issue #884: Embedding Android WebView doc looks broken

janpio commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438320094 I honestly don't understand how you were able to commit to this repo and where this commit actually "lives". How did you do that @martinho

[GitHub] brodybits commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working

brodybits commented on issue #494: Change from CordovaWebView to SystemWebView in latest Cordova not working URL: https://github.com/apache/cordova-android/issues/494#issuecomment-438319347 > [...] tried to reflect my findings in this update: [apache/cordova-docs@6dc8836](https://github.co

[GitHub] martinhorvath commented on issue #884: Embedding Android WebView doc looks broken

martinhorvath commented on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438319258 I had to find out that I really messed up the conventions of the commit and didn't want to create an even bigger mess with a pull

[GitHub] brodybits edited a comment on issue #884: Embedding Android WebView doc looks broken

brodybits edited a comment on issue #884: Embedding Android WebView doc looks broken URL: https://github.com/apache/cordova-docs/issues/884#issuecomment-438318495 @martinhorvath commented in : > I [...] tri

  1   2   >