brodybits commented on issue #550: Fix for old plugins with non-Java sources 
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438480204
 
 
   > `app/src/main` is used multiple times, might be worth to put it in a 
variable
   
   I can do this, would favor doing the same thing with some other prefixes 
such as `app` for the sake of consistency. Ultimate solution would be to do 
this for all destination prefixes.
   
   > [...] it also has .h and .c files that are treated as .java files.
   > They were `src/c/common/mylib/parts` and he updated them to 
`app/src/main/java/c/common/mylib`
   > 
   > We could add those two extensions in the .java check.
   
   Interesting idea, how should we test it? Anything beyond a unit test?
   
   I will try to do the rework later tonight, would like to get it into the 
7.1.3 patch if possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cordova.apache.org
For additional commands, e-mail: commits-h...@cordova.apache.org

Reply via email to