morningman commented on issue #3682:
URL:
https://github.com/apache/incubator-doris/issues/3682#issuecomment-635096155
我会关注下这个问题
This is an automated message from the Apache Git Service.
To respond to the message, please
morningman commented on pull request #3604:
URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-635091296
> @morningman
> The key point is that it's currently impossible to accurately estimate the
size of the memory footprint at runtime according to table
gaodayue opened a new pull request #3709:
URL: https://github.com/apache/incubator-doris/pull/3709
Fixes #3706
DataSink uses instance and query MemTracker from RuntimeState, therefore it
should be destructed before RuntimeState. Otherwise memory corruption and
segfault could
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431551854
##
File path: be/src/common/config.h
##
@@ -137,7 +140,7 @@ namespace config {
// the maximum number of bytes to display on the debug
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431551854
##
File path: be/src/common/config.h
##
@@ -137,7 +140,7 @@ namespace config {
// the maximum number of bytes to display on the debug
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431555420
##
File path: be/src/common/config.h
##
@@ -271,7 +274,7 @@ namespace config {
// Port to start debug webserver on
HangyuanLiu commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431551350
##
File path: fe/src/main/java/org/apache/doris/analysis/StatementBase.java
##
@@ -153,7 +156,17 @@ public String getClusterName() {
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431551854
##
File path: be/src/common/config.h
##
@@ -137,7 +140,7 @@ namespace config {
// the maximum number of bytes to display on the debug
EmmyMiao87 commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431549970
##
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##
@@ -1081,14 +969,8 @@ private void
EmmyMiao87 commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431549428
##
File path: fe/src/main/java/org/apache/doris/alter/RollupJobV2.java
##
@@ -770,4 +714,85 @@ public void setJobState(JobState jobState) {
chaoyli edited a comment on issue #3687:
URL:
https://github.com/apache/incubator-doris/issues/3687#issuecomment-635053228
Newly generated singleton rowset with single segment is set as
NONOVERLAPPING should after the cumulative point.
But newly generated singleton rowset may have
chaoyli edited a comment on issue #3687:
URL:
https://github.com/apache/incubator-doris/issues/3687#issuecomment-635053228
Newly generated singleton rowset with single segment is set as
NONOVERLAPPING should after the cumulative point.
But newly generated singleton rowset may have
chaoyli commented on issue #3687:
URL:
https://github.com/apache/incubator-doris/issues/3687#issuecomment-635053228
Newly generated singleton rowset with single segment is set as
NONOVERLAPPING should not be skipped.
But newly generated singleton rowset may have much segments, which
imay commented on a change in pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705#discussion_r431540575
##
File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
##
@@ -1081,14 +969,8 @@ private void readJobFinishedData(DataInput in)
chaoyli commented on issue #3687:
URL:
https://github.com/apache/incubator-doris/issues/3687#issuecomment-635045710
>
https://github.com/apache/incubator-doris/blob/a5922051c9bee4d75599847838596abcd8b0bd3b/be/src/olap/tablet.cpp#L681-L702
>
> I'm not sure what is the theoretical
WingsGo commented on a change in pull request #3527:
URL: https://github.com/apache/incubator-doris/pull/3527#discussion_r431536992
##
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##
@@ -306,6 +300,10 @@ private Type getCmpType() {
imay commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431532217
##
File path: be/src/common/config.h
##
@@ -137,7 +140,7 @@ namespace config {
// the maximum number of bytes to display on the debug
chaoyli commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699#discussion_r431528008
##
File path: be/src/olap/olap_cond.cpp
##
@@ -651,14 +651,10 @@ bool Conditions::delete_conditions_eval(const RowCursor&
row) const {
bool
chaoyli closed issue #3707:
URL: https://github.com/apache/incubator-doris/issues/3707
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chaoyli merged pull request #3708:
URL: https://github.com/apache/incubator-doris/pull/3708
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
lichaoyong pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from bc35f3a [DynamicPartition] Optimize the rule of creating dynamic
partition (#3679)
add f89d970
morningman commented on a change in pull request #3668:
URL: https://github.com/apache/incubator-doris/pull/3668#discussion_r431202778
##
File path: fe/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java
##
@@ -233,6 +236,23 @@ public static TStorageType
morningman opened a new pull request #3708:
URL: https://github.com/apache/incubator-doris/pull/3708
The metrics in a metric collector need have same type, but no need
to have same unit.
This is an automated message from
morningman opened a new issue #3707:
URL: https://github.com/apache/incubator-doris/issues/3707
**Describe the bug**
When visiting metrics page of BE, some of metrics are missing
`be_host:be_port/metrics`
`doris_be_stream_load{type="load_rows"}` is missing, so does some
morningman commented on issue #3706:
URL:
https://github.com/apache/incubator-doris/issues/3706#issuecomment-634695936
This is a great problem description and troubleshooting process!
This is an automated message from the
morningman commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699#discussion_r431073031
##
File path: be/src/olap/olap_cond.cpp
##
@@ -651,14 +651,10 @@ bool Conditions::delete_conditions_eval(const RowCursor&
row) const {
bool
gaodayue opened a new issue #3706:
URL: https://github.com/apache/incubator-doris/issues/3706
**Describe the bug**
BE crashes with the following logs in be.out
```
start time: Tue May 19 18:15:02 CST 2020
*** Aborted at 1590397931 (unix time) try "date -d @1590397931" if you
EmmyMiao87 commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699#discussion_r431094333
##
File path: be/src/olap/olap_cond.cpp
##
@@ -651,14 +651,10 @@ bool Conditions::delete_conditions_eval(const RowCursor&
row) const {
bool
yangzhg commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699#discussion_r431091314
##
File path: be/src/olap/olap_cond.cpp
##
@@ -651,14 +651,10 @@ bool Conditions::delete_conditions_eval(const RowCursor&
row) const {
bool
EmmyMiao87 opened a new pull request #3705:
URL: https://github.com/apache/incubator-doris/pull/3705
In materialized view 2.0, the define expr is serialized in column.
The method is that doris serialzie the origin stmt of Create Materialzied
View Stmt in RollupJobV2 and MVMeta.
The
wutiangan commented on a change in pull request #3527:
URL: https://github.com/apache/incubator-doris/pull/3527#discussion_r431049795
##
File path: fe/src/main/java/org/apache/doris/analysis/BinaryPredicate.java
##
@@ -306,6 +300,10 @@ private Type getCmpType() {
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431048024
##
File path: be/src/common/config.h
##
@@ -30,6 +30,9 @@ namespace config {
// port for brpc
CONF_Int32(brpc_port, "8060");
+
wutiangan commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431043291
##
File path: be/src/common/config.h
##
@@ -30,6 +30,9 @@ namespace config {
// port for brpc
CONF_Int32(brpc_port, "8060");
+
wutiangan commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431043291
##
File path: be/src/common/config.h
##
@@ -30,6 +30,9 @@ namespace config {
// port for brpc
CONF_Int32(brpc_port, "8060");
+
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431036836
##
File path: docs/en/administrator-guide/config/be_config.md
##
@@ -77,6 +77,12 @@ Sometimes the query fails and an error message of `The
caiconghui commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r431034169
##
File path: be/src/runtime/stream_load/stream_load_context.cpp
##
@@ -70,6 +70,17 @@ std::string StreamLoadContext::to_json() const {
morningman commented on issue #3624:
URL:
https://github.com/apache/incubator-doris/issues/3624#issuecomment-634579372
That is more clear.
And we need to think about
1. what strategy the producer use to produce the tablet for compaction? by
the `score`?
2. If we use the score,
morningman commented on pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#issuecomment-634574953
> Thanks for your reply, so if the `scan keys` extends to `(a=1, b>5), (a=2,
b>5), (a=3, b>5)` , doris will split into 3 scanners to scan RowBatch which
satisified
vagetablechicken commented on issue #3624:
URL:
https://github.com/apache/incubator-doris/issues/3624#issuecomment-634573432
We can add a PermitLimiter to do the limitation, and use
single-producer/multi-consumer model.
Producer will try to acquire permits, if ok, add the compaction
WingsGo commented on pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#issuecomment-634546368
> > Hi, @morningman I have some question about olap_scan_node, could you plz
help me figure it out?
> >
> > 1. what's the relationship between scanner and tablet,
vagetablechicken opened a new issue #3704:
URL: https://github.com/apache/incubator-doris/issues/3704
https://github.com/apache/incubator-doris/issues/3624 needs to link more mem
trackers.
e.g. we will create a compaction mem tracker, and let all trackers in
compaction be its
worker24h commented on a change in pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702#discussion_r430978446
##
File path: be/src/exprs/json_functions.h
##
@@ -72,6 +72,7 @@ class JsonFunctions {
/**
* The `document` parameter must be has
worker24h commented on a change in pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702#discussion_r430977156
##
File path: be/src/exprs/json_functions.h
##
@@ -72,6 +72,7 @@ class JsonFunctions {
/**
* The `document` parameter must be has
morningman commented on a change in pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#discussion_r430974951
##
File path: be/src/runtime/stream_load/stream_load_context.cpp
##
@@ -70,6 +70,17 @@ std::string StreamLoadContext::to_json() const {
morningman commented on a change in pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702#discussion_r430972569
##
File path: be/src/exprs/json_functions.h
##
@@ -72,6 +72,7 @@ class JsonFunctions {
/**
* The `document` parameter must be has
caiconghui closed issue #3671:
URL: https://github.com/apache/incubator-doris/issues/3671
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
morningman commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430969199
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -736,100 +735,114 @@ static bool ignore_cast(SlotDescriptor* slot, Expr*
expr) {
morningman commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430967592
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -838,39 +851,52 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot,
morningman commented on pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#issuecomment-634526451
> Hi, @morningman I have some question about olap_scan_node, could you plz
help me figure it out?
>
> 1. what's the relationship between scanner and tablet,
morningman closed issue #3678:
URL: https://github.com/apache/incubator-doris/issues/3678
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git.
from 1cc78fe [Enhancement] Convert metric to Json format (#3635)
add bc35f3a [DynamicPartition]
caiconghui commented on pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703#issuecomment-634513939
ref #3696
This is an automated message from the Apache Git Service.
To respond to the message,
caiconghui opened a new pull request #3703:
URL: https://github.com/apache/incubator-doris/pull/3703
This PR mainly do three things:
1. Make brpc_num_threads configurable to get better performance for qps
2. Change some default config in be to make doris get better performance
both
worker24h commented on issue #3697:
URL:
https://github.com/apache/incubator-doris/issues/3697#issuecomment-634512507
I fixed the bug.
PR： https://github.com/apache/incubator-doris/pull/3702
This is an automated
worker24h opened a new pull request #3702:
URL: https://github.com/apache/incubator-doris/pull/3702
The data is always 1 by json load
https://github.com/apache/incubator-doris/issues/3697
This is an automated
vagetablechicken opened a new pull request #3701:
URL: https://github.com/apache/incubator-doris/pull/3701
ref impala
ref an issue
This is an automated message from the Apache Git Service.
To respond to the
WingsGo commented on pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#issuecomment-634495845
Hi, @morningman I have some question about olap_scan_node, could you plz
help me figure it out?
1. what's the relationship between scanner and tablet, one tablet can
vagetablechicken edited a comment on issue #3624:
URL:
https://github.com/apache/incubator-doris/issues/3624#issuecomment-634468867
Before a new compaction strategy, we should add compaction memory usage
monitoring. It'll help us adjust the model parameters. We could use MemTracker,
not
chaoyli opened a new issue #3700:
URL: https://github.com/apache/incubator-doris/issues/3700
```
CREATE TABLE `query_detail` (
`query_id` varchar(100) NULL COMMENT "",
`start_time` datetime NULL COMMENT "",
`end_time` datetime NULL COMMENT "",
chaoyli opened a new pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699
```
CREATE TABLE `query_detail` (
`query_id` varchar(100) NULL COMMENT "",
`start_time` datetime NULL COMMENT "",
`end_time` datetime NULL COMMENT "",
`latency` int(11)
wenbronk commented on issue #3682:
URL:
https://github.com/apache/incubator-doris/issues/3682#issuecomment-634477366
> `手动抛出异常`是指什么？
抛出异常, 终止事务, 让producer开启的事务不能正常提交.
```java
Properties kafkaProperties = new Properties();
kafkaProperties.put("acks", "all");
decster commented on a change in pull request #3637:
URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r430899427
##
File path: be/src/olap/memory/mem_sub_tablet.cpp
##
@@ -0,0 +1,247 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
vagetablechicken commented on issue #3624:
URL:
https://github.com/apache/incubator-doris/issues/3624#issuecomment-634468867
Before a new compaction strategy, we should add compaction memory usage
monitoring. It'll help us adjust the model parameters. We could use MemTracker.
WingsGo commented on issue #3698:
URL:
https://github.com/apache/incubator-doris/issues/3698#issuecomment-634462835
> LGTM, maybe we can add a new column to show some info together in JSON
format.
> So that if we want to add more info later, there is no need to add more
columns in
morningman commented on issue #3682:
URL:
https://github.com/apache/incubator-doris/issues/3682#issuecomment-634462573
`手动抛出异常`是指什么？
This is an automated message from the Apache Git Service.
To respond to the message,
morningman commented on issue #3689:
URL:
https://github.com/apache/incubator-doris/issues/3689#issuecomment-634461862
I probably understand what you mean, but I am not sure whether the specific
plan is feasible. In your proposal, only the query about latency is mentioned,
which can be
kangkaisen commented on a change in pull request #3694:
URL: https://github.com/apache/incubator-doris/pull/3694#discussion_r430887312
##
File path: be/src/exec/olap_scan_node.cpp
##
@@ -884,25 +910,54 @@ Status
OlapScanNode::normalize_in_predicate(SlotDescriptor* slot,
morningman commented on issue #3698:
URL:
https://github.com/apache/incubator-doris/issues/3698#issuecomment-634458410
LGTM, maybe we can add a new column to show some info together in JSON
format.
So that if we want to add more info later, there is no need to add more
columns in
morningman commented on issue #3696:
URL:
https://github.com/apache/incubator-doris/issues/3696#issuecomment-634457445
Looking forward to your PR
This is an automated message from the Apache Git Service.
To respond to the
decster commented on a change in pull request #3637:
URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r430881935
##
File path: be/src/olap/memory/mem_sub_tablet.cpp
##
@@ -0,0 +1,247 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
WingsGo opened a new issue #3698:
URL: https://github.com/apache/incubator-doris/issues/3698
Recently, I found a cluster's BE's tablets is not balance, and the balance
error msg is `path hash is not set`, I finally found that some BE cannot report
it's tablets to BE because the
71 matches
Mail list logo
