github-actions[bot] closed pull request #24972: [improvement](scanner) push
down late arrival runtime filters into SegmentIterator
URL: https://github.com/apache/doris/pull/24972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-2146330739
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of
keeping the PR queue manageable
yiguolei commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1417109438
##
be/src/vec/exec/scan/vscanner.cpp:
##
@@ -167,13 +167,34 @@ Status VScanner::try_append_late_arrival_runtime_filter()
{
// But it is ok because it will be upd
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1826382883
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit a51ee514fe5aba52a6c5dd61ad8a5dff3b052f97,
data reload: false
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1826382834
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.57 seconds
stream load tsv: 566 seconds loaded 74807831229 Bytes,
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1826357350
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1405139431
##
be/src/olap/reader.cpp:
##
@@ -680,4 +687,19 @@ Status TabletReader::init_reader_params_and_create_block(
return Status::OK();
}
+Status TabletRe
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1826355623
run buidlall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825931089
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 8fcd94d67360eb0cddbe2450a2c2b90230e33be6,
data reload: true
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825916044
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.32 seconds
stream load tsv: 567 seconds loaded 74807831229 Bytes,
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825838897
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825188102
run p0 10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825134187
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit a00fa86c8c19207574a3e591c04e8d7863d93e55,
data reload: false
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825132529
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.69 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes,
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1825070066
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1824259002
run p0 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1824010468
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.32 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1824005724
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 6804efd6d838412d1c11a29812fe82307952eac4,
data reload: false
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1823965080
TeamCity be ut coverage result:
Function Coverage: 36.55% (8451/23120)
Line Coverage: 28.85% (68722/238231)
Region Coverage: 27.82% (35547/127780)
Branch Coverage: 24.5
github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1402969335
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1946,6 +1972,128 @@ Status
SegmentIterator::_read_columns_by_rowids(std::vector& read_colu
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1823884939
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818796192
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.87 seconds
stream load tsv: 579 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818777353
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 554ec4fa21af77411fc623d1be9c8bffa8b6e581,
data reload: false
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818734263
TeamCity be ut coverage result:
Function Coverage: 36.48% (8448/23157)
Line Coverage: 28.82% (68701/238362)
Region Coverage: 27.79% (35519/127812)
Branch Coverage: 24.5
github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1398825963
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1946,6 +2028,181 @@
return Status::OK();
}
+Status SegmentIterator::_process_late_arri
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818464630
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818254777
TPC-H test result on machine:
'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit 05f3e9b0766c9a2ad896515a7fd86b99286ab4ab,
data reload: false
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818212083
TeamCity be ut coverage result:
Function Coverage: 36.47% (8449/23166)
Line Coverage: 28.81% (68695/238416)
Region Coverage: 27.79% (35526/127825)
Branch Coverage: 24.5
github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1398627872
##
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##
@@ -1946,6 +2014,200 @@ Status
SegmentIterator::_read_columns_by_rowids(std::vector& read_colu
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1818163963
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1377820756
##
be/src/olap/reader.cpp:
##
@@ -684,4 +687,19 @@ Status TabletReader::init_reader_params_and_create_block(
return Status::OK();
}
+Status TabletRe
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1787485387
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
yiguolei commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1361400413
##
be/src/olap/reader.cpp:
##
@@ -237,6 +239,7 @@ Status TabletReader::_capture_rs_readers(const
ReaderParams& read_params) {
_reader_context.read_orderby_key_co
yiguolei commented on code in PR #24972:
URL: https://github.com/apache/doris/pull/24972#discussion_r1361399663
##
be/src/olap/predicate_creator.h:
##
@@ -203,36 +257,76 @@ std::unique_ptr>
get_creator(const FieldType& ty
return std::make_unique>();
}
case Fi
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751614891
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.38 seconds
stream load tsv: 558 seconds loaded 74807831229 Bytes,
doris-robot commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751612665
TeamCity be ut coverage result:
Function Coverage: 36.25% (8151/22483)
Line Coverage: 28.38% (65218/229763)
Region Coverage: 27.33% (33777/123604)
Branch Coverage: 24.0
github-actions[bot] commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751602846
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751601104
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751591716
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mrhhsg commented on PR #24972:
URL: https://github.com/apache/doris/pull/24972#issuecomment-1751589671
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
40 matches
Mail list logo
