[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218317320 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildComplexMet

[incubator-druid] branch master updated: Fix dictionary ID race condition in IncrementalIndexStorageAdapter (#6340)

2018-09-17 Thread leventov
This is an automated email from the ASF dual-hosted git repository. leventov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 609da01 Fix dictionary ID race condi

[GitHub] leventov closed pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter

2018-09-17 Thread GitBox
leventov closed pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter URL: https://github.com/apache/incubator-druid/pull/6340 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] zhaojiandong opened a new issue #6343: Druid parse error on formatted time field with non-zero timezone

2018-09-17 Thread GitBox
zhaojiandong opened a new issue #6343: Druid parse error on formatted time field with non-zero timezone URL: https://github.com/apache/incubator-druid/issues/6343 part of jvm.config: ``` -Duser.timezone=Asia/Shanghai ``` timestampSpec config : ``` "timestampSpec": {

[GitHub] chillinger edited a comment on issue #5853: SegmentListerResource.getSegments() must return non-void type

2018-09-17 Thread GitBox
chillinger edited a comment on issue #5853: SegmentListerResource.getSegments() must return non-void type URL: https://github.com/apache/incubator-druid/issues/5853#issuecomment-422267828 I have encountered the exact same issue - this warning occured in my logs as well and the respective

[GitHub] chillinger commented on issue #5853: SegmentListerResource.getSegments() must return non-void type

2018-09-17 Thread GitBox
chillinger commented on issue #5853: SegmentListerResource.getSegments() must return non-void type URL: https://github.com/apache/incubator-druid/issues/5853#issuecomment-422267828 I have encountered the exact same issue - this warning occured in my logs as well and the respective real ti

[GitHub] leventov commented on issue #4672: "Object" aggregator factories mutate queryable data during index merging

2018-09-17 Thread GitBox
leventov commented on issue #4672: "Object" aggregator factories mutate queryable data during index merging URL: https://github.com/apache/incubator-druid/issues/4672#issuecomment-422252377 @jihoonson rollup aggregation doesn't yet work via `makeAggregateCombiner()`, so no, this is still

[GitHub] leventov closed issue #4658: Bug in TimestampMinAggregatorFactory.combine()

2018-09-17 Thread GitBox
leventov closed issue #4658: Bug in TimestampMinAggregatorFactory.combine() URL: https://github.com/apache/incubator-druid/issues/4658 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] leventov commented on issue #4658: Bug in TimestampMinAggregatorFactory.combine()

2018-09-17 Thread GitBox
leventov commented on issue #4658: Bug in TimestampMinAggregatorFactory.combine() URL: https://github.com/apache/incubator-druid/issues/4658#issuecomment-422250822 Fixed in #4676 This is an automated message from the Apache

[GitHub] QiuMM opened a new pull request #6342: Add support for Graylog

2018-09-17 Thread GitBox
QiuMM opened a new pull request #6342: Add support for Graylog URL: https://github.com/apache/incubator-druid/pull/6342 By add such dependency (using MIT License) , we can send all our logs to [Graylog](http://docs.graylog.org/en/2.4/) server. We just need to configure the `log4j2.xml` fo

[GitHub] notbdu opened a new issue #6341: Questions: Joining Columns/Compression/Segments

2018-09-17 Thread GitBox
notbdu opened a new issue #6341: Questions: Joining Columns/Compression/Segments URL: https://github.com/apache/incubator-druid/issues/6341 Hi, I had a few questions: - Where is the code located that reads segment files for separate columns and joins them together? - Where is the

[GitHub] jon-wei commented on issue #6339: Tweak isInvalidRows behavior in HadoopTuningConfig

2018-09-17 Thread GitBox
jon-wei commented on issue #6339: Tweak isInvalidRows behavior in HadoopTuningConfig URL: https://github.com/apache/incubator-druid/pull/6339#issuecomment-422218940 Fixing tests This is an automated message from the Apache Gi

[GitHub] gianm commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
gianm commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218272614 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAggreg

[GitHub] gianm commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
gianm commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218272614 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAggreg

[GitHub] jon-wei commented on a change in pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter

2018-09-17 Thread GitBox
jon-wei commented on a change in pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter URL: https://github.com/apache/incubator-druid/pull/6340#discussion_r218272585 ## File path: processing/src/main/java/org/apache/druid/segment/incremental/Increme

[GitHub] jihoonson commented on a change in pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter

2018-09-17 Thread GitBox
jihoonson commented on a change in pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter URL: https://github.com/apache/incubator-druid/pull/6340#discussion_r218271968 ## File path: processing/src/main/java/org/apache/druid/segment/incremental/Incre

[GitHub] jon-wei opened a new pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter

2018-09-17 Thread GitBox
jon-wei opened a new pull request #6340: Fix dictionary ID race condition in IncrementalIndexStorageAdapter URL: https://github.com/apache/incubator-druid/pull/6340 Possibly fixes https://github.com/apache/incubator-druid/issues/4937 There is currently a race conditio

[GitHub] jon-wei commented on issue #6222: Add ability to pass in Bloom filter from Hive Queries

2018-09-17 Thread GitBox
jon-wei commented on issue #6222: Add ability to pass in Bloom filter from Hive Queries URL: https://github.com/apache/incubator-druid/pull/6222#issuecomment-422203936 @nishantmonu51 Can you add docs for this? An example of what a serialized BloomFilter input looks like and what it represe

[GitHub] jihoonson commented on issue #3879: JSON parsing bad metrics fails ignoring `ignoreInvalidRows`

2018-09-17 Thread GitBox
jihoonson commented on issue #3879: JSON parsing bad metrics fails ignoring `ignoreInvalidRows` URL: https://github.com/apache/incubator-druid/issues/3879#issuecomment-422197516 Looks that this is fixed in https://github.com/apache/incubator-druid/pull/5418. Closing now.

[GitHub] jihoonson closed issue #3879: JSON parsing bad metrics fails ignoring `ignoreInvalidRows`

2018-09-17 Thread GitBox
jihoonson closed issue #3879: JSON parsing bad metrics fails ignoring `ignoreInvalidRows` URL: https://github.com/apache/incubator-druid/issues/3879 This is an automated message from the Apache Git Service. To respond to the

[GitHub] jihoonson closed issue #4073: PeriodGranularity doesn't work right in Kathmandu

2018-09-17 Thread GitBox
jihoonson closed issue #4073: PeriodGranularity doesn't work right in Kathmandu URL: https://github.com/apache/incubator-druid/issues/4073 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] jihoonson commented on issue #4073: PeriodGranularity doesn't work right in Kathmandu

2018-09-17 Thread GitBox
jihoonson commented on issue #4073: PeriodGranularity doesn't work right in Kathmandu URL: https://github.com/apache/incubator-druid/issues/4073#issuecomment-422197177 Fixed in #5410. This is an automated message from the Ap

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218212100 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildC

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218210188 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218212326 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218190236 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218213945 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStri

[GitHub] jihoonson commented on issue #4218: QueryGranularity incompatible behavior w.r.t timezone in 0.10.0

2018-09-17 Thread GitBox
jihoonson commented on issue #4218: QueryGranularity incompatible behavior w.r.t timezone in 0.10.0 URL: https://github.com/apache/incubator-druid/issues/4218#issuecomment-422196504 Looks like this was fixed in #4611. I'm closing this issue. --

[GitHub] jihoonson closed issue #4218: QueryGranularity incompatible behavior w.r.t timezone in 0.10.0

2018-09-17 Thread GitBox
jihoonson closed issue #4218: QueryGranularity incompatible behavior w.r.t timezone in 0.10.0 URL: https://github.com/apache/incubator-druid/issues/4218 This is an automated message from the Apache Git Service. To respond t

[GitHub] jon-wei opened a new pull request #6339: Tweak isInvalidRows behavior in HadoopTuningConfig

2018-09-17 Thread GitBox
jon-wei opened a new pull request #6339: Tweak isInvalidRows behavior in HadoopTuningConfig URL: https://github.com/apache/incubator-druid/pull/6339 Changes behavior so that if `maxParseExceptions` (new exception handling property) is set, it overrides the old `ignoreInvalidRows` property.

[GitHub] jihoonson commented on issue #4658: Bug in TimestampMinAggregatorFactory.combine()

2018-09-17 Thread GitBox
jihoonson commented on issue #4658: Bug in TimestampMinAggregatorFactory.combine() URL: https://github.com/apache/incubator-druid/issues/4658#issuecomment-422192386 Hi @leventov, can we close this? This is an automated messa

[GitHub] jihoonson commented on issue #4672: "Object" aggregator factories mutate queryable data during index merging

2018-09-17 Thread GitBox
jihoonson commented on issue #4672: "Object" aggregator factories mutate queryable data during index merging URL: https://github.com/apache/incubator-druid/issues/4672#issuecomment-422191797 Hi @leventov, can we close this issue? ---

[GitHub] jihoonson commented on issue #4915: TopN query on multi-value dimension ignores null values

2018-09-17 Thread GitBox
jihoonson commented on issue #4915: TopN query on multi-value dimension ignores null values URL: https://github.com/apache/incubator-druid/issues/4915#issuecomment-422190362 Hi @nishantmonu51, would you please double check that this issue was fixed in #5278? -

[GitHub] jihoonson commented on issue #5230: Port confliction in peon

2018-09-17 Thread GitBox
jihoonson commented on issue #5230: Port confliction in peon URL: https://github.com/apache/incubator-druid/issues/5230#issuecomment-422189955 I would say it's better for peon to find a usable port by its own and let the middleManager know it. -

[GitHub] jihoonson commented on issue #5727: Lookup module not registered with overlord

2018-09-17 Thread GitBox
jihoonson commented on issue #5727: Lookup module not registered with overlord URL: https://github.com/apache/incubator-druid/issues/5727#issuecomment-422187111 I think this isn't a bug but a missing feature. I'll change the label. --

[GitHub] jihoonson commented on issue #5697: Middle Managers have their tasks killed if they restart with a different Port

2018-09-17 Thread GitBox
jihoonson commented on issue #5697: Middle Managers have their tasks killed if they restart with a different Port URL: https://github.com/apache/incubator-druid/issues/5697#issuecomment-422186053 Hi @drcrallen, do you still think this is a bug? And should we fix this in 0.13.0? -

[GitHub] a2l007 commented on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0

2018-09-17 Thread GitBox
a2l007 commented on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0 URL: https://github.com/apache/incubator-druid/issues/4875#issuecomment-422183016 @jihoonson Yeah, this has been fixed in #5029 . Closing this issue.

[GitHub] a2l007 closed issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0

2018-09-17 Thread GitBox
a2l007 closed issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0 URL: https://github.com/apache/incubator-druid/issues/4875 This is an automated message from the Apache Git Service.

[GitHub] jihoonson commented on issue #6001: Segment publishing order should be preserved in kafka indexing service

2018-09-17 Thread GitBox
jihoonson commented on issue #6001: Segment publishing order should be preserved in kafka indexing service URL: https://github.com/apache/incubator-druid/issues/6001#issuecomment-422179876 I think this isn't a blocking issue for 0.13.0 release since this bug happens pretty rarely. Let's f

[GitHub] jihoonson commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor

2018-09-17 Thread GitBox
jihoonson commented on issue #6006: Kafka ingestion tasks are not killed and keep spawning after stopping Supervisor URL: https://github.com/apache/incubator-druid/issues/6006#issuecomment-422179244 Hi @TwojaWina, would you please check @gianm's comment? Also, it would be very helpful to

[GitHub] jihoonson edited a comment on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0

2018-09-17 Thread GitBox
jihoonson edited a comment on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0 URL: https://github.com/apache/incubator-druid/issues/4875#issuecomment-422176706 Hi @a2l007, this looks to be fixed in https://github.com/apache/incubator-druid/pul

[GitHub] jihoonson commented on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0

2018-09-17 Thread GitBox
jihoonson commented on issue #4875: Remove temp code in LookupReferencesManager to support rolling upgrade in 0.11.0 URL: https://github.com/apache/incubator-druid/issues/4875#issuecomment-422176706 Hi @a2l007, this looks to be fixed in https://github.com/apache/incubator-druid/pull/4758.

[GitHub] jihoonson commented on issue #3530: Create basePersistDirectory only when needed

2018-09-17 Thread GitBox
jihoonson commented on issue #3530: Create basePersistDirectory only when needed URL: https://github.com/apache/incubator-druid/pull/3530#issuecomment-422174674 The original issue (#3347) has been fixed in https://github.com/apache/incubator-druid/pull/5648, but this PR looks to solve anot

[GitHub] jihoonson closed issue #3347: Confusing directory creation error on RealtimeTuningConfig construction

2018-09-17 Thread GitBox
jihoonson closed issue #3347: Confusing directory creation error on RealtimeTuningConfig construction URL: https://github.com/apache/incubator-druid/issues/3347 This is an automated message from the Apache Git Service. To re

[GitHub] jihoonson commented on issue #3347: Confusing directory creation error on RealtimeTuningConfig construction

2018-09-17 Thread GitBox
jihoonson commented on issue #3347: Confusing directory creation error on RealtimeTuningConfig construction URL: https://github.com/apache/incubator-druid/issues/3347#issuecomment-422174166 Fixed in https://github.com/apache/incubator-druid/pull/5648. -

[GitHub] jihoonson commented on issue #5315: add unusedMarkWaitDuration config to auto-kill feature

2018-09-17 Thread GitBox
jihoonson commented on issue #5315: add unusedMarkWaitDuration config to auto-kill feature URL: https://github.com/apache/incubator-druid/pull/5315#issuecomment-422173263 Hi guys, I don't think this should be a blocking issue for 0.13.0 release. I'll remove the milestone.

[GitHub] jihoonson commented on issue #5345: [WIP]Use DefaultBlockingPool for Global Processing Pool instead of StupidPool that can allocate arbitrary number of buffers and cause crashes.

2018-09-17 Thread GitBox
jihoonson commented on issue #5345: [WIP]Use DefaultBlockingPool for Global Processing Pool instead of StupidPool that can allocate arbitrary number of buffers and cause crashes. URL: https://github.com/apache/incubator-druid/pull/5345#issuecomment-422172371 Hi guys, I don't think this sh

[GitHub] jihoonson commented on issue #5906: Rewriting IncrementalPublishingKafkaIndexTaskRunner

2018-09-17 Thread GitBox
jihoonson commented on issue #5906: Rewriting IncrementalPublishingKafkaIndexTaskRunner URL: https://github.com/apache/incubator-druid/issues/5906#issuecomment-422172216 I'm removing this from 0.13.0 milestone. This is an au

[GitHub] jihoonson commented on issue #6222: Add ability to pass in Bloom filter from Hive Queries

2018-09-17 Thread GitBox
jihoonson commented on issue #6222: Add ability to pass in Bloom filter from Hive Queries URL: https://github.com/apache/incubator-druid/pull/6222#issuecomment-422172006 Hi @nishantmonu51, do you think this should be a blocking issue for 0.13.0 release? ---

[GitHub] jihoonson commented on issue #6327: Druid based on OakIncrementalIndex

2018-09-17 Thread GitBox
jihoonson commented on issue #6327: Druid based on OakIncrementalIndex URL: https://github.com/apache/incubator-druid/pull/6327#issuecomment-422171030 Hi guys, I don't think this should be a blocking issue for 0.13.0 release. I'll remove the milestone. -

[incubator-druid] branch master updated: add a sql option to force user to specify time condition (#6246)

2018-09-17 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new edf0c13 add a sql option to force user

[GitHub] jon-wei closed pull request #6246: add a sql option to force user to specify time condition

2018-09-17 Thread GitBox
jon-wei closed pull request #6246: add a sql option to force user to specify time condition URL: https://github.com/apache/incubator-druid/pull/6246 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jon-wei closed pull request #5997: Add maxIdleTime option to EventReceiverFirehose

2018-09-17 Thread GitBox
jon-wei closed pull request #5997: Add maxIdleTime option to EventReceiverFirehose URL: https://github.com/apache/incubator-druid/pull/5997 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-druid] branch master updated: Add maxIdleTime option to EventReceiverFirehose (#5997)

2018-09-17 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 2fac674 Add maxIdleTime option to Even

[GitHub] jihoonson opened a new issue #6338: OutOfMemory error while merging in AppenderatorImpl

2018-09-17 Thread GitBox
jihoonson opened a new issue #6338: OutOfMemory error while merging in AppenderatorImpl URL: https://github.com/apache/incubator-druid/issues/6338 `AppenderatorImpl` currently merges all persisted indexes at once. This can incur OOM error like below if there are too many indexes to be merg

[GitHub] jsun98 commented on a change in pull request #6304: fixes race condition in kafkasupervisor

2018-09-17 Thread GitBox
jsun98 commented on a change in pull request #6304: fixes race condition in kafkasupervisor URL: https://github.com/apache/incubator-druid/pull/6304#discussion_r218210763 ## File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/K

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218208220 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAgg

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218206022 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAgg

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218203663 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggregatorFacto

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218202687 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildComplexMet

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218201483 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeBufferAggr

[GitHub] leventov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
leventov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218201483 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeBufferAggr

[GitHub] b-slim commented on issue #6215: Adding licenses and enable apache-rat-plugin.

2018-09-17 Thread GitBox
b-slim commented on issue #6215: Adding licenses and enable apache-rat-plugin. URL: https://github.com/apache/incubator-druid/pull/6215#issuecomment-422131728 @gianm thanks for review can you please recheck this. This is an au

[GitHub] DaimonPl commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
DaimonPl commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218184150 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggregatorFacto

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218182251 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStri

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218181818 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeC

[GitHub] QiuMM commented on a change in pull request #6335: Added backpressure metric

2018-09-17 Thread GitBox
QiuMM commented on a change in pull request #6335: Added backpressure metric URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r218099350 ## File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java ## @@ -203,13 +203,16 @@ public int

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218179775 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeA

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218179474 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildC

[GitHub] QiuMM commented on issue #6291: Using Entry directly instead of Map.Entry in KafkaSupervisor

2018-09-17 Thread GitBox
QiuMM commented on issue #6291: Using Entry directly instead of Map.Entry in KafkaSupervisor URL: https://github.com/apache/incubator-druid/pull/6291#issuecomment-422122450 @jon-wei Can you help review this PR? It's very simple. IMO every place refer to the `Entry` class all written in `En

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218178331 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218177116 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeC

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218176335 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218176293 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildB

[GitHub] gianm commented on issue #6215: Adding licenses and enable apache-rat-plugin.

2018-09-17 Thread GitBox
gianm commented on issue #6215: Adding licenses and enable apache-rat-plugin. URL: https://github.com/apache/incubator-druid/pull/6215#issuecomment-422119398 @b-slim are you able to continue working on this? This is an automat

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218172538 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchMergeB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218165763 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildC

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218163526 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218163416 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildB

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218159965 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchBuildA

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218158213 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218157605 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] gianm commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
gianm commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218150621 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAggreg

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218149760 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218149564 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] gianm commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
gianm commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218149406 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToStringPostAggreg

[GitHub] gianm commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
gianm commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218149008 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggregatorFactory.

[GitHub] AlexanderSaydakov commented on a change in pull request #5712: HllSketch module

2018-09-17 Thread GitBox
AlexanderSaydakov commented on a change in pull request #5712: HllSketch module URL: https://github.com/apache/incubator-druid/pull/5712#discussion_r218147776 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchAggreg

[GitHub] QiuMM opened a new pull request #6337: Fix Kafka Indexing Service notice handle thread may never terminate

2018-09-17 Thread GitBox
QiuMM opened a new pull request #6337: Fix Kafka Indexing Service notice handle thread may never terminate URL: https://github.com/apache/incubator-druid/pull/6337 Today, I printed jstack of my overlord node, then I found there was a KIS supervisor thread which should have been shutdown lo

[GitHub] QiuMM commented on a change in pull request #6335: Added backpressure metric

2018-09-17 Thread GitBox
QiuMM commented on a change in pull request #6335: Added backpressure metric URL: https://github.com/apache/incubator-druid/pull/6335#discussion_r218099350 ## File path: server/src/main/java/org/apache/druid/client/DirectDruidClient.java ## @@ -203,13 +203,16 @@ public int

[GitHub] FaxianZhao commented on issue #6283: update insert pending segments logic to synchronous

2018-09-17 Thread GitBox
FaxianZhao commented on issue #6283: update insert pending segments logic to synchronous URL: https://github.com/apache/incubator-druid/pull/6283#issuecomment-421958039 Hi, @gianm I'm sorry, I delete the branch about #6283 by mistake. I can't do anything in the previous branch. So,

[GitHub] FaxianZhao opened a new pull request #6336: update insert pending segments logic to synchronous

2018-09-17 Thread GitBox
FaxianZhao opened a new pull request #6336: update insert pending segments logic to synchronous URL: https://github.com/apache/incubator-druid/pull/6336 I delete the branch about #6283 by mistake. So I can't modify that pull request. There are some comments. 1. Mysql default tran