leventov commented on a change in pull request #6357: Improve interning in
SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6357#discussion_r219663426
##
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
#
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219658080
##
File path: docs/content/querying/sql.md
##
@@ -519,6 +524,89 @@ SELECT * FROM INFORMATION_SCHEMA.COL
jon-wei commented on issue #6094: Introduce SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#issuecomment-423708361
Reviewed the core SystemSchema class, will do a pass to review the other
files
--
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657965
##
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##
@@ -0,0 +1,58
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219657962
##
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657127
##
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##
@@ -0,0 +1,57
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657639
##
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##
@@ -0,0 +1,57
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219641828
##
File path: docs/content/querying/sql.md
##
@@ -519,6 +524,89 @@ SELECT * FROM INFORMATION_SCHEMA.COL
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219655288
##
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##
@@ -0,0 +1,57
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657534
##
File path: server/src/main/java/org/apache/druid/client/TimelineServerView.java
##
@@ -36,6 +38,9 @@
jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for
compactionTask
URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423708228
@gianm I've tested in my local that this works well. I also fixed a bug in
keepSegmentGranularity option that the com
jon-wei commented on a change in pull request #6094: Introduce SystemSchema
tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219655626
##
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##
@@ -0,0 +1,57
surekhasaharan commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219657909
##
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657793
##
File path: docs/content/querying/sql.md
##
@@ -481,6 +486,88 @@ SELECT * FROM INFORMATION_SCH
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657781
##
File path:
server/src/main/java/org/apache/druid/discovery/DruidLeaderClient.java
##
@@ -133
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657795
##
File path: docs/content/querying/sql.md
##
@@ -481,6 +486,88 @@ SELECT * FROM INFORMATION_SCH
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657794
##
File path: docs/content/querying/sql.md
##
@@ -481,6 +486,88 @@ SELECT * FROM INFORMATION_SCH
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657787
##
File path: docs/content/querying/sql.md
##
@@ -519,6 +524,89 @@ SELECT * FROM INFORMATION_SCH
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657778
##
File path:
server/src/main/java/org/apache/druid/server/http/MetadataResource.java
##
@@ -13
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657790
##
File path: docs/content/querying/sql.md
##
@@ -481,6 +486,88 @@ SELECT * FROM INFORMATION_SCH
surekhasaharan commented on a change in pull request #6094: Introduce
SystemSchema tables (#5989)
URL: https://github.com/apache/incubator-druid/pull/6094#discussion_r219657789
##
File path: docs/content/querying/sql.md
##
@@ -468,6 +468,11 @@ plan SQL queries. This metada
jihoonson commented on issue #5812: AggregatorFactory.getComparator() must be
null-safe
URL:
https://github.com/apache/incubator-druid/issues/5812#issuecomment-423705714
> it might be much better to handle nullability centralized, not to require
for each implementer of AggregatorFactory t
This is an automated email from the ASF dual-hosted git repository.
bslim pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 364bf9d Fix non org.apache.druid files
b-slim closed pull request #6367: Fix non org.apache.druid files and add
package name checkstyle rule
URL: https://github.com/apache/incubator-druid/pull/6367
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of pr
jon-wei commented on issue #6339: Tweak isInvalidRows behavior in
HadoopTuningConfig
URL: https://github.com/apache/incubator-druid/pull/6339#issuecomment-423705178
it's not documented yet, planning on doing a PR for that for 0.13.0
-
jon-wei closed pull request #6364: fix incorrect precondition check in
SupervisorManager.suspendOrResumeSupervisor
URL: https://github.com/apache/incubator-druid/pull/6364
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
t
jon-wei commented on issue #6364: fix incorrect precondition check in
SupervisorManager.suspendOrResumeSupervisor
URL: https://github.com/apache/incubator-druid/pull/6364#issuecomment-423703860
teamcity inspection errors are spurious, approving and merging
-
This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 399a565 fix incorrect precondition che
jihoonson commented on a change in pull request #5913: Move Caching Cluster
Client to java streams and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r219652313
##
File path: server/src/main/java/io/druid/client/CachingClustere
drcrallen commented on issue #5913: Move Caching Cluster Client to java streams
and allow parallel intermediate merges
URL: https://github.com/apache/incubator-druid/pull/5913#issuecomment-423696989
got clobbered by https://github.com/apache/incubator-druid/pull/6313 , fixing
-
jihoonson opened a new pull request #6369: Make JvmThreadsMonitor injectable
URL: https://github.com/apache/incubator-druid/pull/6369
Fixes https://github.com/apache/incubator-druid/issues/5904.
This is an automated message fr
jon-wei commented on issue #6367: Fix non org.apache.druid files and add
package name checkstyle rule
URL: https://github.com/apache/incubator-druid/pull/6367#issuecomment-423693717
@clintropolis Yeah, that looks useful, I added it and it caught some tests
that didn't have a declared packa
jihoonson opened a new pull request #6368: Deprecate task audit logging
URL: https://github.com/apache/incubator-druid/pull/6368
See https://github.com/apache/incubator-druid/issues/5859.
This is an automated message from the
clintropolis commented on issue #6367: Fix non org.apache.druid files and add
package name checkstyle rule
URL: https://github.com/apache/incubator-druid/pull/6367#issuecomment-423691233
Should we add
[PackageDeclarationCheck](http://checkstyle.sourceforge.net/config_coding.html#PackageDec
jon-wei opened a new pull request #6367: Fix non org.apache.druid files and add
package name checkstyle rule
URL: https://github.com/apache/incubator-druid/pull/6367
Moves a couple of test files that were still under "io.druid" package to
"org.apache.druid", and adds a checkstyle rule enfo
jihoonson commented on a change in pull request #6356: Fix indexes introduced
in #6348.
URL: https://github.com/apache/incubator-druid/pull/6356#discussion_r219642555
##
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java
##
@@ -217,9 +217,
This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch 0.12.3
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/0.12.3 by this push:
new c01a68c Add zookeeper/kafka tutorial r
jon-wei closed pull request #6363: [Backport] Add zookeeper/kafka tutorial
reset instructions
URL: https://github.com/apache/incubator-druid/pull/6363
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance
This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new f12ffd1 Add Kafka reset instructions f
jon-wei closed pull request #6362: Add Kafka reset instructions for tutorial
URL: https://github.com/apache/incubator-druid/pull/6362
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fo
jihoonson commented on a change in pull request #6361: Deprecate dimensions /
metrics APIs on brokers
URL: https://github.com/apache/incubator-druid/pull/6361#discussion_r219623860
##
File path: docs/content/operations/api-reference.md
##
@@ -412,10 +412,18 @@ druid.query.
jon-wei commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219598368
##
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##
@
jon-wei commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219597444
##
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##
@
jon-wei commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219596996
##
File path: api/src/main/java/org/apache/druid/indexer/TaskStatusPlus.java
##
@
jon-wei commented on a change in pull request #6334: make 0.13 tasks API
backwards compatible with 0.12 (#6333)
URL: https://github.com/apache/incubator-druid/pull/6334#discussion_r219596587
##
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/Overl
jihoonson commented on issue #6203: Add support targetCompactionSizeBytes for
compactionTask
URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423627930
@gianm not yet. I'll finish by early next week.
This
drcrallen opened a new issue #6366: Pagerank Hacking
URL: https://github.com/apache/incubator-druid/issues/6366
Often times when doing something Druid related, be it posting a job on a job
board, creating a blog post, or hosting an event... it is difficult to
determine the best keywords or
gianm commented on issue #6203: Add support targetCompactionSizeBytes for
compactionTask
URL: https://github.com/apache/incubator-druid/pull/6203#issuecomment-423528375
@jihoonson are you done with the "more tests" you mentioned?
gianm commented on a change in pull request #6361: Deprecate dimensions /
metrics APIs on brokers
URL: https://github.com/apache/incubator-druid/pull/6361#discussion_r219493356
##
File path: docs/content/operations/api-reference.md
##
@@ -412,10 +412,18 @@ druid.query.segm
gianm commented on issue #5584: Decoupling FirehoseFactory and InputRowParser
URL:
https://github.com/apache/incubator-druid/issues/5584#issuecomment-423523025
Thanks @josephglanville - what have been the toughest issues you faced with
StringInputRowParser so far? I haven't scoped out the
leventov closed pull request #6344: Fix a bug which druid's parsing formatted
time field in a non-zero time zone
URL: https://github.com/apache/incubator-druid/pull/6344
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the
egor-ryashin commented on a change in pull request #6357: Improve interning in
SQLMetadataSegmentManager
URL: https://github.com/apache/incubator-druid/pull/6357#discussion_r219331576
##
File path:
server/src/main/java/org/apache/druid/metadata/SQLMetadataSegmentManager.java
#
josephglanville commented on issue #5584: Decoupling FirehoseFactory and
InputRowParser
URL:
https://github.com/apache/incubator-druid/issues/5584#issuecomment-423473524
What I came up with was this:
Firstly a new interface to handle reading a file and emitting rows that can
be pas
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and
InputRowParser
URL:
https://github.com/apache/incubator-druid/issues/5584#issuecomment-423473524
What I came up with was this:
Firstly a new interface to handle reading a file and emitting rows that can
josephglanville commented on issue #5584: Decoupling FirehoseFactory and
InputRowParser
URL:
https://github.com/apache/incubator-druid/issues/5584#issuecomment-423470487
I have done some work privately on our usecase to support our batch
ingestion pipeline but I have been snowed under wit
55 matches
Mail list logo