clintropolis edited a comment on issue #6974: sql support for dynamic parameters
URL: https://github.com/apache/incubator-druid/pull/6974#issuecomment-474706200
@peterlittig, I expect this will probably be merged to master within the
next couple of weeks, barring any major issues uncovered
clintropolis commented on issue #6974: sql support for dynamic parameters
URL: https://github.com/apache/incubator-druid/pull/6974#issuecomment-474706200
@peterlittig, I expect this will probably be merged to master within the
next couple of weeks, barring any major issues uncovered during
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474692002
> Make sure you use the DaraSketches HLL and not the Druid builtin HLL!
Yes,i used the Dat
leerho commented on issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474691264
Make sure you use the DaraSketches HLL and not the Druid builtin HLL!
On Tue, Mar 19, 2019 a
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267188508
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267188508
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267188508
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267182783
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267182783
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
surekhasaharan commented on a change in pull request #7300: Druid console docs
URL: https://github.com/apache/incubator-druid/pull/7300#discussion_r267111824
##
File path: docs/content/operations/druid-console.md
##
@@ -0,0 +1,90 @@
+---
+layout: doc_page
+title: "Druid con
lxqfy opened a new issue #7302: Druid Broker Result Level Cache Not Working
Properly When Different Query Intervals Cover the Same Set of Segments
URL: https://github.com/apache/incubator-druid/issues/7302
Druid Broker Result Level Cache Not Working Properly When Different Query
Intervals
jon-wei commented on issue #6972: Support LDAP authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-474657054
@mohammadjkhan Sorry for the delay, I will start reviewing this week.
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267156636
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java
##
@@ -68,34 +8
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java
##
@@ -70,9
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267163198
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryLimitRowIterator.java
##
@@ -70,9
fjy removed a comment on issue #7300: Druid console docs
URL: https://github.com/apache/incubator-druid/pull/7300#issuecomment-474643927
@clintropolis this is for 0.15 I believe, as it references features that
doesn't exist in the 0.14 build
mohammadjkhan commented on issue #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#issuecomment-474654220
Hi @jon-wei
I'm following up to see if you had the chance to look and review the changes
in this PR yet? It's currently assi
fjy merged pull request #7298: [Backport] Fix race in historical when loading
segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7298
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch 0.14.0-incubating
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/0.14.0-incubating by this push:
new e926121 Fix race in
fjy commented on issue #7300: Druid console docs
URL: https://github.com/apache/incubator-druid/pull/7300#issuecomment-474643927
@clintropolis this is for 0.15 I believe, as it references features that
doesn't exist in the 0.14 build
jon-wei edited a comment on issue #7133: 6088 - Time Ordering On Scans
URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-474640476
I don't think this needs to be something done in this PR, but it's worth
mentioning that moving the "time chunking" behavior to the broker,
jon-wei commented on issue #7133: 6088 - Time Ordering On Scans
URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-474640476
I don't think this needs to be something done in this PR, but it's worth
mentioning that moving the "time chunking" behavior to the broker, and iss
jihoonson commented on issue #7233: Set "is_published" to false for
overshadowed segments in sys.segments table
URL:
https://github.com/apache/incubator-druid/issues/7233#issuecomment-474639633
@leventov oh, I missed it's already there. Thanks.
I talked with @gianm and @surekhasahar
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java
##
@@ -68,34 +8
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r26714
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java
##
@@ -68,34 +8
vogievetsky commented on issue #7292: Add table column selection in druid
console to allow hiding/showing of columns
URL: https://github.com/apache/incubator-druid/pull/7292#issuecomment-474634938
LGTM 👍 @shuqi7 thank you for promptly addressing all my feedback
jihoonson edited a comment on issue #7291: Fix exclusivity for start offset in
kinesis indexing service & check exclusivity properly in
IndexerSQLMetadataStorageCoordinator
URL: https://github.com/apache/incubator-druid/pull/7291#issuecomment-474627712
This PR is ready for review. Updated
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267144903
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java
##
@@ -68,34 +8
jon-wei commented on a change in pull request #7133: 6088 - Time Ordering On
Scans
URL: https://github.com/apache/incubator-druid/pull/7133#discussion_r267139172
##
File path:
processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java
##
@@ -68,34 +8
vogievetsky commented on a change in pull request #7292: Add table column
selection in druid console to allow hiding/showing of columns
URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r267145133
##
File path: web-console/src/utils/index.tsx
##
@@ -20,3
vogievetsky commented on a change in pull request #7292: Add table column
selection in druid console to allow hiding/showing of columns
URL: https://github.com/apache/incubator-druid/pull/7292#discussion_r267143824
##
File path: web-console/src/views/tasks-view.tsx
##
@@ -
gianm commented on a change in pull request #7279: Add committer_readme.md
URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267140272
##
File path: committer_readme.md
##
@@ -0,0 +1,56 @@
+
+## PR action item checklist for committers
+
+1. Add appropriat
gianm commented on a change in pull request #7279: Add committer_readme.md
URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267138895
##
File path: committer_readme.md
##
@@ -0,0 +1,56 @@
+
+## PR action item checklist for committers
+
+1. Add appropriat
gianm commented on a change in pull request #7279: Add committer_readme.md
URL: https://github.com/apache/incubator-druid/pull/7279#discussion_r267142800
##
File path: committer_readme.md
##
@@ -0,0 +1,56 @@
+
+## PR action item checklist for committers
+
+1. Add appropriat
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474629206
Thank you so much!
This is an a
jihoonson commented on issue #7291: Fix exclusivity for start offset in
kinesis indexing service
URL: https://github.com/apache/incubator-druid/pull/7291#issuecomment-474627712
This PR is ready for review. I added `SeekableStreamStartSequenceNumbers`
and `SeekableStreamEndSequenceNumbers`
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return
other AggregatorFactories.
URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474625046
> I am going to revert the naming changes, since I didn't mean to create an
incompatible change.
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return
other AggregatorFactories.
URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624342
I am going to revert the naming changes, since I didn't mean to create an
incompatible change.
gianm commented on issue #7293: AggregatorFactory: Clarify methods that return
other AggregatorFactories.
URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624269
Ah I forgot this was an extension point. I could revert the method naming
changes, I didn't really mean
leventov commented on issue #7293: AggregatorFactory: Clarify methods that
return other AggregatorFactories.
URL: https://github.com/apache/incubator-druid/pull/7293#issuecomment-474624119
Since it's an incompatible change, also adding `Design Review` tag.
-
leventov commented on a change in pull request #7293: AggregatorFactory:
Clarify methods that return other AggregatorFactories.
URL: https://github.com/apache/incubator-druid/pull/7293#discussion_r267131588
##
File path:
processing/src/main/java/org/apache/druid/query/aggregation/A
michael-trelinski commented on a change in pull request #6740: Zookeeper loss
URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r267130059
##
File path:
server/src/test/java/org/apache/druid/curator/BoundedExponentialBackoffRetryWithQuitTest.java
##
@@ -0
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267125648
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267121031
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267123308
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267121031
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267120891
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267121031
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
jon-wei commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267120891
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id o
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267116731
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
leventov commented on a change in pull request #7206: Add the pull-request
template
URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r267115662
##
File path: .github/pull_request_template.md
##
@@ -0,0 +1,53 @@
+Fixes #.
+
+(Replace with the id
This is an automated email from the ASF dual-hosted git repository.
gian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new ff94bd1 Fix conflicting information in c
gianm merged pull request #7299: Fix conflicting information in configuration
doc
URL: https://github.com/apache/incubator-druid/pull/7299
This is an automated message from the Apache Git Service.
To respond to the message,
leventov opened a new pull request #7301: Make 'field can be final' inspection
a warning in IntelliJ config
URL: https://github.com/apache/incubator-druid/pull/7301
A small step towards #7227.
This is an automated message fro
This is an automated email from the ASF dual-hosted git repository.
leventov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new dfd27e0 Avoid many unnecessary mater
leventov merged pull request #7185: Avoid many unnecessary materializations of
collections of 'all segments in cluster' cardinality
URL: https://github.com/apache/incubator-druid/pull/7185
This is an automated message from t
leventov commented on issue #7185: Avoid many unnecessary materializations of
collections of 'all segments in cluster' cardinality
URL: https://github.com/apache/incubator-druid/pull/7185#issuecomment-474589844
@egor-ryashin @clintropolis thanks for reviews.
---
yurmix commented on issue #6430: Contributing Moving-Average Query to open
source.
URL: https://github.com/apache/incubator-druid/pull/6430#issuecomment-474581201
@jihoonson, thanks so much for your effort on this thorough review and sorry
it took me that long to complete my response. I ha
yurmix edited a comment on issue #7290: Moving average query pr2
URL: https://github.com/apache/incubator-druid/pull/7290#issuecomment-474145356
> @yurmix thanks. I'm not sure reopening is better or not though.
Sure thing, I'll go back to the original pr, if we have a merge issue to
yurmix commented on a change in pull request #6430: Contributing Moving-Average
Query to open source.
URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r267088298
##
File path:
extensions-contrib/moving-average-query/src/main/java/org/apache/druid/query/movingaver
vogievetsky opened a new pull request #7300: Druid console docs
URL: https://github.com/apache/incubator-druid/pull/7300
Adding a page for the Druid console docs with screenshots.
Note that these docs are written for the console as it would be in Druid
0.14.0 the version of the conso
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null
or "" into unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474555914
I would recommend using HLL if you don't need intersections and A-not-B
operations, and
justinborromeo opened a new pull request #7299: Fix conflicting information in
configuration doc
URL: https://github.com/apache/incubator-druid/pull/7299
The doc says that both "noop" and "logging" emitters are the default in
different places. Based on the code in EmitterModule, "noop" is
stale[bot] commented on issue #3956: Thread safe reads for aggregators in
IncrementalIndex
URL: https://github.com/apache/incubator-druid/pull/3956#issuecomment-474550197
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further acti
egor-ryashin commented on a change in pull request #7185: Avoid many
unnecessary materializations of collections of 'all segments in cluster'
cardinality
URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r267058115
##
File path:
server/src/main/java/org/apache/dr
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474510220
Thanks for quick reply !
> I don't see how this is possible.
OK, maybe it is my mistask
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null
or "" into unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474503384
I don't see how this is possible.
Regarding HLL, I think it should use less memor
quenlang commented on issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474497181
Thanks for quick reply !
> Theta sketch ignores nulls and empty strings. Are you sure your inp
donbowman commented on a change in pull request #7296: Remove mysql database
connector from container image
URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r267004774
##
File path: distribution/docker/README.md
##
@@ -24,3 +24,15 @@ From the root of the
jihoonson opened a new pull request #7298: [Backport] Fix race in historical
when loading segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7298
Backport of #7203 to 0.14.0-incubating.
This is an automa
jihoonson commented on issue #7203: Fix race in historical when loading
segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474467936
@a2l007 oh, I will backport.
This is an automated me
drcrallen commented on a change in pull request #7296: Remove mysql database
connector from container image
URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r266991954
##
File path: distribution/docker/README.md
##
@@ -24,3 +24,15 @@ From the root of the
drcrallen commented on a change in pull request #7296: Remove mysql database
connector from container image
URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r266991954
##
File path: distribution/docker/README.md
##
@@ -24,3 +24,15 @@ From the root of the
AlexanderSaydakov edited a comment on issue #7297: thetaSketch aggrgator handle
null or "" into unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474460432
Theta sketch ignores nulls and empty strings. Are you sure your input is
really
AlexanderSaydakov commented on issue #7297: thetaSketch aggrgator handle null
or "" into unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474460432
Theta sketch ignores nulls and empty strings. Are you sure your input is
really empty,
AlexanderSaydakov edited a comment on issue #7297: thetaSketch aggrgator handle
null or "" into unexpected value at ingesting
URL:
https://github.com/apache/incubator-druid/issues/7297#issuecomment-474460432
Theta sketch ignores nulls and empty strings. Are you sure your input is
really
a2l007 edited a comment on issue #7203: Fix race in historical when loading
segments in parallel
URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474406915
Hey @jihoonson , would this be backported to 0.14.0? Seeing the same issue
in 0.14.0.
If not, I can use ZK bas
a2l007 commented on issue #7203: Fix race in historical when loading segments
in parallel
URL: https://github.com/apache/incubator-druid/pull/7203#issuecomment-474406915
Hey @jihoonson , would this be backported to 0.14.0? I'm seeing the same
issue in 0.14.0
--
quenlang opened a new issue #7297: thetaSketch aggrgator handle null or "" into
unexpected value at ingesting
URL: https://github.com/apache/incubator-druid/issues/7297
@AlexanderSaydakov @gianm
I had found the thetaSketch aggrgator handle ```null``` or ```""``` into
unexpected value
donbowman opened a new pull request #7296: Remove mysql database connector from
container image
URL: https://github.com/apache/incubator-druid/pull/7296
See discussion on `dev` mailing list from 2019-03
around [docker
build](http://mail-archives.apache.org/mod_mbox/druid-dev/201903.m
yurmix commented on a change in pull request #6430: Contributing Moving-Average
Query to open source.
URL: https://github.com/apache/incubator-druid/pull/6430#discussion_r266774086
##
File path:
extensions-contrib/moving-average-query/src/main/java/org/apache/druid/query/movingaver
81 matches
Mail list logo